Differential D15962

[explorer] Simplify JsonToken
ClosedPublic
Actions

Authored by Fabien on Apr 12 2024, 13:30.

Details

Reviewers

PiRK

Group Reviewers

Restricted Project

Commits

rABCdde4f83cd5d0: [explorer] Simplify JsonToken

Summary

The group id is unused in the templates, and the token type is encoded as i32 so we can avoid the cast.

Test Plan

cargo run

Diff Detail

Repository

rABC Bitcoin ABC

Branch

jsontoken_no_groupid

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 28515
Build 56571: Build Diff
Build 56570: arc lint + arc unit

Event Timeline

Fabien created this revision.Apr 12 2024, 13:30

Herald added a reviewer: Restricted Project. · View Herald TranscriptApr 12 2024, 13:30

Fabien requested review of this revision.Apr 12 2024, 13:30

Harbormaster completed remote builds in B28515: Diff 47089.Apr 12 2024, 13:30

Fabien added a child revision: D15930: [explorer] Switch to new chronik.Apr 12 2024, 13:38

PiRK accepted this revision.Apr 12 2024, 13:40

This revision is now accepted and ready to land.Apr 12 2024, 13:40

Closed by commit rABCdde4f83cd5d0: [explorer] Simplify JsonToken (authored by Fabien). · Explain WhyApr 12 2024, 13:43

This revision was automatically updated to reflect the committed changes.

Fabien added a commit: rABCdde4f83cd5d0: [explorer] Simplify JsonToken.

Revision Contents
Changeset List

Path

Size

web/

explorer/

explorer-server/

src/

api.rs

6 lines

server_primitives.rs

3 lines

Diff 47089

View Options

web/explorer/explorer-server/src/api.rs