Add test case for GetTransactionSigOpCount without the P2SH flags passed in.
ClosedPublic
Actions

Authored by deadalnix on Jul 25 2018, 16:42.

Details

Reviewers

Group Reviewers

Restricted Project

Commits

rSTAGINGb35b4d5a77f5: Add test case for GetTransactionSigOpCount without the P2SH flags passed in.
rABCb35b4d5a77f5: Add test case for GetTransactionSigOpCount without the P2SH flags passed in.

Summary

This is an untested code path.

Depends on D1595

Test Plan

make check

Modify GetTransactionSigOpCount to always count P3SH sigops, make sure the test fails.

Diff Detail

Repository

rABC Bitcoin ABC

Branch

testnop2shsigops

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 2946
Build 3992: Bitcoin ABC Buildbot (legacy)
Build 3991: arc lint + arc unit

Event Timeline

deadalnix created this revision.Jul 25 2018, 16:42

Herald added a reviewer: Restricted Project. · View Herald TranscriptJul 25 2018, 16:42

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

Harbormaster completed remote builds in B2946: Diff 4408.Jul 25 2018, 17:22

deadalnix edited the summary of this revision. (Show Details)Jul 25 2018, 17:48

deadalnix added a parent revision: D1595: Various nits in sigopcount_tests.cpp and script_P2SH_tests.cpp.

deadalnix added a child revision: D1597: Pass flags down to GetP2SHSigOpCount and GetSigOpCountWithoutP2SH.Jul 25 2018, 17:57

jasonbcox accepted this revision.Jul 25 2018, 19:00

This revision is now accepted and ready to land.Jul 25 2018, 19:00

Closed by commit rABCb35b4d5a77f5: Add test case for GetTransactionSigOpCount without the P2SH flags passed in. (authored by deadalnix). · Explain WhyJul 25 2018, 21:03

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

src/

test/

sigopcount_tests.cpp

17 lines

Diff 4408

View Options

src/test/sigopcount_tests.cpp

Add test case for GetTransactionSigOpCount without the P2SH flags passed in.ClosedPublicActions