Page MenuHomePhabricator
Differential D15986

[Cashtab] Stop redirecting to /wallet route from cashtab home
ClosedPublic
Actions

Authored by bytesofman on Apr 15 2024, 21:51.

Details

Reviewers
emack
Group Reviewers
Restricted Project
Commits
rABCca49831df037: [Cashtab] Stop redirecting to /wallet route from cashtab home
Summary

T3461

The home page isn't really the wallet page. Right now, it shows tx history and balance summary. May change in the future.

Remove hardcoded redirect that always took cashtab.com to /wallet.

Stop using selectedKey var, which is taking location.pathname without the '/'. Instead, use `location.pathname' directly.

Maintain support for cashtab.com/#/wallet in case someone clicks a link there or navigates directly there.

Test Plan

npm test

npm start, navigate to http://localhost:3000/#/wallet, see normal home page and home icon is eCash blue

Diff Detail

Repository
rABC Bitcoin ABC
Branch
master
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 28584
Build 56709: Build Diffcashtab-tests
Build 56708: arc lint + arc unit

Event Timeline

bytesofman created this revision.Apr 15 2024, 21:51
Herald added a reviewer: Restricted Project. · View Herald TranscriptApr 15 2024, 21:51
bytesofman edited the test plan for this revision. (Show Details)Apr 15 2024, 21:52
bytesofman updated this revision to Diff 47179.Apr 15 2024, 21:52

highlight home screen if user navigates there using legacy route

bytesofman published this revision for review.Apr 15 2024, 21:54
bytesofman retitled this revision from [Cashtab] Stop adding wallet route to home to [Cashtab] Stop redirecting to /wallet route from cashtab home.
Harbormaster completed remote builds in B28583: Diff 47178.Apr 15 2024, 21:54
Harbormaster completed remote builds in B28584: Diff 47179.
bytesofman updated this revision to Diff 47180.Apr 15 2024, 22:06

fix branch name

Harbormaster completed remote builds in B28585: Diff 47180.Apr 15 2024, 22:10
emack accepted this revision.Apr 16 2024, 01:18
This revision is now accepted and ready to land.Apr 16 2024, 01:18
Closed by commit rABCca49831df037: [Cashtab] Stop redirecting to /wallet route from cashtab home (authored by bytesofman). · Explain WhyApr 16 2024, 02:56
This revision was automatically updated to reflect the committed changes.
bytesofman added a commit: rABCca49831df037: [Cashtab] Stop redirecting to /wallet route from cashtab home.

Revision Contents
Changeset List

PathSize
cashtab/
src/
components/
App/
90 lines
Common/
6 lines

Diff 47179

View Options

cashtab/src/components/App/App.js

Loading...
View Options

cashtab/src/components/Common/ExtensionHeader.js

Loading...