Make sure CScript::GetSigOpCount(CScript &) is tested when called on non P2SH scripts.
ClosedPublic
Actions

Authored by deadalnix on Jul 25 2018, 23:44.

Details

Reviewers

Group Reviewers

Restricted Project

Commits

rSTAGING8aba014ea84e: Make sure CScript::GetSigOpCount(CScript &) is tested when called on non P2SH…
rABC8aba014ea84e: Make sure CScript::GetSigOpCount(CScript &) is tested when called on non P2SH…

Summary

This codepath is not tested at the moment.

Test Plan

Added test cases.

Diff Detail

Repository

rABC Bitcoin ABC

Branch

sigopcounttest

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 2963
Build 4024: Bitcoin ABC Buildbot (legacy)
Build 4023: arc lint + arc unit

Event Timeline

deadalnix created this revision.Jul 25 2018, 23:44

Herald added a reviewer: Restricted Project. · View Herald TranscriptJul 25 2018, 23:44

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

jasonbcox accepted this revision.Jul 25 2018, 23:51

This revision is now accepted and ready to land.Jul 25 2018, 23:51

Closed by commit rABC8aba014ea84e: Make sure CScript::GetSigOpCount(CScript &) is tested when called on non P2SH… (authored by deadalnix). · Explain WhyJul 26 2018, 00:09

This revision was automatically updated to reflect the committed changes.

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing failed.

Harbormaster failed remote builds in B2963: Diff 4430!Jul 26 2018, 00:26

Revision Contents
Changeset List

Path

Size

src/

test/

sigopcount_tests.cpp

49 lines

Diff 4430

View Options

src/test/sigopcount_tests.cpp

Make sure CScript::GetSigOpCount(CScript &) is tested when called on non P2SH scripts.ClosedPublicActions