Details

Reviewers

deadalnix
jasonbcox

Group Reviewers

Restricted Owners Package	(Owns No Changed Paths)
Restricted Project

Commits

rSTAGING96b53e289d03: Partial build fix for WSL, disabling seeder
rABC96b53e289d03: Partial build fix for WSL, disabling seeder

Summary

On the Windows Subsystem for Linux (WSL), the compilation
fails because of bitcoin_seeder. As this app is not a
must-have, the build instructions are updated with the
proper hint.

Still on WSL, a fix from Bitcoin Core is backported in order
to get the tests to compile. See:
https://github.com/meritlabs/merit/commit/c1e291a6ac7ea7ae57697541e308813a87622325

Bitcoin-ABC/bitcoin-abc#190
Bitcoin-ABC/bitcoin-abc#228

Test Plan

Compiles and green tests on Win10 x64 under Ubuntu subsystem.

Diff Detail

Repository

rABC Bitcoin ABC

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

vermorel created this revision.Jul 26 2018, 12:31

Owners added a reviewer: Restricted Owners Package.Jul 26 2018, 12:31

Herald added a reviewer: Restricted Project. · View Herald TranscriptJul 26 2018, 12:31

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

Fix lint style.

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

Harbormaster completed remote builds in B2967: Diff 4435.Jul 26 2018, 13:12

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

Harbormaster completed remote builds in B2968: Diff 4436.Jul 26 2018, 13:21

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

deadalnix requested changes to this revision.Jul 26 2018, 17:11

deadalnix added a subscriber: deadalnix.

deadalnix added inline comments.

doc/build-windows.md
117 ↗	(On Diff #4436)	--without-seeder Also you added the prefix twice.
145 ↗	(On Diff #4436)	dito
src/qt/test/test_main.cpp
69 ↗	(On Diff #4436)	I think it'd be better to add a definition of `setenv` somewhere in `/compat` for win32, that way most of the code do not need to ifdef. setenv is also used in the seeder, and, while it isn't enough to get it to work on windows, that'd be a set in the right direction.