Page MenuHomePhabricator

Partial build fix for WSL, disabling seeder
ClosedPublic

Authored by vermorel on Jul 26 2018, 12:31.

Details

Reviewers
deadalnix
jasonbcox
Group Reviewers
Restricted Owners Package(Owns No Changed Paths)
Restricted Project
Commits
rABC96b53e289d03: Partial build fix for WSL, disabling seeder
rSTAGING96b53e289d03: Partial build fix for WSL, disabling seeder
Summary

On the Windows Subsystem for Linux (WSL), the compilation
fails because of bitcoin_seeder. As this app is not a
must-have, the build instructions are updated with the
proper hint.

Still on WSL, a fix from Bitcoin Core is backported in order
to get the tests to compile. See:
https://github.com/meritlabs/merit/commit/c1e291a6ac7ea7ae57697541e308813a87622325

Bitcoin-ABC/bitcoin-abc#190
Bitcoin-ABC/bitcoin-abc#228

Test Plan

Compiles and green tests on Win10 x64 under Ubuntu subsystem.

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

vermorel created this revision.Jul 26 2018, 12:31
Owners added a reviewer: Restricted Owners Package.Jul 26 2018, 12:31
Herald added a reviewer: Restricted Project. · View Herald TranscriptJul 26 2018, 12:31
vermorel updated this revision to Diff 4436.Jul 26 2018, 12:39

Fix lint style.

deadalnix requested changes to this revision.Jul 26 2018, 17:11
deadalnix added a subscriber: deadalnix.
deadalnix added inline comments.
doc/build-windows.md
117 ↗(On Diff #4436)
--without-seeder

Also you added the prefix twice.

145 ↗(On Diff #4436)

dito

src/qt/test/test_main.cpp
69 ↗(On Diff #4436)

I think it'd be better to add a definition of setenv somewhere in /compat for win32, that way most of the code do not need to ifdef. setenv is also used in the seeder, and, while it isn't enough to get it to work on windows, that'd be a set in the right direction.

This revision now requires changes to proceed.Jul 26 2018, 17:11
vermorel updated this revision to Diff 4439.Jul 26 2018, 17:17

Fixed incorrect argument duplication.

jasonbcox accepted this revision.Jul 26 2018, 19:39
vermorel updated this revision to Diff 4444.Jul 26 2018, 20:03

Isolate compatibility fix for 'setenv()'.

deadalnix accepted this revision.Jul 26 2018, 20:07
deadalnix added inline comments.
src/compat/setenv.h
6 ↗(On Diff #4444)
#include <cstdlib>
9 ↗(On Diff #4444)

This is not the exact behavior, but it'll do for now.

This revision is now accepted and ready to land.Jul 26 2018, 20:07
vermorel updated this revision to Diff 4446.Jul 26 2018, 20:12

Using suitable include.

This revision was automatically updated to reflect the committed changes.