Differential D16044

[chronik-docs] Trim to version number in installation steps
ClosedPublic
Actions

Authored by Fabien on Apr 23 2024, 18:56.

Details

Reviewers

bytesofman

Group Reviewers

Restricted Project

Commits

rABC2aa757dd2aeb: [chronik-docs] Trim to version number in installation steps

Summary

The version file might contain whitespaces which would break the installation instructions/links, so trim it.
Also remove the newline in the sample file for good measure.

Test Plan

Deploy and check the installation instructions and links are properly generated even when the version file has whitespaces/newlines.

Diff Detail

Repository

rABC Bitcoin ABC

Branch

chronik_doc_fix_version_newline

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 28719
Build 56978: Build Diff
Build 56977: arc lint + arc unit

Event Timeline

Fabien created this revision.Apr 23 2024, 18:56

Herald added a reviewer: Restricted Project. · View Herald TranscriptApr 23 2024, 18:56

Fabien requested review of this revision.Apr 23 2024, 18:56

Harbormaster completed remote builds in B28719: Diff 47383.Apr 23 2024, 18:56

bytesofman accepted this revision.Apr 23 2024, 20:41

This revision is now accepted and ready to land.Apr 23 2024, 20:41

Closed by commit rABC2aa757dd2aeb: [chronik-docs] Trim to version number in installation steps (authored by Fabien). · Explain WhyApr 24 2024, 07:19

This revision was automatically updated to reflect the committed changes.

Fabien added a commit: rABC2aa757dd2aeb: [chronik-docs] Trim to version number in installation steps.

Revision Contents
Changeset List

Path

Size

modules/

docs/

chronik.e.cash/

.abclatestversion.sample

2 lines

docs/

0-chronik-setup/

00-download.mdx

3 lines

Diff 47383

View Options

modules/docs/chronik.e.cash/.abclatestversion.sample