Page MenuHomePhabricator

Fix implicit-integer-sign-change in verifychain
ClosedPublic

Authored by PiRK on Apr 29 2024, 06:51.

Details

Reviewers
Fabien
Group Reviewers
Restricted Project
Commits
rABC06a8ad6a7c7a: Fix implicit-integer-sign-change in verifychain
Summary

rpc: Fix implicit-integer-sign-change in verifychain

Avoid implicit-integer-sign-change in VerifyLoadedChainstate

This happens when checking all blocks (check_blocks=-1).

The UB in VerifyLoadedChainstate was inadvertently fixed in D14614 when the unsigned int parameters became int64_t.
This backport just adds the test coverage in rpc_blochain.py

This is a backport of core#24403 and core#24347

Test Plan

With UBSAN

ninja all check-all

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Lint Not Applicable
Unit
Tests Not Applicable