HomePhabricator

Fix implicit-integer-sign-change in verifychain

Description

Fix implicit-integer-sign-change in verifychain

Summary:

rpc: Fix implicit-integer-sign-change in verifychain

Avoid implicit-integer-sign-change in VerifyLoadedChainstate

This happens when checking all blocks (check_blocks=-1).

The UB in VerifyLoadedChainstate was inadvertently fixed in D14614 when the unsigned int parameters became int64_t.
This backport just adds the test coverage in rpc_blochain.py

This is a backport of core#24403 and core#24347

Test Plan:
With UBSAN

ninja all check-all

Reviewers: #bitcoin_abc, Fabien

Reviewed By: #bitcoin_abc, Fabien

Differential Revision: https://reviews.bitcoinabc.org/D16067

Details

Provenance
MarcoFalke <falke.marco@gmail.com>Authored on Feb 15 2022, 10:27
PiRKCommitted on Apr 29 2024, 10:37
PiRKPushed on Apr 29 2024, 10:37
Reviewer
Restricted Project
Differential Revision
D16067: Fix implicit-integer-sign-change in verifychain
Parents
rABCaea735354309: [Automated] Update chainparams
Branches
Unknown
Tags
Unknown