Add support for setting foreign currency to MYR
T3562
Details
Details
- Reviewers
emack - Group Reviewers
Restricted Project - Commits
- rABC15b0788f25c2: [Cashtab] Add support for Malaysian Ringgit
Proofread to confirm correct ticker and symbol. npm start and confirm price makes sense.
Diff Detail
Diff Detail
- Repository
- rABC Bitcoin ABC
- Branch
- support-myr
- Lint
Lint Passed - Unit
No Test Coverage - Build Status
Buildable 28793 Build 57124: Build Diff cashtab-tests Build 57123: arc lint + arc unit
Event Timeline
Comment Actions
Coingecko feed on google vs cashtab. Is this delta within an acceptable threshold?
We aren't in the business of adjudicating proper forex arbitrage.
Ultimately, we are trusting coingecko to provide accurate forex. Cashtab is designed to disable fiat currency features if the API is down.
In this case, coingecko probably has better forex-specific crypto data than google. google results are basically garbage these days. would be classic google if those prices came from coingecko but a team of 30 people spent 6 months optimizing the feature so that it's providing a result that has been cached for 48 hours.