Page MenuHomePhabricator
Differential D16100

[e.cash] Change from Bitgo utxo-lib to ecash-lib on Build page
ClosedPublic
Actions

Authored by Mengerian on May 2 2024, 17:01.

Details

Reviewers
bytesofman
Group Reviewers
Restricted Project
Commits
rABC528dfe6ad359: [e.cash] Change from Bitgo utxo-lib to ecash-lib on Build page
Summary

Now that it's implemented in Cashtab, we should recommend the new ecash-lib

Test Plan

Run it locally, check link

Diff Detail

Repository
rABC Bitcoin ABC
Branch
e.cash-build-ecash-lib
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 29325
Build 58186: Build Diff
Build 58185: arc lint + arc unit

Event Timeline

Mengerian created this revision.May 2 2024, 17:01
Herald added a reviewer: Restricted Project. · View Herald TranscriptMay 2 2024, 17:01
Mengerian requested review of this revision.May 2 2024, 17:01
Harbormaster completed remote builds in B28866: Diff 47576.May 2 2024, 17:02
Mengerian planned changes to this revision.May 2 2024, 17:06

Wait until lib is deployed properly

bytesofman requested changes to this revision.Jun 10 2024, 18:06

I think it's ok to get this in now. But we should also remove ecash-lib from the "Coming soon" section

Mengerian updated this revision to Diff 48276.Jun 17 2024, 17:13
Mengerian edited the summary of this revision. (Show Details)

Remove "coming soon" section
Update wording
Rebase

Harbormaster completed remote builds in B29324: Diff 48276.Jun 17 2024, 17:13
bytesofman added a comment.Jun 17 2024, 17:14

@bot preview-e.cash

teamcity awarded a token.Jun 17 2024, 17:15

Build Bitcoin ABC Diffs / Diff Testing (preview-e.cash) passed.
Preview is available at http://54.39.104.128:41805 for the next 60 minutes.

bytesofman accepted this revision.Jun 17 2024, 17:18
This revision is now accepted and ready to land.Jun 17 2024, 17:18
Mengerian updated this revision to Diff 48277.Jun 17 2024, 17:20

Rebase

Harbormaster completed remote builds in B29325: Diff 48277.Jun 17 2024, 17:20
Closed by commit rABC528dfe6ad359: [e.cash] Change from Bitgo utxo-lib to ecash-lib on Build page (authored by Mengerian). · Explain WhyJun 17 2024, 19:34
This revision was automatically updated to reflect the committed changes.
Mengerian added a commit: rABC528dfe6ad359: [e.cash] Change from Bitgo utxo-lib to ecash-lib on Build page.

Revision Contents
Changeset List

PathSize
web/
e.cash/
pages/
16 lines

Diff 48277

View Options

web/e.cash/pages/build.js

Loading...