[ecash-lib] Support `"target": "es2016"`
AbandonedPublic
Actions

Authored by tobias_ruck on May 3 2024, 13:33.

Details

Reviewers

bytesofman

Group Reviewers

Restricted Project

Summary

Previously, the compile target for TS was set to es2020 as we made extensive use of BigInt literals, however, support for lower targets is required, so we replace BigInt literals with calls to the BigInt function.

Test Plan

npm run build + CI

Diff Detail

Repository

rABC Bitcoin ABC

Branch

ecash-lib-support-es2016

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 28876
Build 57290: Build Diff	ecash-lib-integration-tests · ecash-agora-integration-tests · ecash-lib-tests
Build 57289: arc lint + arc unit

Event Timeline

tobias_ruck created this revision.May 3 2024, 13:33

Herald added a reviewer: Restricted Project. · View Herald TranscriptMay 3 2024, 13:33

Harbormaster completed remote builds in B28876: Diff 47597.May 3 2024, 13:42

tobias_ruck added a child revision: D16107: [ecash-lib] "module": "CommonJS" + separate "main" and "browser".May 3 2024, 13:45

tobias_ruck published this revision for review.May 3 2024, 21:31

tobias_ruck retitled this revision from [ecash-lib] Support `es2016` to [ecash-lib] Support `"target": "es2016"`.

bytesofman accepted this revision.May 3 2024, 22:47

This revision is now accepted and ready to land.May 3 2024, 22:47

This seems unnecessary and hurts code readability

Yes, following discussion in TG -- if this is not necessary to build the lib in a way that jest can import it without experimental features, then this should be abandoned

bytesofman mentioned this in D16107: [ecash-lib] "module": "CommonJS" + separate "main" and "browser".May 4 2024, 13:35

tobias_ruck removed a child revision: D16107: [ecash-lib] "module": "CommonJS" + separate "main" and "browser".May 4 2024, 14:45

tobias_ruck abandoned this revision.May 6 2024, 20:04