Page MenuHomePhabricator

[ecash-lib] Support `"target": "es2016"`
AbandonedPublic

Authored by tobias_ruck on May 3 2024, 13:33.

Details

Reviewers
bytesofman
Group Reviewers
Restricted Project
Summary

Previously, the compile target for TS was set to es2020 as we made extensive use of BigInt literals, however, support for lower targets is required, so we replace BigInt literals with calls to the BigInt function.

Test Plan

npm run build + CI

Diff Detail

Repository
rABC Bitcoin ABC
Branch
ecash-lib-support-es2016
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 28876
Build 57290: Build Diffecash-lib-integration-tests · ecash-agora-integration-tests · ecash-lib-tests
Build 57289: arc lint + arc unit

Event Timeline

tobias_ruck retitled this revision from [ecash-lib] Support `es2016` to [ecash-lib] Support `"target": "es2016"`.
This revision is now accepted and ready to land.May 3 2024, 22:47

This seems unnecessary and hurts code readability

Yes, following discussion in TG -- if this is not necessary to build the lib in a way that jest can import it without experimental features, then this should be abandoned