Page MenuHomePhabricator

[Cashtab] word-break fix for tokens with very long names
ClosedPublic

Authored by bytesofman on May 5 2024, 21:58.

Details

Reviewers
emack
Group Reviewers
Restricted Project
Commits
rABC2f1ee1dd98ba: [Cashtab] word-break fix for tokens with very long names
Summary

Add word-break: break-all for elements that may display token name

Test Plan

npm test

no overflow for long token names:

image.png (460×502 px, 67 KB)

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

bytesofman published this revision for review.May 5 2024, 21:58
bytesofman edited the test plan for this revision. (Show Details)
emack requested changes to this revision.May 5 2024, 22:05
emack added a subscriber: emack.

text-overflow: ellipsis; would be a better option here i think

This revision now requires changes to proceed.May 5 2024, 22:05

text-overflow: ellipsis; would be a better option here i think

if they have gone through the trouble of naming it that way, might as well render it all.

we use ellipsis for the token doc url bc the URL still goes there, and nobody reads a super long URL

in this case...it would be pretty silly to have a token with such a long name (not broken by any spaces). but if we really want to avoid that, we should prevent it with validation in genesis txs.

If it happens...i wanna see the token name without having to pull up the dev console and check local storage (or chronik-cli for token info) -- options that normal users won't even be able to do.

This revision is now accepted and ready to land.May 6 2024, 00:49