This is another step toward deglobalizing the Config.
This diff does not deal with the fuzzer, this will be split in another diff.
Depends on D16116
Details
Details
- Reviewers
Fabien - Group Reviewers
Restricted Project - Commits
- rABC21770c4bb1b0: get config via ChainstateManager when it is reachable
ninja all check-all bench-bitcoin
Diff Detail
Diff Detail
- Repository
- rABC Bitcoin ABC
- Branch
- getconfig
- Lint
Lint Passed - Unit
No Test Coverage - Build Status
Buildable 28906 Build 57350: Build Diff lint-circular-dependencies · build-without-wallet · build-diff · build-debug · build-clang-tidy · build-clang · build-bench Build 57349: arc lint + arc unit
Event Timeline
Comment Actions
Build Bitcoin ABC Diffs / Diff Testing (build-clang) failed.
Tail of the build log:
[444/499] Running utility command for check-bitcoin-fs_tests [445/499] bitcoin: testing checkpoints_tests [446/499] Running utility command for check-bitcoin-checkpoints_tests [447/499] bitcoin: testing cuckoocache_tests [448/499] Running utility command for check-bitcoin-cuckoocache_tests [449/499] bitcoin: testing key_io_tests [450/499] bitcoin: testing ismine_tests [451/499] bitcoin: testing scheduler_tests [452/499] Running utility command for check-bitcoin-key_io_tests [453/499] bitcoin: testing crypto_tests [454/499] Running utility command for check-bitcoin-ismine_tests [455/499] Running utility command for check-bitcoin-scheduler_tests [456/499] bitcoin: testing txvalidationcache_tests [457/499] Running utility command for check-bitcoin-crypto_tests [458/499] Running utility command for check-bitcoin-txvalidationcache_tests [459/499] bitcoin: testing scriptpubkeyman_tests [460/499] Running utility command for check-bitcoin-scriptpubkeyman_tests [461/499] bitcoin: testing result_tests [462/499] Running utility command for check-bitcoin-result_tests [463/499] bitcoin: testing walletdb_tests [464/499] Running utility command for check-bitcoin-walletdb_tests [465/499] bitcoin: testing psbt_wallet_tests [466/499] bitcoin: testing denialofservice_tests [467/499] bitcoin: testing init_tests [468/499] Running utility command for check-bitcoin-psbt_wallet_tests [469/499] Running utility command for check-bitcoin-denialofservice_tests [470/499] Running utility command for check-bitcoin-init_tests [471/499] bitcoin: testing uint256_tests [472/499] bitcoin: testing rcu_tests [473/499] Running utility command for check-bitcoin-uint256_tests [474/499] Running utility command for check-bitcoin-rcu_tests [475/499] bitcoin: testing merkle_tests [476/499] bitcoin: testing coinstatsindex_tests [477/499] Running utility command for check-bitcoin-merkle_tests [478/499] bitcoin: testing transaction_tests FAILED: src/test/CMakeFiles/check-bitcoin-transaction_tests cd /work/abc-ci-builds/build-clang/src/test && /usr/bin/cmake -E make_directory /work/abc-ci-builds/build-clang/test/junit && /usr/bin/cmake -E make_directory /work/abc-ci-builds/build-clang/test/log && /usr/bin/cmake -E env /work/cmake/utils/log-and-print-on-failure.sh /work/abc-ci-builds/build-clang/test/log/bitcoin-transaction_tests.log /work/abc-ci-builds/build-clang/src/test/test_bitcoin --run_test=transaction_tests --logger=HRF,message:JUNIT,message,bitcoin-transaction_tests.xml --catch_system_errors=no Segmentation fault (core dumped) [479/499] Running utility command for check-bitcoin-coinstatsindex_tests [480/499] bitcoin: testing sighash_tests [481/499] Running utility command for check-bitcoin-sighash_tests [482/499] bitcoin: testing blockmanager_tests [483/499] bitcoin: testing validation_chainstate_tests [484/499] Running utility command for check-bitcoin-blockmanager_tests [485/499] Running utility command for check-bitcoin-validation_chainstate_tests [486/499] bitcoin: testing wallet_crypto_tests [487/499] Running utility command for check-bitcoin-wallet_crypto_tests [488/499] bitcoin: testing coinselector_tests [489/499] bitcoin: testing blockcheck_tests [490/499] Running utility command for check-bitcoin-coinselector_tests [491/499] Running utility command for check-bitcoin-blockcheck_tests [492/499] bitcoin: testing wallet_tests [493/499] Running utility command for check-bitcoin-wallet_tests [494/499] bitcoin: testing coins_tests [495/499] Running utility command for check-bitcoin-coins_tests [496/499] secp256k1: testing secp256k1-tests [497/499] Running secp256k1 test suite PASSED: secp256k1 test suite ninja: build stopped: cannot make progress due to previous errors. Build build-clang failed with exit code 1
Comment Actions
Build Bitcoin ABC Diffs / Diff Testing (build-clang-tidy) failed.
Tail of the build log:
[446/492] bitcoin: testing rcu_tests [447/492] Running utility command for check-bitcoin-sighash_tests [448/492] Running utility command for check-bitcoin-coinstatsindex_tests [449/492] bitcoin: testing validation_chainstate_tests [450/492] pow: testing eda_tests [451/492] bitcoin: testing blockmanager_tests [452/492] Running utility command for check-bitcoin-rcu_tests [453/492] Running utility command for check-bitcoin-validation_chainstate_tests [454/492] Running utility command for check-pow-eda_tests [455/492] Running utility command for check-bitcoin-blockmanager_tests [456/492] Test Bitcoin RPC authentication... ... ---------------------------------------------------------------------- Ran 3 tests in 0.005s OK [457/492] cd /work/contrib/devtools/chainparams && /usr/bin/python3.9 ./test_make_chainparams.py ..... ---------------------------------------------------------------------- Ran 5 tests in 0.002s OK [458/492] pow: testing grasberg_tests [459/492] Running utility command for check-pow-grasberg_tests [460/492] Running pow test suite PASSED: pow test suite [461/492] bitcoin: testing wallet_crypto_tests [462/492] Running utility command for check-bitcoin-wallet_crypto_tests [463/492] bitcoin: testing coinselector_tests [464/492] Running utility command for check-bitcoin-coinselector_tests [465/492] bitcoin: testing blockcheck_tests [466/492] Running utility command for check-bitcoin-blockcheck_tests [467/492] bitcoin: testing wallet_tests [468/492] Running utility command for check-bitcoin-wallet_tests [469/492] Building CXX object src/seeder/test/CMakeFiles/test-seeder.dir/fixture.cpp.o [470/492] Linking CXX executable src/seeder/test/test-seeder [471/492] seeder: testing options_tests [472/492] seeder: testing p2p_messaging_tests [473/492] seeder: testing parse_name_tests [474/492] seeder: testing message_writer_tests [475/492] Running utility command for check-seeder-parse_name_tests [476/492] Running utility command for check-seeder-p2p_messaging_tests [477/492] Running utility command for check-seeder-options_tests [478/492] Running utility command for check-seeder-message_writer_tests [479/492] seeder: testing write_name_tests [480/492] Running utility command for check-seeder-write_name_tests [481/492] Running seeder test suite PASSED: seeder test suite [482/492] bitcoin: testing coins_tests [483/492] Running utility command for check-bitcoin-coins_tests [484/492] Building CXX object src/qt/test/CMakeFiles/test_bitcoin-qt.dir/__/__/wallet/test/wallet_test_fixture.cpp.o [485/492] Building CXX object src/qt/test/CMakeFiles/test_bitcoin-qt.dir/paymentservertests.cpp.o [486/492] Building CXX object src/qt/test/CMakeFiles/test_bitcoin-qt.dir/addressbooktests.cpp.o [487/492] Building CXX object src/qt/test/CMakeFiles/test_bitcoin-qt.dir/wallettests.cpp.o [488/492] Linking CXX executable src/qt/test/test_bitcoin-qt [489/492] bitcoin-qt: testing test_bitcoin-qt [490/492] Running bitcoin-qt test suite PASSED: bitcoin-qt test suite ninja: build stopped: cannot make progress due to previous errors. Build build-clang-tidy failed with exit code 1
Comment Actions
Build Bitcoin ABC Diffs / Diff Testing (build-without-wallet) failed.
Tail of the build log:
[0m[1;30mwallet_import_with_label.py | ○ Skipped | 0 s [0m[1;30mwallet_importdescriptors.py | ○ Skipped | 0 s [0m[1;30mwallet_importmulti.py | ○ Skipped | 0 s [0m[1;30mwallet_importprunedfunds.py | ○ Skipped | 0 s [0m[1;30mwallet_importprunedfunds.py --descriptors | ○ Skipped | 0 s [0m[1;30mwallet_keypool.py | ○ Skipped | 0 s [0m[1;30mwallet_keypool_topup.py | ○ Skipped | 0 s [0m[1;30mwallet_keypool_topup.py --descriptors | ○ Skipped | 0 s [0m[1;30mwallet_labels.py | ○ Skipped | 0 s [0m[1;30mwallet_labels.py --descriptors | ○ Skipped | 0 s [0m[1;30mwallet_listreceivedby.py | ○ Skipped | 0 s [0m[1;30mwallet_listsinceblock.py | ○ Skipped | 0 s [0m[1;30mwallet_listsinceblock.py --descriptors | ○ Skipped | 0 s [0m[1;30mwallet_listtransactions.py | ○ Skipped | 0 s [0m[1;30mwallet_listtransactions.py --descriptors | ○ Skipped | 0 s [0m[1;30mwallet_multiwallet.py | ○ Skipped | 0 s [0m[1;30mwallet_multiwallet.py --descriptors | ○ Skipped | 0 s [0m[1;30mwallet_multiwallet.py --usecli | ○ Skipped | 0 s [0m[1;30mwallet_reorgsrestore.py | ○ Skipped | 0 s [0m[1;30mwallet_resendwallettransactions.py | ○ Skipped | 0 s [0m[1;30mwallet_send.py | ○ Skipped | 0 s [0m[1;30mwallet_startup.py | ○ Skipped | 0 s [0m[1;30mwallet_timelock.py | ○ Skipped | 0 s [0m[1;30mwallet_txn_clone.py | ○ Skipped | 0 s [0m[1;30mwallet_txn_clone.py --mineblock | ○ Skipped | 0 s [0m[1;30mwallet_txn_doublespend.py | ○ Skipped | 0 s [0m[1;30mwallet_txn_doublespend.py --mineblock | ○ Skipped | 0 s [0m[1;30mwallet_watchonly.py | ○ Skipped | 0 s [0m[1;30mwallet_watchonly.py --usecli | ○ Skipped | 0 s [0m[1m ALL | ✓ Passed | 833 s (accumulated) [0mRuntime: 168 s [158/460] Test Bitcoin RPC authentication... ... ---------------------------------------------------------------------- Ran 3 tests in 0.005s OK [160/460] cd /work/contrib/devtools/chainparams && /usr/bin/python3.9 ./test_make_chainparams.py ..... ---------------------------------------------------------------------- Ran 5 tests in 0.001s OK [188/460] Running seeder test suite PASSED: seeder test suite [191/460] Running pow test suite PASSED: pow test suite [409/460] bitcoin: testing transaction_tests FAILED: src/test/CMakeFiles/check-bitcoin-transaction_tests cd /work/abc-ci-builds/build-without-wallet/src/test && /usr/bin/cmake -E make_directory /work/abc-ci-builds/build-without-wallet/test/junit && /usr/bin/cmake -E make_directory /work/abc-ci-builds/build-without-wallet/test/log && /usr/bin/cmake -E env /work/cmake/utils/log-and-print-on-failure.sh /work/abc-ci-builds/build-without-wallet/test/log/bitcoin-transaction_tests.log /work/abc-ci-builds/build-without-wallet/src/test/test_bitcoin --run_test=transaction_tests --logger=HRF,message:JUNIT,message,bitcoin-transaction_tests.xml --catch_system_errors=no Segmentation fault (core dumped) [436/460] Running avalanche test suite PASSED: avalanche test suite [455/460] Running bitcoin-qt test suite PASSED: bitcoin-qt test suite [457/460] Running utility command for check-bitcoin-coins_tests ninja: build stopped: cannot make progress due to previous errors. Build build-without-wallet failed with exit code 1
Comment Actions
Build Bitcoin ABC Diffs / Diff Testing (build-debug) failed.
Tail of the build log:
[0m[1;30mchronik_resync.py | ○ Skipped | 0 s [0m[1;30mchronik_script_confirmed_txs.py | ○ Skipped | 0 s [0m[1;30mchronik_script_history.py | ○ Skipped | 0 s [0m[1;30mchronik_script_unconfirmed_txs.py | ○ Skipped | 0 s [0m[1;30mchronik_script_utxos.py | ○ Skipped | 0 s [0m[1;30mchronik_serve.py | ○ Skipped | 0 s [0m[1;30mchronik_spent_by.py | ○ Skipped | 0 s [0m[1;30mchronik_token_alp.py | ○ Skipped | 0 s [0m[1;30mchronik_token_broadcast_txs.py | ○ Skipped | 0 s [0m[1;30mchronik_token_burn.py | ○ Skipped | 0 s [0m[1;30mchronik_token_id_group.py | ○ Skipped | 0 s [0m[1;30mchronik_token_parse_failure.py | ○ Skipped | 0 s [0m[1;30mchronik_token_script_group.py | ○ Skipped | 0 s [0m[1;30mchronik_token_slp_fungible.py | ○ Skipped | 0 s [0m[1;30mchronik_token_slp_mint_vault.py | ○ Skipped | 0 s [0m[1;30mchronik_token_slp_nft1.py | ○ Skipped | 0 s [0m[1;30mchronik_tx.py | ○ Skipped | 0 s [0m[1;30mchronik_tx_removal_order.py | ○ Skipped | 0 s [0m[1;30mchronik_ws.py | ○ Skipped | 0 s [0m[1;30mchronik_ws_ordering.py | ○ Skipped | 0 s [0m[1;30mchronik_ws_ping.py | ○ Skipped | 0 s [0m[1;30mchronik_ws_script.py | ○ Skipped | 0 s [0m[1;30mfeature_bind_port_discover.py | ○ Skipped | 0 s [0m[1;30mfeature_bind_port_externalip.py | ○ Skipped | 0 s [0m[1;30minterface_usdt_net.py | ○ Skipped | 0 s [0m[1;30minterface_usdt_utxocache.py | ○ Skipped | 0 s [0m[1;30minterface_usdt_validation.py | ○ Skipped | 0 s [0m[1m ALL | ✓ Passed | 2881 s (accumulated) [0mRuntime: 581 s [205/500] Test Bitcoin RPC authentication... ... ---------------------------------------------------------------------- Ran 3 tests in 0.020s OK [207/500] cd /work/contrib/devtools/chainparams && /usr/bin/python3.9 ./test_make_chainparams.py ..... ---------------------------------------------------------------------- Ran 5 tests in 0.001s OK [306/500] Running secp256k1 test suite PASSED: secp256k1 test suite [332/500] bitcoin: testing transaction_tests FAILED: src/test/CMakeFiles/check-bitcoin-transaction_tests cd /work/abc-ci-builds/build-debug/src/test && /usr/bin/cmake -E make_directory /work/abc-ci-builds/build-debug/test/junit && /usr/bin/cmake -E make_directory /work/abc-ci-builds/build-debug/test/log && /usr/bin/cmake -E env /work/cmake/utils/log-and-print-on-failure.sh /work/abc-ci-builds/build-debug/test/log/bitcoin-transaction_tests.log /work/abc-ci-builds/build-debug/src/test/test_bitcoin --run_test=transaction_tests --logger=HRF,message:JUNIT,message,bitcoin-transaction_tests.xml --catch_system_errors=no Segmentation fault (core dumped) [458/500] Running pow test suite PASSED: pow test suite [473/500] Running seeder test suite PASSED: seeder test suite [483/500] Running avalanche test suite PASSED: avalanche test suite [485/500] Running bitcoin-qt test suite PASSED: bitcoin-qt test suite [497/500] Running utility command for check-bitcoin-coins_tests ninja: build stopped: cannot make progress due to previous errors. Build build-debug failed with exit code 1
Comment Actions
Build Bitcoin ABC Diffs / Diff Testing (build-diff) failed.
Tail of the build log:
[0m[0;32mwallet_multiwallet.py --usecli | ✓ Passed | 9 s [0m[0;32mwallet_reorgsrestore.py | ✓ Passed | 3 s [0m[0;32mwallet_resendwallettransactions.py | ✓ Passed | 14 s [0m[0;32mwallet_send.py | ✓ Passed | 8 s [0m[0;32mwallet_startup.py | ✓ Passed | 2 s [0m[0;32mwallet_timelock.py | ✓ Passed | 1 s [0m[0;32mwallet_txn_clone.py | ✓ Passed | 2 s [0m[0;32mwallet_txn_clone.py --mineblock | ✓ Passed | 2 s [0m[0;32mwallet_txn_doublespend.py | ✓ Passed | 1 s [0m[0;32mwallet_txn_doublespend.py --mineblock | ✓ Passed | 2 s [0m[0;32mwallet_watchonly.py | ✓ Passed | 1 s [0m[0;32mwallet_watchonly.py --usecli | ✓ Passed | 1 s [0m[1;30mchronik_avalanche.py | ○ Skipped | 0 s [0m[1;30mchronik_block.py | ○ Skipped | 0 s [0m[1;30mchronik_block_info.py | ○ Skipped | 0 s [0m[1;30mchronik_block_txs.py | ○ Skipped | 0 s [0m[1;30mchronik_blockchain_info.py | ○ Skipped | 0 s [0m[1;30mchronik_blocks.py | ○ Skipped | 0 s [0m[1;30mchronik_chronik_info.py | ○ Skipped | 0 s [0m[1;30mchronik_cors.py | ○ Skipped | 0 s [0m[1;30mchronik_disable_token_index.py | ○ Skipped | 0 s [0m[1;30mchronik_disallow_prune.py | ○ Skipped | 0 s [0m[1;30mchronik_lokad_id_group.py | ○ Skipped | 0 s [0m[1;30mchronik_mempool_conflicts.py | ○ Skipped | 0 s [0m[1;30mchronik_pause.py | ○ Skipped | 0 s [0m[1;30mchronik_plugins_setup.py | ○ Skipped | 0 s [0m[1;30mchronik_raw_tx.py | ○ Skipped | 0 s [0m[1;30mchronik_resync.py | ○ Skipped | 0 s [0m[1;30mchronik_script_confirmed_txs.py | ○ Skipped | 0 s [0m[1;30mchronik_script_history.py | ○ Skipped | 0 s [0m[1;30mchronik_script_unconfirmed_txs.py | ○ Skipped | 0 s [0m[1;30mchronik_script_utxos.py | ○ Skipped | 0 s [0m[1;30mchronik_serve.py | ○ Skipped | 0 s [0m[1;30mchronik_spent_by.py | ○ Skipped | 0 s [0m[1;30mchronik_token_alp.py | ○ Skipped | 0 s [0m[1;30mchronik_token_broadcast_txs.py | ○ Skipped | 0 s [0m[1;30mchronik_token_burn.py | ○ Skipped | 0 s [0m[1;30mchronik_token_id_group.py | ○ Skipped | 0 s [0m[1;30mchronik_token_parse_failure.py | ○ Skipped | 0 s [0m[1;30mchronik_token_script_group.py | ○ Skipped | 0 s [0m[1;30mchronik_token_slp_fungible.py | ○ Skipped | 0 s [0m[1;30mchronik_token_slp_mint_vault.py | ○ Skipped | 0 s [0m[1;30mchronik_token_slp_nft1.py | ○ Skipped | 0 s [0m[1;30mchronik_tx.py | ○ Skipped | 0 s [0m[1;30mchronik_tx_removal_order.py | ○ Skipped | 0 s [0m[1;30mchronik_ws.py | ○ Skipped | 0 s [0m[1;30mchronik_ws_ordering.py | ○ Skipped | 0 s [0m[1;30mchronik_ws_ping.py | ○ Skipped | 0 s [0m[1;30mchronik_ws_script.py | ○ Skipped | 0 s [0m[1;30mfeature_bind_port_discover.py | ○ Skipped | 0 s [0m[1;30mfeature_bind_port_externalip.py | ○ Skipped | 0 s [0m[1;30minterface_usdt_net.py | ○ Skipped | 0 s [0m[1;30minterface_usdt_utxocache.py | ○ Skipped | 0 s [0m[1;30minterface_usdt_validation.py | ○ Skipped | 0 s [0m[1m ALL | ✓ Passed | 1289 s (accumulated) [0mRuntime: 266 s ninja: build stopped: cannot make progress due to previous errors. Build build-diff failed with exit code 1
Comment Actions
fix transaction_tests by using a ChainTestingSetup in the test that needs consensus params