[Cashtab] Improve minified nav header to prevent content jumping
ClosedPublic
Actions

Authored by bytesofman on Mon, May 6, 22:44.

Details

Reviewers

emack

Group Reviewers

Restricted Project

Commits

rABCf16bbdb8b284: [Cashtab] Improve minified nav header to prevent content jumping

Summary

T3564

Use position: sticky to stop content jumping when the minified header is activated.

Test Plan

npm test

visit https://cashtab-local-dev.netlify.app/ and scroll, no content jumping

Diff Detail

Repository

rABC Bitcoin ABC

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

bytesofman created this revision.Mon, May 6, 22:44

Herald added a reviewer: Restricted Project. · View Herald TranscriptMon, May 6, 22:44

bytesofman edited the test plan for this revision. (Show Details)Mon, May 6, 22:47

Harbormaster completed remote builds in B28922: Diff 47656.Mon, May 6, 22:48

bytesofman published this revision for review.Mon, May 6, 22:52

bytesofman added inline comments.

cashtab/src/components/App/App.css
57 ↗	(On Diff #47656)	we can't use `sticky` if there is hidden overflow in any parent element

Much better. Although I noticed it is scrolling even when there isn't content down below, however that's in prod too so not specific to this diff but nontheless I think previously we tried to stop that?

This revision is now accepted and ready to land.Tue, May 7, 05:57

In D16122#365091, @emack wrote:

Much better. Although I noticed it is scrolling even when there isn't content down below, however that's in prod too so not specific to this diff but nontheless I think previously we tried to stop that?

yeah I think there are still some more optimizations available. I haven't figured out what's causing this, could be unique to browsers.

Closed by commit rABCf16bbdb8b284: [Cashtab] Improve minified nav header to prevent content jumping (authored by bytesofman). · Explain WhyTue, May 7, 16:33

This revision was automatically updated to reflect the committed changes.

bytesofman added a commit: rABCf16bbdb8b284: [Cashtab] Improve minified nav header to prevent content jumping.