[ecash-herald] Use monorepo deps instead of npm
ClosedPublic
Actions

Authored by bytesofman on May 8 2024, 21:39.

Details

Reviewers

Fabien

Group Reviewers

Restricted Project

Commits

rABCfd6cc31d1fbd: [ecash-herald] Use monorepo deps instead of npm

Summary

Follow model used to successfully move Cashtab away from npm dependencies and toward monorepo hosted dependencies for packages maintained by ABC

Note: CI will be updated before landing

Test Plan

docker build -f ecash-herald.Dockerfile -t ecash-herald_local .
./contrib/teamcity/build-configurations.py ecash-herald-tests

Diff Detail

Repository

rABC Bitcoin ABC

Branch

herald-local-deps

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 28944
Build 57425: Build Diff	ecash-herald-tests
Build 57424: arc lint + arc unit

Event Timeline

bytesofman created this revision.May 8 2024, 21:39

Herald added a reviewer: Restricted Project. · View Herald TranscriptMay 8 2024, 21:39

bytesofman edited the summary of this revision. (Show Details)May 8 2024, 21:39

Harbormaster completed remote builds in B28944: Diff 47691.May 8 2024, 21:41

Build Bitcoin ABC Diffs / Diff Testing (ecash-herald-tests) failed.

Tail of the build log:

    at require (node:internal/modules/helpers:179:18)
    at Object.<anonymous> (/work/modules/ecashaddrjs/src/cashaddr.js:13:14)
    at Module._compile (node:internal/modules/cjs/loader:1369:14)
    at Module.replacementCompile (/usr/lib/node_modules/nyc/node_modules/append-transform/index.js:60:13)
    at Module._extensions..js (node:internal/modules/cjs/loader:1427:10)
    at Object.<anonymous> (/usr/lib/node_modules/nyc/node_modules/append-transform/index.js:64:4)
    at Module.load (node:internal/modules/cjs/loader:1206:32)
    at Module._load (node:internal/modules/cjs/loader:1022:12)
    at Module.require (node:internal/modules/cjs/loader:1231:19)
    at require (node:internal/modules/helpers:179:18)
    at Object.<anonymous> (/work/apps/ecash-herald/src/chronik.js:5:200)
    at Module._compile (node:internal/modules/cjs/loader:1369:14)
    at Module.replacementCompile (/usr/lib/node_modules/nyc/node_modules/append-transform/index.js:60:13)
    at Module._extensions..js (node:internal/modules/cjs/loader:1427:10)
    at Object.<anonymous> (/usr/lib/node_modules/nyc/node_modules/append-transform/index.js:64:4)
    at Module.load (node:internal/modules/cjs/loader:1206:32)
    at Module._load (node:internal/modules/cjs/loader:1022:12)
    at Module.require (node:internal/modules/cjs/loader:1231:19)
    at require (node:internal/modules/helpers:179:18)
    at Object.<anonymous> (/work/apps/ecash-herald/test/chronik.test.js:7:29)
    at Module._compile (node:internal/modules/cjs/loader:1369:14)
    at Module.replacementCompile (/usr/lib/node_modules/nyc/node_modules/append-transform/index.js:60:13)
    at Module._extensions..js (node:internal/modules/cjs/loader:1427:10)
    at Object.<anonymous> (/usr/lib/node_modules/nyc/node_modules/append-transform/index.js:64:4)
    at Module.load (node:internal/modules/cjs/loader:1206:32)
    at Module._load (node:internal/modules/cjs/loader:1022:12)
    at cjsLoader (node:internal/modules/esm/translators:366:17)
    at ModuleWrap.<anonymous> (node:internal/modules/esm/translators:315:7)
    at ModuleJob.run (node:internal/modules/esm/module_job:222:25)
    at async ModuleLoader.import (node:internal/modules/esm/loader:323:24)
    at async formattedImport (/work/apps/ecash-herald/node_modules/mocha/lib/nodejs/esm-utils.js:9:14)
    at async exports.requireOrImport (/work/apps/ecash-herald/node_modules/mocha/lib/nodejs/esm-utils.js:42:28)
    at async exports.loadFilesAsync (/work/apps/ecash-herald/node_modules/mocha/lib/nodejs/esm-utils.js:100:20)
    at async singleRun (/work/apps/ecash-herald/node_modules/mocha/lib/cli/run-helpers.js:125:3)
    at async exports.handler (/work/apps/ecash-herald/node_modules/mocha/lib/cli/run.js:370:5)
------------------------|---------|----------|---------|---------|-------------------
File                    | % Stmts | % Branch | % Funcs | % Lines | Uncovered Line #s 
------------------------|---------|----------|---------|---------|-------------------
All files               |    6.93 |        0 |       0 |    7.07 |                   
 ecash-herald           |     100 |      100 |     100 |     100 |                   
  config.js             |     100 |      100 |     100 |     100 |                   
 ecash-herald/constants |     100 |      100 |     100 |     100 |                   
  addresses.js          |     100 |      100 |     100 |     100 |                   
 ecash-herald/src       |    4.08 |        0 |       0 |    4.16 |                   
  chronik.js            |    4.65 |        0 |       0 |    4.65 | 8-120             
  utils.js              |    3.92 |        0 |       0 |    4.02 | 15-392            
------------------------|---------|----------|---------|---------|-------------------

##teamcity[blockOpened name='Code Coverage Summary']
##teamcity[buildStatisticValue key='CodeCoverageAbsBCovered' value='14']
##teamcity[buildStatisticValue key='CodeCoverageAbsBTotal' value='202']
##teamcity[buildStatisticValue key='CodeCoverageAbsRCovered' value='0']
##teamcity[buildStatisticValue key='CodeCoverageAbsRTotal' value='97']
##teamcity[buildStatisticValue key='CodeCoverageAbsMCovered' value='0']
##teamcity[buildStatisticValue key='CodeCoverageAbsMTotal' value='30']
##teamcity[buildStatisticValue key='CodeCoverageAbsLCovered' value='14']
##teamcity[buildStatisticValue key='CodeCoverageAbsLTotal' value='198']
##teamcity[blockClosed name='Code Coverage Summary']
mv: cannot stat 'test_results/ecash-herald-junit.xml': No such file or directory
Build ecash-herald-tests failed with exit code 1