test: Default initialize `should_freeze` to `true`
ClosedPublic
Actions

Authored by PiRK on May 13 2024, 06:55.

Details

Reviewers

Fabien

Group Reviewers

Restricted Project

Commits

rABC8bdd266333c9: test: Default initialize `should_freeze` to `true`

Summary

It is safe now, when move semantics is used instead of a custom swap
function.

This is a partial backport of core#26749
https://github.com/bitcoin/bitcoin/pull/26749/commits/95ad70ab652ddde7de65f633c36c1378b26a313a

Depends on D16146

Test Plan

ninja check

Diff Detail

Repository

rABC Bitcoin ABC

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

PiRK created this revision.May 13 2024, 06:55

Herald added a reviewer: Restricted Project. · View Herald TranscriptMay 13 2024, 06:55

PiRK requested review of this revision.May 13 2024, 06:55

teamcity edited the summary of this revision. (Show Details)May 13 2024, 06:55

PiRK added a child revision: D16148: clang-tidy: Fix modernize-use-default-member-init in `CScriptCheck`.May 13 2024, 06:56

Harbormaster completed remote builds in B28985: Diff 47742.May 13 2024, 08:11

Fabien accepted this revision.May 13 2024, 14:00

This revision is now accepted and ready to land.May 13 2024, 14:00

Closed by commit rABC8bdd266333c9: test: Default initialize `should_freeze` to `true` (authored by Hennadii Stepanov <32963518+hebasto@users.noreply.github.com>, committed by PiRK). · Explain WhyMay 13 2024, 16:48

This revision was automatically updated to reflect the committed changes.

PiRK added a commit: rABC8bdd266333c9: test: Default initialize `should_freeze` to `true`.

Revision Contents
Changeset List

Path

Size

src/

test/

checkqueue_tests.cpp

9 lines

Diff 47750

View Options

src/test/checkqueue_tests.cpp

test: Default initialize `should_freeze` to `true`ClosedPublicActions