Page MenuHomePhabricator
Differential D16194

[chronik] Wait for the correct tip finalization in chronik_ws_ordering
ClosedPublic
Actions

Authored by Fabien on May 21 2024, 14:18.

Details

Reviewers
PiRK
Group Reviewers
Restricted Project
Commits
rABC44d71a2036b2: [chronik] Wait for the correct tip finalization in chronik_ws_ordering
Summary

The test correctly waits for the last block to get finalized in order to check message ordering, but it's wrong on the tip because the get_quorum function actually mines blocks.

Test Plan
./test/functional/test_runner.py chronik_ws_ordering

Diff Detail

Repository
rABC Bitcoin ABC
Branch
fix_chronik_ws_ordering
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 29052
Build 57640: Build Diffbuild-without-wallet · build-diff · build-debug · build-clang-tidy · build-clang
Build 57639: arc lint + arc unit

Event Timeline

Fabien created this revision.May 21 2024, 14:18
Herald added a reviewer: Restricted Project. · View Herald TranscriptMay 21 2024, 14:18
Fabien requested review of this revision.May 21 2024, 14:18
PiRK accepted this revision.May 21 2024, 14:38
This revision is now accepted and ready to land.May 21 2024, 14:38
This revision was landed with ongoing or failed builds.May 21 2024, 14:40
Closed by commit rABC44d71a2036b2: [chronik] Wait for the correct tip finalization in chronik_ws_ordering (authored by Fabien). · Explain Why
This revision was automatically updated to reflect the committed changes.
Fabien added a commit: rABC44d71a2036b2: [chronik] Wait for the correct tip finalization in chronik_ws_ordering.
Harbormaster completed remote builds in B29052: Diff 47851.May 21 2024, 14:56

Revision Contents
Changeset List

PathSize
test/
functional/
5 lines

Diff 47851

View Options

test/functional/chronik_ws_ordering.py

Loading...