Page MenuHomePhabricator

kernel: Add progress method to notifications
ClosedPublic

Authored by PiRK on Thu, May 23, 09:18.

Details

Reviewers
Fabien
Group Reviewers
Restricted Project
Commits
rABCc2307765fd61: kernel: Add progress method to notifications
Summary

This commit is part of the libbitcoinkernel project and seeks to remove
the ChainstateManager's and, more generally, the kernel library's
dependency on interface_ui with options methods in this and the
following few commits. By removing interface_ui from the kernel library,
its dependency on boost is reduced to just boost::multi_index.

This is a partial backport of core#27636
https://github.com/bitcoin/bitcoin/pull/27636/commits/4452707edec91c7d7991f486dd41ef3edb4f7fbf
Depends on D16205

Test Plan

ninja all check-all

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

PiRK requested review of this revision.Thu, May 23, 09:18
Fabien requested changes to this revision.Thu, May 23, 13:45
Fabien added a subscriber: Fabien.
Fabien added inline comments.
src/bitcoin-chainstate.cpp
39 ↗(On Diff #47920)

that seems wrong, bilingual_str is not defined in <string>

src/kernel/notifications_interface.h
9 ↗(On Diff #47920)

same here, seems unnecessary

src/node/kernel_notifications.cpp
8 ↗(On Diff #47920)

that's the right one

src/node/kernel_notifications.h
11 ↗(On Diff #47920)

dito

This revision now requires changes to proceed.Thu, May 23, 13:45

include util/translation.h rather than <string>, and only if necessary (use forward declarations of bilingual_str when possible)

This revision is now accepted and ready to land.Thu, May 23, 17:09