Differential D16216

Output license info when binaries are passed -version
ClosedPublic
Actions

Authored by PiRK on Thu, May 23, 15:37.

Details

Reviewers

Fabien

Group Reviewers

Restricted Project

Commits

rABC787c14c6272b: Output license info when binaries are passed -version

Summary

Consolidate to outputting the licensing info when we pass -version to a binary.
Prior to this commit, the behavior is inconsistent between the various binaries.

This is a partial backport of core#24409
https://github.com/bitcoin/bitcoin/pull/24409/commits/2618fb8d15d01dca967856c92ebf3e4cc09699a2

Depends on D16215

Test Plan

ninja check-functional
src/bitcoind -version
src/bitcoin-cli -version
src/bitcoin-wallet -version
src/bitcoin-tx -version

Test that the output of the manpage generation script makes sense for bitcoin-tx and bitcoin-wallet

Diff Detail

Repository

rABC Bitcoin ABC

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

PiRK created this revision.Thu, May 23, 15:37

Herald added a reviewer: Restricted Project. · View Herald TranscriptThu, May 23, 15:37

PiRK requested review of this revision.Thu, May 23, 15:37

teamcity edited the summary of this revision. (Show Details)Thu, May 23, 15:38

PiRK edited the test plan for this revision. (Show Details)Thu, May 23, 15:40

PiRK added a child revision: D16217: refactor: Move system from util to common library.Thu, May 23, 15:41

Harbormaster completed remote builds in B29116: Diff 47934.Thu, May 23, 16:23

Fabien accepted this revision.Fri, May 24, 12:30

This revision is now accepted and ready to land.Fri, May 24, 12:30

Closed by commit rABC787c14c6272b: Output license info when binaries are passed -version (authored by fanquake <fanquake@gmail.com>, committed by PiRK). · Explain WhyFri, May 24, 15:33

This revision was automatically updated to reflect the committed changes.

PiRK added a commit: rABC787c14c6272b: Output license info when binaries are passed -version.

Revision Contents
Changeset List

Path

Size

src/

bitcoin-cli.cpp

5 lines

bitcoin-tx.cpp

28 lines

bitcoin-wallet.cpp

31 lines

Diff 47954

View Options

src/bitcoin-cli.cpp

View Options

src/bitcoin-tx.cpp

View Options

Output license info when binaries are passed -versionClosedPublicActions

Details

Diff Detail

Event Timeline

Revision ContentsChangeset List

Diff 47954

src/bitcoin-cli.cpp

src/bitcoin-tx.cpp

src/bitcoin-wallet.cpp

Output license info when binaries are passed -version
ClosedPublic
Actions

Revision Contents
Changeset List