Differential D16238

Use proper ordering for sending txs in p2p_compactblocks
ClosedPublic
Actions

Authored by Fabien on May 28 2024, 21:16.

Details

Reviewers

PiRK

Group Reviewers

Restricted Project

Commits

rABCfd3d8fbb2490: Use proper ordering for sending txs in p2p_compactblocks

Summary

One test is missing this (while others already use topological ordering). This could cause some txs to not be added to the mempool without an extra round of messaging after the loop logic change in the orphanage processing from core#26295.

Test Plan

./test/functional/test_runner.py p2p_compactblocks

Diff Detail

Repository

rABC Bitcoin ABC

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

Fabien created this revision.May 28 2024, 21:16

Herald added a reviewer: Restricted Project. · View Herald TranscriptMay 28 2024, 21:16

Fabien requested review of this revision.May 28 2024, 21:16

teamcity edited the summary of this revision. (Show Details)May 28 2024, 21:16

Harbormaster completed remote builds in B29151: Diff 47994.May 28 2024, 21:28

PiRK accepted this revision.May 29 2024, 06:23

This revision is now accepted and ready to land.May 29 2024, 06:23

Closed by commit rABCfd3d8fbb2490: Use proper ordering for sending txs in p2p_compactblocks (authored by Fabien). · Explain WhyMay 29 2024, 07:41

This revision was automatically updated to reflect the committed changes.

Fabien added a commit: rABCfd3d8fbb2490: Use proper ordering for sending txs in p2p_compactblocks.

Revision Contents
Changeset List

Path

Size

test/

functional/

p2p_compactblocks.py

12 lines

Diff 47997

View Options

test/functional/p2p_compactblocks.py

Use proper ordering for sending txs in p2p_compactblocksClosedPublicActions