Page MenuHomePhabricator

Use proper ordering for sending txs in p2p_compactblocks
ClosedPublic

Authored by Fabien on May 28 2024, 21:16.

Details

Reviewers
PiRK
Group Reviewers
Restricted Project
Commits
rABCfd3d8fbb2490: Use proper ordering for sending txs in p2p_compactblocks
Summary

One test is missing this (while others already use topological ordering). This could cause some txs to not be added to the mempool without an extra round of messaging after the loop logic change in the orphanage processing from core#26295.

Test Plan
./test/functional/test_runner.py p2p_compactblocks

Diff Detail

Repository
rABC Bitcoin ABC
Branch
fix_compactblocks
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 29151
Build 57838: Build Diffbuild-diff · build-without-wallet · build-clang-tidy · build-debug · build-clang
Build 57837: arc lint + arc unit