Differential D16243

rpc: adjust incorrect RPCHelpMan types
ClosedPublic
Actions

Authored by Fabien on May 29 2024, 13:11.

Details

Reviewers

PiRK

Group Reviewers

Restricted Project

Commits

rABC5cbb2dbe0473: rpc: adjust incorrect RPCHelpMan types

Summary

This PR adjusts the two issues I encountered while developing a tool that converts RPCHelpMan objects into bindings for other language(s).

The first is in createrawtransaction, where the address part, e.g. bc1qabc in

    createrawtransaction '[]' '[{"bc1qabc": 1.0}]'

is declared as a Type::OBJ, when in reality it should be a Type::OBJ_USER_KEYS, defined as such:

bitcoin/src/rpc/util.h

Line 126 in 5925f1e
 OBJ_USER_KEYS, //!< Special type where the user must set the keys e.g. to define multiple addresses; as opposed to e.g. an options object where the keys are predefined

(coincidentally, this is the first and only (afaict) usage of this RPCArg::Type).

The second is in the listaddressgroupings RPC, which returns an array of arrays of arrays, where the innermost one is a tuple-thingie with an optional 3rd item; this is an ARR_FIXED, not an ARR.

Backport of core#21897.

Test Plan

ninja all check-all

Diff Detail

Repository

rABC Bitcoin ABC

Branch

PR21897

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 29163
Build 57862: Build Diff	lint-circular-dependencies · build-without-wallet · build-diff · build-debug · build-clang-tidy · build-clang
Build 57861: arc lint + arc unit

Event Timeline

Fabien created this revision.May 29 2024, 13:11

Herald added a reviewer: Restricted Project. · View Herald TranscriptMay 29 2024, 13:11

Fabien requested review of this revision.May 29 2024, 13:11

teamcity edited the summary of this revision. (Show Details)May 29 2024, 13:12

PiRK accepted this revision.May 29 2024, 13:44

This revision is now accepted and ready to land.May 29 2024, 13:44

Harbormaster completed remote builds in B29163: Diff 48021.May 29 2024, 13:44

Build Bitcoin ABC Diffs / Diff Testing (build-diff) failed.

Tail of the build log:

[0m[0;32mwallet_multiwallet.py --usecli             | ✓ Passed  | 21 s
[0m[0;32mwallet_reorgsrestore.py                    | ✓ Passed  | 7 s
[0m[0;32mwallet_resendwallettransactions.py         | ✓ Passed  | 3 s
[0m[0;32mwallet_send.py                             | ✓ Passed  | 13 s
[0m[0;32mwallet_startup.py                          | ✓ Passed  | 6 s
[0m[0;32mwallet_timelock.py                         | ✓ Passed  | 2 s
[0m[0;32mwallet_txn_clone.py                        | ✓ Passed  | 4 s
[0m[0;32mwallet_txn_clone.py --mineblock            | ✓ Passed  | 4 s
[0m[0;32mwallet_txn_doublespend.py                  | ✓ Passed  | 3 s
[0m[0;32mwallet_txn_doublespend.py --mineblock      | ✓ Passed  | 4 s
[0m[0;32mwallet_watchonly.py                        | ✓ Passed  | 3 s
[0m[0;32mwallet_watchonly.py --usecli               | ✓ Passed  | 3 s
[0m[1;30mchronik_avalanche.py                       | ○ Skipped | 0 s
[0m[1;30mchronik_block.py                           | ○ Skipped | 0 s
[0m[1;30mchronik_block_info.py                      | ○ Skipped | 0 s
[0m[1;30mchronik_block_txs.py                       | ○ Skipped | 0 s
[0m[1;30mchronik_blockchain_info.py                 | ○ Skipped | 0 s
[0m[1;30mchronik_blocks.py                          | ○ Skipped | 0 s
[0m[1;30mchronik_chronik_info.py                    | ○ Skipped | 0 s
[0m[1;30mchronik_cors.py                            | ○ Skipped | 0 s
[0m[1;30mchronik_disable_token_index.py             | ○ Skipped | 0 s
[0m[1;30mchronik_disallow_prune.py                  | ○ Skipped | 0 s
[0m[1;30mchronik_lokad_id_group.py                  | ○ Skipped | 0 s
[0m[1;30mchronik_mempool_conflicts.py               | ○ Skipped | 0 s
[0m[1;30mchronik_pause.py                           | ○ Skipped | 0 s
[0m[1;30mchronik_plugins_setup.py                   | ○ Skipped | 0 s
[0m[1;30mchronik_raw_tx.py                          | ○ Skipped | 0 s
[0m[1;30mchronik_resync.py                          | ○ Skipped | 0 s
[0m[1;30mchronik_script_confirmed_txs.py            | ○ Skipped | 0 s
[0m[1;30mchronik_script_history.py                  | ○ Skipped | 0 s
[0m[1;30mchronik_script_unconfirmed_txs.py          | ○ Skipped | 0 s
[0m[1;30mchronik_script_utxos.py                    | ○ Skipped | 0 s
[0m[1;30mchronik_serve.py                           | ○ Skipped | 0 s
[0m[1;30mchronik_spent_by.py                        | ○ Skipped | 0 s
[0m[1;30mchronik_token_alp.py                       | ○ Skipped | 0 s
[0m[1;30mchronik_token_broadcast_txs.py             | ○ Skipped | 0 s
[0m[1;30mchronik_token_burn.py                      | ○ Skipped | 0 s
[0m[1;30mchronik_token_id_group.py                  | ○ Skipped | 0 s
[0m[1;30mchronik_token_parse_failure.py             | ○ Skipped | 0 s
[0m[1;30mchronik_token_script_group.py              | ○ Skipped | 0 s
[0m[1;30mchronik_token_slp_fungible.py              | ○ Skipped | 0 s
[0m[1;30mchronik_token_slp_mint_vault.py            | ○ Skipped | 0 s
[0m[1;30mchronik_token_slp_nft1.py                  | ○ Skipped | 0 s
[0m[1;30mchronik_tx.py                              | ○ Skipped | 0 s
[0m[1;30mchronik_tx_removal_order.py                | ○ Skipped | 0 s
[0m[1;30mchronik_ws.py                              | ○ Skipped | 0 s
[0m[1;30mchronik_ws_ordering.py                     | ○ Skipped | 0 s
[0m[1;30mchronik_ws_ping.py                         | ○ Skipped | 0 s
[0m[1;30mchronik_ws_script.py                       | ○ Skipped | 0 s
[0m[1;30mfeature_bind_port_discover.py              | ○ Skipped | 0 s
[0m[1;30mfeature_bind_port_externalip.py            | ○ Skipped | 0 s
[0m[1;30minterface_usdt_net.py                      | ○ Skipped | 0 s
[0m[1;30minterface_usdt_utxocache.py                | ○ Skipped | 0 s
[0m[1;30minterface_usdt_validation.py               | ○ Skipped | 0 s
[0m[1m
ALL                                        | ✓ Passed  | 1930 s (accumulated) 
[0mRuntime: 386 s

ninja: build stopped: cannot make progress due to previous errors.
Build build-diff failed with exit code 1

This revision was landed with ongoing or failed builds.May 29 2024, 16:36

Closed by commit rABC5cbb2dbe0473: rpc: adjust incorrect RPCHelpMan types (authored by Karl-Johan Alm <karljohan-alm@garage.co.jp>, committed by Fabien). · Explain Why

This revision was automatically updated to reflect the committed changes.

Fabien added a commit: rABC5cbb2dbe0473: rpc: adjust incorrect RPCHelpMan types.