Differential D16248

doc: Fix rpc docs
ClosedPublic
Actions

Authored by Fabien on May 29 2024, 21:59.

Details

Reviewers

PiRK

Group Reviewers

Restricted Project

Commits

rABCe95f486e6669: doc: Fix rpc docs

Summary

The fix removes the "type" OBJ_EMPTY added in commit 8d1a3e6, which isn't really a separate type and instead runs a check on OBJ whether it is empty or not.

Backport of core#24155.

Test Plan

ninja all check-all

Diff Detail

Repository

rABC Bitcoin ABC

Branch

PR24155

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 29169
Build 57874: Build Diff	build-without-wallet · lint-circular-dependencies · build-clang-tidy · build-diff · build-clang · build-debug
Build 57873: arc lint + arc unit

Event Timeline

Fabien created this revision.May 29 2024, 21:59

Herald added a reviewer: Restricted Project. · View Herald TranscriptMay 29 2024, 21:59

Fabien requested review of this revision.May 29 2024, 21:59

teamcity edited the summary of this revision. (Show Details)May 29 2024, 21:59

Harbormaster completed remote builds in B29169: Diff 48030.May 29 2024, 22:13

Build Bitcoin ABC Diffs / Diff Testing (build-diff) failed.

Failed tests logs:

====== Bitcoin ABC functional tests: feature_config_args.py ======

------- Stdout: -------
2024-05-29T22:03:20.110000Z TestFramework (INFO): Initializing test directory /work/abc-ci-builds/build-diff/test/tmp/test_runner_₿₵_  _20240529_220215/feature_config_args_15
2024-05-29T22:03:26.713000Z TestFramework (INFO): Test config args logging
2024-05-29T22:03:26.993000Z TestFramework (INFO): Test seed peers
2024-05-29T22:03:31.542000Z TestFramework (ERROR): Assertion failed
Traceback (most recent call last):
  File "/work/test/functional/test_framework/test_framework.py", line 147, in main
    self._run_test_internal()
  File "/work/test/functional/test_framework/test_framework.py", line 137, in _run_test_internal
    self.run_test()
  File "/work/test/functional/feature_config_args.py", line 321, in run_test
    self.test_seed_peers()
  File "/work/test/functional/feature_config_args.py", line 316, in test_seed_peers
    self.nodes[0].setmocktime(start + 65)
  File "/usr/lib/python3.9/contextlib.py", line 124, in __exit__
    next(self.gen)
  File "/work/test/functional/test_framework/test_node.py", line 604, in assert_debug_log
    self._raise_assertion_error(
  File "/work/test/functional/test_framework/test_node.py", line 261, in _raise_assertion_error
    raise AssertionError(self._node_msg(msg))
AssertionError: [node 0] Expected messages "['Adding fixed seeds as 60 seconds have passed and addrman is empty']" does not partially match log:

 - 2024-05-29T22:03:29.529851Z (mocktime: 2024-05-29T22:03:29Z) [../../src/util/thread.cpp:17] [TraceThread] addcon thread start
 - 2024-05-29T22:03:29.529956Z (mocktime: 2024-05-29T22:03:29Z) [../../src/net.cpp:440] [ConnectNode] trying connection fakenodeaddr lastseen=0.0hrs
 - 2024-05-29T22:03:29.530027Z (mocktime: 2024-05-29T22:03:29Z) [../../src/httpserver.cpp:249] [http_request_cb] Received a POST request for / from 127.0.0.1:47310
 - 2024-05-29T22:03:29.530142Z (mocktime: 2024-05-29T22:03:29Z) [../../src/rpc/request.cpp:188] [parse] ThreadRPCServer method=setmocktime user=__cookie__
 - 2024-05-29T22:03:29.535800Z (mocktime: 2024-05-29T22:04:34Z) [../../src/util/thread.cpp:17] [TraceThread] opencon thread start


2024-05-29T22:03:31.594000Z TestFramework (INFO): Stopping nodes
2024-05-29T22:03:31.696000Z TestFramework (WARNING): Not cleaning up dir /work/abc-ci-builds/build-diff/test/tmp/test_runner_₿₵_  _20240529_220215/feature_config_args_15
2024-05-29T22:03:31.696000Z TestFramework (ERROR): Test failed. Test logging available at /work/abc-ci-builds/build-diff/test/tmp/test_runner_₿₵_  _20240529_220215/feature_config_args_15/test_framework.log
2024-05-29T22:03:31.696000Z TestFramework (ERROR): 
2024-05-29T22:03:31.696000Z TestFramework (ERROR): Hint: Call /work/test/functional/combine_logs.py '/work/abc-ci-builds/build-diff/test/tmp/test_runner_₿₵_  _20240529_220215/feature_config_args_15' to consolidate all logs
2024-05-29T22:03:31.696000Z TestFramework (ERROR): 
2024-05-29T22:03:31.696000Z TestFramework (ERROR): If this failure happened unexpectedly or intermittently, please file a bug and provide a link or upload of the combined log.
2024-05-29T22:03:31.696000Z TestFramework (ERROR): https://github.com/Bitcoin-ABC/bitcoin-abc/issues
2024-05-29T22:03:31.696000Z TestFramework (ERROR):

Each failure log is accessible here:
Bitcoin ABC functional tests: feature_config_args.py