Page MenuHomePhabricator

[avalanche] don't use global g_avalanche in Chainstate code
AbandonedPublic

Authored by PiRK on Mon, Jun 3, 06:38.

Details

Reviewers
Fabien
Group Reviewers
Restricted Project
Summary

Pass the avalanche processor to Chainstate::ActivateBestChain and Chainstate::AvalancheFinalizeBlock
Depends on D16260

Test Plan

ninja all check-all

Event Timeline

PiRK requested review of this revision.Mon, Jun 3, 06:38
Fabien requested changes to this revision.Mon, Jun 3, 13:24
Fabien added a subscriber: Fabien.

I'm not sure having a pointer to the avalanche processor in the chainstate is the right approach. This creates a circular dependency and is error prone. Can't the pointer be passed where it is needed without making it a member ? This also solves the "IBD chain vs active chain" issue.

This revision now requires changes to proceed.Mon, Jun 3, 13:24
PiRK edited the summary of this revision. (Show Details)

try passing the processor to chainstate functions that need it

PiRK planned changes to this revision.Mon, Jun 3, 15:03

This is not ready. I'm getting test failures.

Tail of the build log:

[448/505] bitcoin: testing ismine_tests
[449/505] bitcoin: testing db_tests
[450/505] bitcoin: testing intmath_tests
[451/505] Running utility command for check-bitcoin-db_tests
[452/505] Running utility command for check-bitcoin-ismine_tests
[453/505] Running utility command for check-bitcoin-intmath_tests
[454/505] bitcoin: testing crypto_tests
[455/505] bitcoin: testing txvalidationcache_tests
[456/505] Running utility command for check-bitcoin-crypto_tests
[457/505] bitcoin: testing scriptpubkeyman_tests
[458/505] Running utility command for check-bitcoin-txvalidationcache_tests
[459/505] Running utility command for check-bitcoin-scriptpubkeyman_tests
[460/505] bitcoin: testing result_tests
[461/505] bitcoin: testing psbt_wallet_tests
[462/505] bitcoin: testing walletdb_tests
[463/505] Running utility command for check-bitcoin-result_tests
[464/505] Running utility command for check-bitcoin-psbt_wallet_tests
[465/505] Running utility command for check-bitcoin-walletdb_tests
[466/505] bitcoin: testing rcu_tests
[467/505] bitcoin: testing transaction_tests
[468/505] Running utility command for check-bitcoin-rcu_tests
[469/505] Running utility command for check-bitcoin-transaction_tests
[470/505] bitcoin: testing compress_tests
[471/505] bitcoin: testing merkle_tests
[472/505] bitcoin: testing denialofservice_tests
[473/505] bitcoin: testing init_tests
[474/505] bitcoin: testing uint256_tests
[475/505] Running utility command for check-bitcoin-compress_tests
[476/505] Running utility command for check-bitcoin-merkle_tests
[477/505] bitcoin: testing sighash_tests
[478/505] Running utility command for check-bitcoin-denialofservice_tests
[479/505] Running utility command for check-bitcoin-init_tests
[480/505] Running utility command for check-avalanche-peermanager_tests
[481/505] Running utility command for check-avalanche-voterecord_tests
[482/505] Running utility command for check-bitcoin-uint256_tests
[483/505] bitcoin: testing cuckoocache_tests
[484/505] bitcoin: testing coinstatsindex_tests
[485/505] Running utility command for check-bitcoin-sighash_tests
[486/505] Running utility command for check-bitcoin-coinstatsindex_tests
[487/505] Running utility command for check-bitcoin-cuckoocache_tests
[488/505] bitcoin: testing blockmanager_tests
[489/505] Running utility command for check-bitcoin-blockmanager_tests
[490/505] bitcoin: testing validation_chainstate_tests
[491/505] Running utility command for check-bitcoin-validation_chainstate_tests
[492/505] Linking CXX executable src/qt/test/test_bitcoin-qt
[493/505] bitcoin: testing wallet_crypto_tests
[494/505] Running utility command for check-bitcoin-wallet_crypto_tests
[495/505] bitcoin-qt: testing test_bitcoin-qt
[496/505] Running bitcoin-qt test suite
PASSED: bitcoin-qt test suite
[497/505] bitcoin: testing wallet_tests
[498/505] Running utility command for check-bitcoin-wallet_tests
[499/505] bitcoin: testing coinselector_tests
[500/505] Running utility command for check-bitcoin-coinselector_tests
[501/505] bitcoin: testing coins_tests
[502/505] Running utility command for check-bitcoin-coins_tests
[503/505] Running bitcoin test suite
PASSED: bitcoin test suite
ninja: build stopped: cannot make progress due to previous errors.
Build build-clang failed with exit code 1

Failed tests logs:

====== Bitcoin ABC functional tests: abc_mining_stakingrewards.py ======

------- Stdout: -------
2024-06-03T15:08:33.328000Z TestFramework (INFO): Initializing test directory /work/abc-ci-builds/build-without-wallet/test/tmp/test_runner_₿₵_  _20240603_150555/abc_mining_stakingrewards_102
2024-06-03T15:08:35.590000Z TestFramework (INFO): Staking rewards not ready yet, check getblocktemplate lacks the staking rewards data
2024-06-03T15:08:35.595000Z TestFramework (INFO): Staking rewards not ready yet, check the miner doesn't produce the staking rewards output
2024-06-03T15:08:35.683000Z TestFramework (INFO): Staking rewards are computed, check the block template returns the staking rewards data
2024-06-03T15:08:37.812000Z TestFramework (ERROR): Assertion failed
Traceback (most recent call last):
  File "/work/test/functional/test_framework/test_framework.py", line 147, in main
    self._run_test_internal()
  File "/work/test/functional/test_framework/test_framework.py", line 137, in _run_test_internal
    self.run_test()
  File "/work/test/functional/abc_mining_stakingrewards.py", line 144, in run_test
    assert "stakingrewards" in gbt["coinbasetxn"]
AssertionError
2024-06-03T15:08:37.863000Z TestFramework (INFO): Stopping nodes
2024-06-03T15:08:38.014000Z TestFramework (WARNING): Not cleaning up dir /work/abc-ci-builds/build-without-wallet/test/tmp/test_runner_₿₵_  _20240603_150555/abc_mining_stakingrewards_102
2024-06-03T15:08:38.014000Z TestFramework (ERROR): Test failed. Test logging available at /work/abc-ci-builds/build-without-wallet/test/tmp/test_runner_₿₵_  _20240603_150555/abc_mining_stakingrewards_102/test_framework.log
2024-06-03T15:08:38.014000Z TestFramework (ERROR): 
2024-06-03T15:08:38.014000Z TestFramework (ERROR): Hint: Call /work/test/functional/combine_logs.py '/work/abc-ci-builds/build-without-wallet/test/tmp/test_runner_₿₵_  _20240603_150555/abc_mining_stakingrewards_102' to consolidate all logs
2024-06-03T15:08:38.014000Z TestFramework (ERROR): 
2024-06-03T15:08:38.014000Z TestFramework (ERROR): If this failure happened unexpectedly or intermittently, please file a bug and provide a link or upload of the combined log.
2024-06-03T15:08:38.014000Z TestFramework (ERROR): https://github.com/Bitcoin-ABC/bitcoin-abc/issues
2024-06-03T15:08:38.014000Z TestFramework (ERROR):
====== Bitcoin ABC functional tests: abc_p2p_avalanche_policy_minerfund.py ======

------- Stdout: -------
2024-06-03T15:07:48.346000Z TestFramework (INFO): Initializing test directory /work/abc-ci-builds/build-without-wallet/test/tmp/test_runner_₿₵_  _20240603_150555/abc_p2p_avalanche_policy_minerfund_47
2024-06-03T15:07:50.896000Z TestFramework (INFO): Miner fund test case: address: ecregtest:prfhcnyqnl5cgrnmlfmms675w93ld7mvvq9jcw0zsn, fund amount: 2530570246
2024-06-03T15:07:51.188000Z TestFramework (INFO): Miner fund test case: address: ecregtest:pqv2r67sgz3qumufap3h2uuj0zfmnzuv8v38gtrh5v, fund amount: 2062365801
2024-06-03T15:08:51.255000Z TestFramework.utils (ERROR): wait_until() failed. Predicate: ''''
            self.wait_until(lambda: has_accepted_tip(block.hash))
'''
2024-06-03T15:08:51.255000Z TestFramework (ERROR): Assertion failed
Traceback (most recent call last):
  File "/work/test/functional/test_framework/test_framework.py", line 147, in main
    self._run_test_internal()
  File "/work/test/functional/test_framework/test_framework.py", line 137, in _run_test_internal
    self.run_test()
  File "/work/test/functional/abc_p2p_avalanche_policy_minerfund.py", line 195, in run_test
    self.run_for_ratio(MINER_FUND_RATIO)
  File "/work/test/functional/abc_p2p_avalanche_policy_minerfund.py", line 166, in run_for_ratio
    new_block(node.getbestblockhash(), addr, amount)
  File "/work/test/functional/abc_p2p_avalanche_policy_minerfund.py", line 135, in new_block
    self.wait_until(lambda: has_accepted_tip(block.hash))
  File "/work/test/functional/test_framework/test_framework.py", line 824, in wait_until
    return wait_until_helper(
  File "/work/test/functional/test_framework/util.py", line 297, in wait_until_helper
    raise AssertionError(
AssertionError: Predicate ''''
            self.wait_until(lambda: has_accepted_tip(block.hash))
''' not true after 60.0 seconds
2024-06-03T15:08:51.306000Z TestFramework (INFO): Stopping nodes
2024-06-03T15:08:51.457000Z TestFramework (WARNING): Not cleaning up dir /work/abc-ci-builds/build-without-wallet/test/tmp/test_runner_₿₵_  _20240603_150555/abc_p2p_avalanche_policy_minerfund_47
2024-06-03T15:08:51.457000Z TestFramework (ERROR): Test failed. Test logging available at /work/abc-ci-builds/build-without-wallet/test/tmp/test_runner_₿₵_  _20240603_150555/abc_p2p_avalanche_policy_minerfund_47/test_framework.log
2024-06-03T15:08:51.457000Z TestFramework (ERROR): 
2024-06-03T15:08:51.457000Z TestFramework (ERROR): Hint: Call /work/test/functional/combine_logs.py '/work/abc-ci-builds/build-without-wallet/test/tmp/test_runner_₿₵_  _20240603_150555/abc_p2p_avalanche_policy_minerfund_47' to consolidate all logs
2024-06-03T15:08:51.457000Z TestFramework (ERROR): 
2024-06-03T15:08:51.457000Z TestFramework (ERROR): If this failure happened unexpectedly or intermittently, please file a bug and provide a link or upload of the combined log.
2024-06-03T15:08:51.457000Z TestFramework (ERROR): https://github.com/Bitcoin-ABC/bitcoin-abc/issues
2024-06-03T15:08:51.457000Z TestFramework (ERROR):
====== Bitcoin ABC functional tests: abc_p2p_avalanche_policy_stakingrewards.py ======

------- Stdout: -------
2024-06-03T15:07:34.228000Z TestFramework (INFO): Initializing test directory /work/abc-ci-builds/build-without-wallet/test/tmp/test_runner_₿₵_  _20240603_150555/abc_p2p_avalanche_policy_stakingrewards_42
2024-06-03T15:07:39.413000Z TestFramework (ERROR): Assertion failed
Traceback (most recent call last):
  File "/work/test/functional/test_framework/test_framework.py", line 147, in main
    self._run_test_internal()
  File "/work/test/functional/test_framework/test_framework.py", line 137, in _run_test_internal
    self.run_test()
  File "/work/test/functional/abc_p2p_avalanche_policy_stakingrewards.py", line 170, in run_test
    new_block(
  File "/work/test/functional/abc_p2p_avalanche_policy_stakingrewards.py", line 149, in new_block
    assert_equal(node.getbestblockhash(), expected_tip)
  File "/work/test/functional/test_framework/util.py", line 61, in assert_equal
    raise AssertionError(
AssertionError: not(49ecdae7c50e01f0ddad08d0b9f42677e5b32db27827a840fc486f268bc08708 == 2b5d64bbbe665acc0b365aebf2d285334c249478ffd5eec9e74a0c27861c033f)
2024-06-03T15:07:39.468000Z TestFramework (INFO): Stopping nodes
2024-06-03T15:07:39.622000Z TestFramework (WARNING): Not cleaning up dir /work/abc-ci-builds/build-without-wallet/test/tmp/test_runner_₿₵_  _20240603_150555/abc_p2p_avalanche_policy_stakingrewards_42
2024-06-03T15:07:39.623000Z TestFramework (ERROR): Test failed. Test logging available at /work/abc-ci-builds/build-without-wallet/test/tmp/test_runner_₿₵_  _20240603_150555/abc_p2p_avalanche_policy_stakingrewards_42/test_framework.log
2024-06-03T15:07:39.623000Z TestFramework (ERROR): 
2024-06-03T15:07:39.624000Z TestFramework (ERROR): Hint: Call /work/test/functional/combine_logs.py '/work/abc-ci-builds/build-without-wallet/test/tmp/test_runner_₿₵_  _20240603_150555/abc_p2p_avalanche_policy_stakingrewards_42' to consolidate all logs
2024-06-03T15:07:39.624000Z TestFramework (ERROR): 
2024-06-03T15:07:39.624000Z TestFramework (ERROR): If this failure happened unexpectedly or intermittently, please file a bug and provide a link or upload of the combined log.
2024-06-03T15:07:39.624000Z TestFramework (ERROR): https://github.com/Bitcoin-ABC/bitcoin-abc/issues
2024-06-03T15:07:39.625000Z TestFramework (ERROR):
====== Bitcoin ABC functional tests: abc_p2p_avalanche_transaction_voting.py ======

------- Stdout: -------
2024-06-03T15:06:56.357000Z TestFramework (INFO): Initializing test directory /work/abc-ci-builds/build-without-wallet/test/tmp/test_runner_₿₵_  _20240603_150555/abc_p2p_avalanche_transaction_voting_28
2024-06-03T15:06:56.947000Z TestFramework (INFO): Check the votes are unknown while the quorum is not established
2024-06-03T15:06:57.001000Z TestFramework (INFO): Check the votes on valid mempool transactions
2024-06-03T15:06:59.010000Z TestFramework (INFO): Check the votes on recently mined transactions
2024-06-03T15:06:59.638000Z TestFramework (INFO): Check the votes on unknown transactions
2024-06-03T15:06:59.691000Z TestFramework (INFO): Check the votes on invalid transactions
2024-06-03T15:06:59.796000Z TestFramework (INFO): Check the votes on orphan transactions
2024-06-03T15:06:59.902000Z TestFramework (INFO): Check the node polls for transactions added to the mempool
2024-06-03T15:08:03.864000Z TestFramework.utils (ERROR): wait_until() failed. Predicate: ''''
        self.wait_until(lambda: has_finalized_block(tip))
'''
2024-06-03T15:08:03.864000Z TestFramework (ERROR): Assertion failed
Traceback (most recent call last):
  File "/work/test/functional/test_framework/test_framework.py", line 147, in main
    self._run_test_internal()
  File "/work/test/functional/test_framework/test_framework.py", line 137, in _run_test_internal
    self.run_test()
  File "/work/test/functional/abc_p2p_avalanche_transaction_voting.py", line 176, in run_test
    self.wait_until(lambda: has_finalized_block(tip))
  File "/work/test/functional/test_framework/test_framework.py", line 824, in wait_until
    return wait_until_helper(
  File "/work/test/functional/test_framework/util.py", line 297, in wait_until_helper
    raise AssertionError(
AssertionError: Predicate ''''
        self.wait_until(lambda: has_finalized_block(tip))
''' not true after 60.0 seconds
2024-06-03T15:08:03.915000Z TestFramework (INFO): Stopping nodes
2024-06-03T15:08:04.116000Z TestFramework (WARNING): Not cleaning up dir /work/abc-ci-builds/build-without-wallet/test/tmp/test_runner_₿₵_  _20240603_150555/abc_p2p_avalanche_transaction_voting_28
2024-06-03T15:08:04.116000Z TestFramework (ERROR): Test failed. Test logging available at /work/abc-ci-builds/build-without-wallet/test/tmp/test_runner_₿₵_  _20240603_150555/abc_p2p_avalanche_transaction_voting_28/test_framework.log
2024-06-03T15:08:04.116000Z TestFramework (ERROR): 
2024-06-03T15:08:04.116000Z TestFramework (ERROR): Hint: Call /work/test/functional/combine_logs.py '/work/abc-ci-builds/build-without-wallet/test/tmp/test_runner_₿₵_  _20240603_150555/abc_p2p_avalanche_transaction_voting_28' to consolidate all logs
2024-06-03T15:08:04.116000Z TestFramework (ERROR): 
2024-06-03T15:08:04.116000Z TestFramework (ERROR): If this failure happened unexpectedly or intermittently, please file a bug and provide a link or upload of the combined log.
2024-06-03T15:08:04.117000Z TestFramework (ERROR): https://github.com/Bitcoin-ABC/bitcoin-abc/issues
2024-06-03T15:08:04.117000Z TestFramework (ERROR):
====== Bitcoin ABC functional tests: abc_rpc_isfinal.py ======

------- Stdout: -------
2024-06-03T15:06:54.018000Z TestFramework (INFO): Initializing test directory /work/abc-ci-builds/build-without-wallet/test/tmp/test_runner_₿₵_  _20240603_150555/abc_rpc_isfinal_22
2024-06-03T15:07:57.668000Z TestFramework.utils (ERROR): wait_until() failed. Predicate: ''''
            self.wait_until(lambda: is_finalblock(blockhash))
'''
2024-06-03T15:07:57.668000Z TestFramework (ERROR): Assertion failed
Traceback (most recent call last):
  File "/work/test/functional/test_framework/test_framework.py", line 147, in main
    self._run_test_internal()
  File "/work/test/functional/test_framework/test_framework.py", line 137, in _run_test_internal
    self.run_test()
  File "/work/test/functional/abc_rpc_isfinal.py", line 77, in run_test
    self.wait_until(lambda: is_finalblock(blockhash))
  File "/work/test/functional/test_framework/test_framework.py", line 824, in wait_until
    return wait_until_helper(
  File "/work/test/functional/test_framework/util.py", line 297, in wait_until_helper
    raise AssertionError(
AssertionError: Predicate ''''
            self.wait_until(lambda: is_finalblock(blockhash))
''' not true after 60.0 seconds
2024-06-03T15:07:57.719000Z TestFramework (INFO): Stopping nodes
2024-06-03T15:07:57.870000Z TestFramework (WARNING): Not cleaning up dir /work/abc-ci-builds/build-without-wallet/test/tmp/test_runner_₿₵_  _20240603_150555/abc_rpc_isfinal_22
2024-06-03T15:07:57.870000Z TestFramework (ERROR): Test failed. Test logging available at /work/abc-ci-builds/build-without-wallet/test/tmp/test_runner_₿₵_  _20240603_150555/abc_rpc_isfinal_22/test_framework.log
2024-06-03T15:07:57.870000Z TestFramework (ERROR): 
2024-06-03T15:07:57.870000Z TestFramework (ERROR): Hint: Call /work/test/functional/combine_logs.py '/work/abc-ci-builds/build-without-wallet/test/tmp/test_runner_₿₵_  _20240603_150555/abc_rpc_isfinal_22' to consolidate all logs
2024-06-03T15:07:57.870000Z TestFramework (ERROR): 
2024-06-03T15:07:57.870000Z TestFramework (ERROR): If this failure happened unexpectedly or intermittently, please file a bug and provide a link or upload of the combined log.
2024-06-03T15:07:57.871000Z TestFramework (ERROR): https://github.com/Bitcoin-ABC/bitcoin-abc/issues
2024-06-03T15:07:57.871000Z TestFramework (ERROR):

Each failure log is accessible here:
Bitcoin ABC functional tests: abc_mining_stakingrewards.py
Bitcoin ABC functional tests: abc_p2p_avalanche_policy_minerfund.py
Bitcoin ABC functional tests: abc_p2p_avalanche_policy_stakingrewards.py
Bitcoin ABC functional tests: abc_p2p_avalanche_transaction_voting.py
Bitcoin ABC functional tests: abc_rpc_isfinal.py

Tail of the build log:

[453/498] bitcoin: testing validation_chainstate_tests
[454/498] bitcoin: testing compress_tests
[455/498] pow: testing eda_tests
[456/498] Running utility command for check-bitcoin-blockmanager_tests
[457/498] Running utility command for check-pow-eda_tests
[458/498] Running utility command for check-bitcoin-validation_chainstate_tests
[459/498] Running utility command for check-bitcoin-compress_tests
[460/498] Test Bitcoin RPC authentication...
...
----------------------------------------------------------------------
Ran 3 tests in 0.035s

OK
[461/498] cd /work/contrib/devtools/chainparams && /usr/bin/python3.9 ./test_make_chainparams.py
.....
----------------------------------------------------------------------
Ran 5 tests in 0.004s

OK
[462/498] pow: testing grasberg_tests
[463/498] Running utility command for check-pow-grasberg_tests
[464/498] Running pow test suite
PASSED: pow test suite
[465/498] bitcoin: testing wallet_crypto_tests
[466/498] Running utility command for check-bitcoin-wallet_crypto_tests
[467/498] bitcoin: testing radix_tests
[468/498] Running utility command for check-bitcoin-radix_tests
[469/498] Test Bitcoin utilities...
[470/498] bitcoin: testing wallet_tests
[471/498] Running utility command for check-bitcoin-wallet_tests
[472/498] bitcoin: testing coinselector_tests
[473/498] Running utility command for check-bitcoin-coinselector_tests
[474/498] Building CXX object src/seeder/test/CMakeFiles/test-seeder.dir/fixture.cpp.o
[475/498] Linking CXX executable src/seeder/test/test-seeder
[476/498] seeder: testing p2p_messaging_tests
[477/498] seeder: testing message_writer_tests
[478/498] seeder: testing options_tests
[479/498] seeder: testing parse_name_tests
[480/498] Running utility command for check-seeder-p2p_messaging_tests
[481/498] Running utility command for check-seeder-message_writer_tests
[482/498] Running utility command for check-seeder-options_tests
[483/498] seeder: testing write_name_tests
[484/498] Running utility command for check-seeder-parse_name_tests
[485/498] Running utility command for check-seeder-write_name_tests
[486/498] Running seeder test suite
PASSED: seeder test suite
[487/498] bitcoin: testing coins_tests
[488/498] Running utility command for check-bitcoin-coins_tests
[489/498] Running bitcoin test suite
PASSED: bitcoin test suite
[490/498] Building CXX object src/qt/test/CMakeFiles/test_bitcoin-qt.dir/__/__/wallet/test/wallet_test_fixture.cpp.o
[491/498] Building CXX object src/qt/test/CMakeFiles/test_bitcoin-qt.dir/paymentservertests.cpp.o
[492/498] Building CXX object src/qt/test/CMakeFiles/test_bitcoin-qt.dir/addressbooktests.cpp.o
[493/498] Building CXX object src/qt/test/CMakeFiles/test_bitcoin-qt.dir/wallettests.cpp.o
[494/498] Linking CXX executable src/qt/test/test_bitcoin-qt
[495/498] bitcoin-qt: testing test_bitcoin-qt
[496/498] Running bitcoin-qt test suite
PASSED: bitcoin-qt test suite
ninja: build stopped: cannot make progress due to previous errors.
Build build-clang-tidy failed with exit code 1

Failed tests logs:

====== Bitcoin ABC functional tests: abc_mining_stakingrewards.py ======

------- Stdout: -------
2024-06-03T15:13:47.610000Z TestFramework (INFO): Initializing test directory /work/abc-ci-builds/build-debug/test/tmp/test_runner_₿₵_  _20240603_150720/abc_mining_stakingrewards_102
2024-06-03T15:13:50.302000Z TestFramework (INFO): Staking rewards not ready yet, check getblocktemplate lacks the staking rewards data
2024-06-03T15:13:50.303000Z TestFramework (INFO): Staking rewards not ready yet, check the miner doesn't produce the staking rewards output
2024-06-03T15:13:50.361000Z TestFramework (INFO): Staking rewards are computed, check the block template returns the staking rewards data
2024-06-03T15:13:52.512000Z TestFramework (ERROR): Assertion failed
Traceback (most recent call last):
  File "/work/test/functional/test_framework/test_framework.py", line 147, in main
    self._run_test_internal()
  File "/work/test/functional/test_framework/test_framework.py", line 137, in _run_test_internal
    self.run_test()
  File "/work/test/functional/abc_mining_stakingrewards.py", line 144, in run_test
    assert "stakingrewards" in gbt["coinbasetxn"]
AssertionError
2024-06-03T15:13:52.563000Z TestFramework (INFO): Stopping nodes
2024-06-03T15:13:52.714000Z TestFramework (WARNING): Not cleaning up dir /work/abc-ci-builds/build-debug/test/tmp/test_runner_₿₵_  _20240603_150720/abc_mining_stakingrewards_102
2024-06-03T15:13:52.714000Z TestFramework (ERROR): Test failed. Test logging available at /work/abc-ci-builds/build-debug/test/tmp/test_runner_₿₵_  _20240603_150720/abc_mining_stakingrewards_102/test_framework.log
2024-06-03T15:13:52.714000Z TestFramework (ERROR): 
2024-06-03T15:13:52.714000Z TestFramework (ERROR): Hint: Call /work/test/functional/combine_logs.py '/work/abc-ci-builds/build-debug/test/tmp/test_runner_₿₵_  _20240603_150720/abc_mining_stakingrewards_102' to consolidate all logs
2024-06-03T15:13:52.715000Z TestFramework (ERROR): 
2024-06-03T15:13:52.715000Z TestFramework (ERROR): If this failure happened unexpectedly or intermittently, please file a bug and provide a link or upload of the combined log.
2024-06-03T15:13:52.715000Z TestFramework (ERROR): https://github.com/Bitcoin-ABC/bitcoin-abc/issues
2024-06-03T15:13:52.715000Z TestFramework (ERROR):
====== Bitcoin ABC functional tests: abc_p2p_avalanche_policy_minerfund.py ======

------- Stdout: -------
2024-06-03T15:11:27.622000Z TestFramework (INFO): Initializing test directory /work/abc-ci-builds/build-debug/test/tmp/test_runner_₿₵_  _20240603_150720/abc_p2p_avalanche_policy_minerfund_47
2024-06-03T15:11:30.631000Z TestFramework (INFO): Miner fund test case: address: ecregtest:prfhcnyqnl5cgrnmlfmms675w93ld7mvvq9jcw0zsn, fund amount: 1600000000
2024-06-03T15:11:30.872000Z TestFramework (INFO): Miner fund test case: address: ecregtest:pqv2r67sgz3qumufap3h2uuj0zfmnzuv8v38gtrh5v, fund amount: 2390126935
2024-06-03T15:12:30.971000Z TestFramework.utils (ERROR): wait_until() failed. Predicate: ''''
            self.wait_until(lambda: has_accepted_tip(block.hash))
'''
2024-06-03T15:12:30.971000Z TestFramework (ERROR): Assertion failed
Traceback (most recent call last):
  File "/work/test/functional/test_framework/test_framework.py", line 147, in main
    self._run_test_internal()
  File "/work/test/functional/test_framework/test_framework.py", line 137, in _run_test_internal
    self.run_test()
  File "/work/test/functional/abc_p2p_avalanche_policy_minerfund.py", line 195, in run_test
    self.run_for_ratio(MINER_FUND_RATIO)
  File "/work/test/functional/abc_p2p_avalanche_policy_minerfund.py", line 166, in run_for_ratio
    new_block(node.getbestblockhash(), addr, amount)
  File "/work/test/functional/abc_p2p_avalanche_policy_minerfund.py", line 135, in new_block
    self.wait_until(lambda: has_accepted_tip(block.hash))
  File "/work/test/functional/test_framework/test_framework.py", line 824, in wait_until
    return wait_until_helper(
  File "/work/test/functional/test_framework/util.py", line 297, in wait_until_helper
    raise AssertionError(
AssertionError: Predicate ''''
            self.wait_until(lambda: has_accepted_tip(block.hash))
''' not true after 60.0 seconds
2024-06-03T15:12:31.022000Z TestFramework (INFO): Stopping nodes
2024-06-03T15:12:31.173000Z TestFramework (WARNING): Not cleaning up dir /work/abc-ci-builds/build-debug/test/tmp/test_runner_₿₵_  _20240603_150720/abc_p2p_avalanche_policy_minerfund_47
2024-06-03T15:12:31.173000Z TestFramework (ERROR): Test failed. Test logging available at /work/abc-ci-builds/build-debug/test/tmp/test_runner_₿₵_  _20240603_150720/abc_p2p_avalanche_policy_minerfund_47/test_framework.log
2024-06-03T15:12:31.173000Z TestFramework (ERROR): 
2024-06-03T15:12:31.173000Z TestFramework (ERROR): Hint: Call /work/test/functional/combine_logs.py '/work/abc-ci-builds/build-debug/test/tmp/test_runner_₿₵_  _20240603_150720/abc_p2p_avalanche_policy_minerfund_47' to consolidate all logs
2024-06-03T15:12:31.174000Z TestFramework (ERROR): 
2024-06-03T15:12:31.174000Z TestFramework (ERROR): If this failure happened unexpectedly or intermittently, please file a bug and provide a link or upload of the combined log.
2024-06-03T15:12:31.174000Z TestFramework (ERROR): https://github.com/Bitcoin-ABC/bitcoin-abc/issues
2024-06-03T15:12:31.174000Z TestFramework (ERROR):
====== Bitcoin ABC functional tests: abc_p2p_avalanche_policy_stakingrewards.py ======

------- Stdout: -------
2024-06-03T15:11:11.129000Z TestFramework (INFO): Initializing test directory /work/abc-ci-builds/build-debug/test/tmp/test_runner_₿₵_  _20240603_150720/abc_p2p_avalanche_policy_stakingrewards_42
2024-06-03T15:11:16.522000Z TestFramework (ERROR): Assertion failed
Traceback (most recent call last):
  File "/work/test/functional/test_framework/test_framework.py", line 147, in main
    self._run_test_internal()
  File "/work/test/functional/test_framework/test_framework.py", line 137, in _run_test_internal
    self.run_test()
  File "/work/test/functional/abc_p2p_avalanche_policy_stakingrewards.py", line 170, in run_test
    new_block(
  File "/work/test/functional/abc_p2p_avalanche_policy_stakingrewards.py", line 149, in new_block
    assert_equal(node.getbestblockhash(), expected_tip)
  File "/work/test/functional/test_framework/util.py", line 61, in assert_equal
    raise AssertionError(
AssertionError: not(5e38efbfe9bf6f96220ddc1ff8067739e93bded6ba5af518f4de86e324686b8c == 741d47144db5e5d92528ba3d1443a4cbb26d595c370e2122518b998acc2145c4)
2024-06-03T15:11:16.573000Z TestFramework (INFO): Stopping nodes
2024-06-03T15:11:16.774000Z TestFramework (WARNING): Not cleaning up dir /work/abc-ci-builds/build-debug/test/tmp/test_runner_₿₵_  _20240603_150720/abc_p2p_avalanche_policy_stakingrewards_42
2024-06-03T15:11:16.775000Z TestFramework (ERROR): Test failed. Test logging available at /work/abc-ci-builds/build-debug/test/tmp/test_runner_₿₵_  _20240603_150720/abc_p2p_avalanche_policy_stakingrewards_42/test_framework.log
2024-06-03T15:11:16.775000Z TestFramework (ERROR): 
2024-06-03T15:11:16.775000Z TestFramework (ERROR): Hint: Call /work/test/functional/combine_logs.py '/work/abc-ci-builds/build-debug/test/tmp/test_runner_₿₵_  _20240603_150720/abc_p2p_avalanche_policy_stakingrewards_42' to consolidate all logs
2024-06-03T15:11:16.775000Z TestFramework (ERROR): 
2024-06-03T15:11:16.775000Z TestFramework (ERROR): If this failure happened unexpectedly or intermittently, please file a bug and provide a link or upload of the combined log.
2024-06-03T15:11:16.775000Z TestFramework (ERROR): https://github.com/Bitcoin-ABC/bitcoin-abc/issues
2024-06-03T15:11:16.775000Z TestFramework (ERROR):
====== Bitcoin ABC functional tests: abc_p2p_avalanche_transaction_voting.py ======

------- Stdout: -------
2024-06-03T15:10:07.669000Z TestFramework (INFO): Initializing test directory /work/abc-ci-builds/build-debug/test/tmp/test_runner_₿₵_  _20240603_150720/abc_p2p_avalanche_transaction_voting_28
2024-06-03T15:10:08.901000Z TestFramework (INFO): Check the votes are unknown while the quorum is not established
2024-06-03T15:10:08.954000Z TestFramework (INFO): Check the votes on valid mempool transactions
2024-06-03T15:10:11.119000Z TestFramework (INFO): Check the votes on recently mined transactions
2024-06-03T15:10:11.789000Z TestFramework (INFO): Check the votes on unknown transactions
2024-06-03T15:10:11.842000Z TestFramework (INFO): Check the votes on invalid transactions
2024-06-03T15:10:11.947000Z TestFramework (INFO): Check the votes on orphan transactions
2024-06-03T15:10:12.051000Z TestFramework (INFO): Check the node polls for transactions added to the mempool
2024-06-03T15:11:16.251000Z TestFramework.utils (ERROR): wait_until() failed. Predicate: ''''
        self.wait_until(lambda: has_finalized_block(tip))
'''
2024-06-03T15:11:16.251000Z TestFramework (ERROR): Assertion failed
Traceback (most recent call last):
  File "/work/test/functional/test_framework/test_framework.py", line 147, in main
    self._run_test_internal()
  File "/work/test/functional/test_framework/test_framework.py", line 137, in _run_test_internal
    self.run_test()
  File "/work/test/functional/abc_p2p_avalanche_transaction_voting.py", line 176, in run_test
    self.wait_until(lambda: has_finalized_block(tip))
  File "/work/test/functional/test_framework/test_framework.py", line 824, in wait_until
    return wait_until_helper(
  File "/work/test/functional/test_framework/util.py", line 297, in wait_until_helper
    raise AssertionError(
AssertionError: Predicate ''''
        self.wait_until(lambda: has_finalized_block(tip))
''' not true after 60.0 seconds
2024-06-03T15:11:16.302000Z TestFramework (INFO): Stopping nodes
2024-06-03T15:11:16.453000Z TestFramework (WARNING): Not cleaning up dir /work/abc-ci-builds/build-debug/test/tmp/test_runner_₿₵_  _20240603_150720/abc_p2p_avalanche_transaction_voting_28
2024-06-03T15:11:16.453000Z TestFramework (ERROR): Test failed. Test logging available at /work/abc-ci-builds/build-debug/test/tmp/test_runner_₿₵_  _20240603_150720/abc_p2p_avalanche_transaction_voting_28/test_framework.log
2024-06-03T15:11:16.453000Z TestFramework (ERROR): 
2024-06-03T15:11:16.453000Z TestFramework (ERROR): Hint: Call /work/test/functional/combine_logs.py '/work/abc-ci-builds/build-debug/test/tmp/test_runner_₿₵_  _20240603_150720/abc_p2p_avalanche_transaction_voting_28' to consolidate all logs
2024-06-03T15:11:16.453000Z TestFramework (ERROR): 
2024-06-03T15:11:16.454000Z TestFramework (ERROR): If this failure happened unexpectedly or intermittently, please file a bug and provide a link or upload of the combined log.
2024-06-03T15:11:16.454000Z TestFramework (ERROR): https://github.com/Bitcoin-ABC/bitcoin-abc/issues
2024-06-03T15:11:16.454000Z TestFramework (ERROR):
====== Bitcoin ABC functional tests: abc_rpc_isfinal.py ======

------- Stdout: -------
2024-06-03T15:09:36.540000Z TestFramework (INFO): Initializing test directory /work/abc-ci-builds/build-debug/test/tmp/test_runner_₿₵_  _20240603_150720/abc_rpc_isfinal_22
2024-06-03T15:10:40.062000Z TestFramework.utils (ERROR): wait_until() failed. Predicate: ''''
            self.wait_until(lambda: is_finalblock(blockhash))
'''
2024-06-03T15:10:40.062000Z TestFramework (ERROR): Assertion failed
Traceback (most recent call last):
  File "/work/test/functional/test_framework/test_framework.py", line 147, in main
    self._run_test_internal()
  File "/work/test/functional/test_framework/test_framework.py", line 137, in _run_test_internal
    self.run_test()
  File "/work/test/functional/abc_rpc_isfinal.py", line 77, in run_test
    self.wait_until(lambda: is_finalblock(blockhash))
  File "/work/test/functional/test_framework/test_framework.py", line 824, in wait_until
    return wait_until_helper(
  File "/work/test/functional/test_framework/util.py", line 297, in wait_until_helper
    raise AssertionError(
AssertionError: Predicate ''''
            self.wait_until(lambda: is_finalblock(blockhash))
''' not true after 60.0 seconds
2024-06-03T15:10:40.113000Z TestFramework (INFO): Stopping nodes
2024-06-03T15:10:40.264000Z TestFramework (WARNING): Not cleaning up dir /work/abc-ci-builds/build-debug/test/tmp/test_runner_₿₵_  _20240603_150720/abc_rpc_isfinal_22
2024-06-03T15:10:40.264000Z TestFramework (ERROR): Test failed. Test logging available at /work/abc-ci-builds/build-debug/test/tmp/test_runner_₿₵_  _20240603_150720/abc_rpc_isfinal_22/test_framework.log
2024-06-03T15:10:40.264000Z TestFramework (ERROR): 
2024-06-03T15:10:40.264000Z TestFramework (ERROR): Hint: Call /work/test/functional/combine_logs.py '/work/abc-ci-builds/build-debug/test/tmp/test_runner_₿₵_  _20240603_150720/abc_rpc_isfinal_22' to consolidate all logs
2024-06-03T15:10:40.264000Z TestFramework (ERROR): 
2024-06-03T15:10:40.264000Z TestFramework (ERROR): If this failure happened unexpectedly or intermittently, please file a bug and provide a link or upload of the combined log.
2024-06-03T15:10:40.264000Z TestFramework (ERROR): https://github.com/Bitcoin-ABC/bitcoin-abc/issues
2024-06-03T15:10:40.265000Z TestFramework (ERROR):

Each failure log is accessible here:
Bitcoin ABC functional tests: abc_mining_stakingrewards.py
Bitcoin ABC functional tests: abc_p2p_avalanche_policy_minerfund.py
Bitcoin ABC functional tests: abc_p2p_avalanche_policy_stakingrewards.py
Bitcoin ABC functional tests: abc_p2p_avalanche_transaction_voting.py
Bitcoin ABC functional tests: abc_rpc_isfinal.py

Failed tests logs:

====== Bitcoin ABC functional tests: abc_mining_stakingrewards.py ======

------- Stdout: -------
2024-06-03T15:13:28.287000Z TestFramework (INFO): Initializing test directory /work/abc-ci-builds/build-diff/test/tmp/test_runner_₿₵_  _20240603_150933/abc_mining_stakingrewards_102
2024-06-03T15:13:30.532000Z TestFramework (INFO): Staking rewards not ready yet, check getblocktemplate lacks the staking rewards data
2024-06-03T15:13:30.533000Z TestFramework (INFO): Staking rewards not ready yet, check the miner doesn't produce the staking rewards output
2024-06-03T15:13:30.550000Z TestFramework (INFO): Staking rewards are computed, check the block template returns the staking rewards data
2024-06-03T15:13:32.683000Z TestFramework (ERROR): Assertion failed
Traceback (most recent call last):
  File "/work/test/functional/test_framework/test_framework.py", line 147, in main
    self._run_test_internal()
  File "/work/test/functional/test_framework/test_framework.py", line 137, in _run_test_internal
    self.run_test()
  File "/work/test/functional/abc_mining_stakingrewards.py", line 144, in run_test
    assert "stakingrewards" in gbt["coinbasetxn"]
AssertionError
2024-06-03T15:13:32.733000Z TestFramework (INFO): Stopping nodes
2024-06-03T15:13:32.835000Z TestFramework (WARNING): Not cleaning up dir /work/abc-ci-builds/build-diff/test/tmp/test_runner_₿₵_  _20240603_150933/abc_mining_stakingrewards_102
2024-06-03T15:13:32.835000Z TestFramework (ERROR): Test failed. Test logging available at /work/abc-ci-builds/build-diff/test/tmp/test_runner_₿₵_  _20240603_150933/abc_mining_stakingrewards_102/test_framework.log
2024-06-03T15:13:32.835000Z TestFramework (ERROR): 
2024-06-03T15:13:32.835000Z TestFramework (ERROR): Hint: Call /work/test/functional/combine_logs.py '/work/abc-ci-builds/build-diff/test/tmp/test_runner_₿₵_  _20240603_150933/abc_mining_stakingrewards_102' to consolidate all logs
2024-06-03T15:13:32.835000Z TestFramework (ERROR): 
2024-06-03T15:13:32.835000Z TestFramework (ERROR): If this failure happened unexpectedly or intermittently, please file a bug and provide a link or upload of the combined log.
2024-06-03T15:13:32.835000Z TestFramework (ERROR): https://github.com/Bitcoin-ABC/bitcoin-abc/issues
2024-06-03T15:13:32.835000Z TestFramework (ERROR):
====== Bitcoin ABC functional tests: abc_p2p_avalanche_policy_minerfund.py ======

------- Stdout: -------
2024-06-03T15:12:16.022000Z TestFramework (INFO): Initializing test directory /work/abc-ci-builds/build-diff/test/tmp/test_runner_₿₵_  _20240603_150933/abc_p2p_avalanche_policy_minerfund_47
2024-06-03T15:12:18.452000Z TestFramework (INFO): Miner fund test case: address: ecregtest:prfhcnyqnl5cgrnmlfmms675w93ld7mvvq9jcw0zsn, fund amount: 2273785840
2024-06-03T15:12:18.755000Z TestFramework (INFO): Miner fund test case: address: ecregtest:pqv2r67sgz3qumufap3h2uuj0zfmnzuv8v38gtrh5v, fund amount: 1904076757
2024-06-03T15:13:18.846000Z TestFramework.utils (ERROR): wait_until() failed. Predicate: ''''
            self.wait_until(lambda: has_accepted_tip(block.hash))
'''
2024-06-03T15:13:18.846000Z TestFramework (ERROR): Assertion failed
Traceback (most recent call last):
  File "/work/test/functional/test_framework/test_framework.py", line 147, in main
    self._run_test_internal()
  File "/work/test/functional/test_framework/test_framework.py", line 137, in _run_test_internal
    self.run_test()
  File "/work/test/functional/abc_p2p_avalanche_policy_minerfund.py", line 195, in run_test
    self.run_for_ratio(MINER_FUND_RATIO)
  File "/work/test/functional/abc_p2p_avalanche_policy_minerfund.py", line 166, in run_for_ratio
    new_block(node.getbestblockhash(), addr, amount)
  File "/work/test/functional/abc_p2p_avalanche_policy_minerfund.py", line 135, in new_block
    self.wait_until(lambda: has_accepted_tip(block.hash))
  File "/work/test/functional/test_framework/test_framework.py", line 824, in wait_until
    return wait_until_helper(
  File "/work/test/functional/test_framework/util.py", line 297, in wait_until_helper
    raise AssertionError(
AssertionError: Predicate ''''
            self.wait_until(lambda: has_accepted_tip(block.hash))
''' not true after 60.0 seconds
2024-06-03T15:13:18.897000Z TestFramework (INFO): Stopping nodes
2024-06-03T15:13:18.998000Z TestFramework (WARNING): Not cleaning up dir /work/abc-ci-builds/build-diff/test/tmp/test_runner_₿₵_  _20240603_150933/abc_p2p_avalanche_policy_minerfund_47
2024-06-03T15:13:18.998000Z TestFramework (ERROR): Test failed. Test logging available at /work/abc-ci-builds/build-diff/test/tmp/test_runner_₿₵_  _20240603_150933/abc_p2p_avalanche_policy_minerfund_47/test_framework.log
2024-06-03T15:13:18.998000Z TestFramework (ERROR): 
2024-06-03T15:13:18.998000Z TestFramework (ERROR): Hint: Call /work/test/functional/combine_logs.py '/work/abc-ci-builds/build-diff/test/tmp/test_runner_₿₵_  _20240603_150933/abc_p2p_avalanche_policy_minerfund_47' to consolidate all logs
2024-06-03T15:13:18.999000Z TestFramework (ERROR): 
2024-06-03T15:13:18.999000Z TestFramework (ERROR): If this failure happened unexpectedly or intermittently, please file a bug and provide a link or upload of the combined log.
2024-06-03T15:13:18.999000Z TestFramework (ERROR): https://github.com/Bitcoin-ABC/bitcoin-abc/issues
2024-06-03T15:13:18.999000Z TestFramework (ERROR):
====== Bitcoin ABC functional tests: abc_p2p_avalanche_policy_stakingrewards.py ======

------- Stdout: -------
2024-06-03T15:12:04.768000Z TestFramework (INFO): Initializing test directory /work/abc-ci-builds/build-diff/test/tmp/test_runner_₿₵_  _20240603_150933/abc_p2p_avalanche_policy_stakingrewards_42
2024-06-03T15:12:09.112000Z TestFramework (ERROR): Assertion failed
Traceback (most recent call last):
  File "/work/test/functional/test_framework/test_framework.py", line 147, in main
    self._run_test_internal()
  File "/work/test/functional/test_framework/test_framework.py", line 137, in _run_test_internal
    self.run_test()
  File "/work/test/functional/abc_p2p_avalanche_policy_stakingrewards.py", line 170, in run_test
    new_block(
  File "/work/test/functional/abc_p2p_avalanche_policy_stakingrewards.py", line 149, in new_block
    assert_equal(node.getbestblockhash(), expected_tip)
  File "/work/test/functional/test_framework/util.py", line 61, in assert_equal
    raise AssertionError(
AssertionError: not(22e8fa87d215907858587f90682030ece9f9b0c73dd16ba36e6a3add805be38f == 2148d7ff5e686bcc4f6769613d172392caa01ddfb1891584f8f4bbb84ce0679b)
2024-06-03T15:12:09.163000Z TestFramework (INFO): Stopping nodes
2024-06-03T15:12:09.264000Z TestFramework (WARNING): Not cleaning up dir /work/abc-ci-builds/build-diff/test/tmp/test_runner_₿₵_  _20240603_150933/abc_p2p_avalanche_policy_stakingrewards_42
2024-06-03T15:12:09.264000Z TestFramework (ERROR): Test failed. Test logging available at /work/abc-ci-builds/build-diff/test/tmp/test_runner_₿₵_  _20240603_150933/abc_p2p_avalanche_policy_stakingrewards_42/test_framework.log
2024-06-03T15:12:09.264000Z TestFramework (ERROR): 
2024-06-03T15:12:09.264000Z TestFramework (ERROR): Hint: Call /work/test/functional/combine_logs.py '/work/abc-ci-builds/build-diff/test/tmp/test_runner_₿₵_  _20240603_150933/abc_p2p_avalanche_policy_stakingrewards_42' to consolidate all logs
2024-06-03T15:12:09.264000Z TestFramework (ERROR): 
2024-06-03T15:12:09.264000Z TestFramework (ERROR): If this failure happened unexpectedly or intermittently, please file a bug and provide a link or upload of the combined log.
2024-06-03T15:12:09.264000Z TestFramework (ERROR): https://github.com/Bitcoin-ABC/bitcoin-abc/issues
2024-06-03T15:12:09.264000Z TestFramework (ERROR):
====== Bitcoin ABC functional tests: abc_p2p_avalanche_transaction_voting.py ======

------- Stdout: -------
2024-06-03T15:11:15.046000Z TestFramework (INFO): Initializing test directory /work/abc-ci-builds/build-diff/test/tmp/test_runner_₿₵_  _20240603_150933/abc_p2p_avalanche_transaction_voting_28
2024-06-03T15:11:15.633000Z TestFramework (INFO): Check the votes are unknown while the quorum is not established
2024-06-03T15:11:15.688000Z TestFramework (INFO): Check the votes on valid mempool transactions
2024-06-03T15:11:17.678000Z TestFramework (INFO): Check the votes on recently mined transactions
2024-06-03T15:11:18.311000Z TestFramework (INFO): Check the votes on unknown transactions
2024-06-03T15:11:18.365000Z TestFramework (INFO): Check the votes on invalid transactions
2024-06-03T15:11:18.469000Z TestFramework (INFO): Check the votes on orphan transactions
2024-06-03T15:11:18.574000Z TestFramework (INFO): Check the node polls for transactions added to the mempool
2024-06-03T15:12:22.774000Z TestFramework.utils (ERROR): wait_until() failed. Predicate: ''''
        self.wait_until(lambda: has_finalized_block(tip))
'''
2024-06-03T15:12:22.775000Z TestFramework (ERROR): Assertion failed
Traceback (most recent call last):
  File "/work/test/functional/test_framework/test_framework.py", line 147, in main
    self._run_test_internal()
  File "/work/test/functional/test_framework/test_framework.py", line 137, in _run_test_internal
    self.run_test()
  File "/work/test/functional/abc_p2p_avalanche_transaction_voting.py", line 176, in run_test
    self.wait_until(lambda: has_finalized_block(tip))
  File "/work/test/functional/test_framework/test_framework.py", line 824, in wait_until
    return wait_until_helper(
  File "/work/test/functional/test_framework/util.py", line 297, in wait_until_helper
    raise AssertionError(
AssertionError: Predicate ''''
        self.wait_until(lambda: has_finalized_block(tip))
''' not true after 60.0 seconds
2024-06-03T15:12:22.827000Z TestFramework (INFO): Stopping nodes
2024-06-03T15:12:22.883000Z TestFramework (WARNING): Not cleaning up dir /work/abc-ci-builds/build-diff/test/tmp/test_runner_₿₵_  _20240603_150933/abc_p2p_avalanche_transaction_voting_28
2024-06-03T15:12:22.883000Z TestFramework (ERROR): Test failed. Test logging available at /work/abc-ci-builds/build-diff/test/tmp/test_runner_₿₵_  _20240603_150933/abc_p2p_avalanche_transaction_voting_28/test_framework.log
2024-06-03T15:12:22.884000Z TestFramework (ERROR): 
2024-06-03T15:12:22.884000Z TestFramework (ERROR): Hint: Call /work/test/functional/combine_logs.py '/work/abc-ci-builds/build-diff/test/tmp/test_runner_₿₵_  _20240603_150933/abc_p2p_avalanche_transaction_voting_28' to consolidate all logs
2024-06-03T15:12:22.884000Z TestFramework (ERROR): 
2024-06-03T15:12:22.884000Z TestFramework (ERROR): If this failure happened unexpectedly or intermittently, please file a bug and provide a link or upload of the combined log.
2024-06-03T15:12:22.884000Z TestFramework (ERROR): https://github.com/Bitcoin-ABC/bitcoin-abc/issues
2024-06-03T15:12:22.885000Z TestFramework (ERROR):
====== Bitcoin ABC functional tests: abc_rpc_isfinal.py ======

------- Stdout: -------
2024-06-03T15:10:57.026000Z TestFramework (INFO): Initializing test directory /work/abc-ci-builds/build-diff/test/tmp/test_runner_₿₵_  _20240603_150933/abc_rpc_isfinal_22
2024-06-03T15:12:00.262000Z TestFramework.utils (ERROR): wait_until() failed. Predicate: ''''
            self.wait_until(lambda: is_finalblock(blockhash))
'''
2024-06-03T15:12:00.263000Z TestFramework (ERROR): Assertion failed
Traceback (most recent call last):
  File "/work/test/functional/test_framework/test_framework.py", line 147, in main
    self._run_test_internal()
  File "/work/test/functional/test_framework/test_framework.py", line 137, in _run_test_internal
    self.run_test()
  File "/work/test/functional/abc_rpc_isfinal.py", line 77, in run_test
    self.wait_until(lambda: is_finalblock(blockhash))
  File "/work/test/functional/test_framework/test_framework.py", line 824, in wait_until
    return wait_until_helper(
  File "/work/test/functional/test_framework/util.py", line 297, in wait_until_helper
    raise AssertionError(
AssertionError: Predicate ''''
            self.wait_until(lambda: is_finalblock(blockhash))
''' not true after 60.0 seconds
2024-06-03T15:12:00.316000Z TestFramework (INFO): Stopping nodes
2024-06-03T15:12:00.420000Z TestFramework (WARNING): Not cleaning up dir /work/abc-ci-builds/build-diff/test/tmp/test_runner_₿₵_  _20240603_150933/abc_rpc_isfinal_22
2024-06-03T15:12:00.420000Z TestFramework (ERROR): Test failed. Test logging available at /work/abc-ci-builds/build-diff/test/tmp/test_runner_₿₵_  _20240603_150933/abc_rpc_isfinal_22/test_framework.log
2024-06-03T15:12:00.420000Z TestFramework (ERROR): 
2024-06-03T15:12:00.421000Z TestFramework (ERROR): Hint: Call /work/test/functional/combine_logs.py '/work/abc-ci-builds/build-diff/test/tmp/test_runner_₿₵_  _20240603_150933/abc_rpc_isfinal_22' to consolidate all logs
2024-06-03T15:12:00.421000Z TestFramework (ERROR): 
2024-06-03T15:12:00.421000Z TestFramework (ERROR): If this failure happened unexpectedly or intermittently, please file a bug and provide a link or upload of the combined log.
2024-06-03T15:12:00.422000Z TestFramework (ERROR): https://github.com/Bitcoin-ABC/bitcoin-abc/issues
2024-06-03T15:12:00.422000Z TestFramework (ERROR):
====== Bitcoin ABC functional tests with the next upgrade activated: abc_mining_stakingrewards.py ======

------- Stdout: -------
2024-06-03T15:17:54.624000Z TestFramework (INFO): Initializing test directory /work/abc-ci-builds/build-diff/test/tmp/test_runner_₿₵_  _20240603_151416/abc_mining_stakingrewards_102
2024-06-03T15:17:56.916000Z TestFramework (INFO): Staking rewards not ready yet, check getblocktemplate lacks the staking rewards data
2024-06-03T15:17:56.918000Z TestFramework (INFO): Staking rewards not ready yet, check the miner doesn't produce the staking rewards output
2024-06-03T15:17:56.944000Z TestFramework (INFO): Staking rewards are computed, check the block template returns the staking rewards data
2024-06-03T15:17:59.015000Z TestFramework (ERROR): Assertion failed
Traceback (most recent call last):
  File "/work/test/functional/test_framework/test_framework.py", line 147, in main
    self._run_test_internal()
  File "/work/test/functional/test_framework/test_framework.py", line 137, in _run_test_internal
    self.run_test()
  File "/work/test/functional/abc_mining_stakingrewards.py", line 144, in run_test
    assert "stakingrewards" in gbt["coinbasetxn"]
AssertionError
2024-06-03T15:17:59.066000Z TestFramework (INFO): Stopping nodes
2024-06-03T15:17:59.167000Z TestFramework (WARNING): Not cleaning up dir /work/abc-ci-builds/build-diff/test/tmp/test_runner_₿₵_  _20240603_151416/abc_mining_stakingrewards_102
2024-06-03T15:17:59.167000Z TestFramework (ERROR): Test failed. Test logging available at /work/abc-ci-builds/build-diff/test/tmp/test_runner_₿₵_  _20240603_151416/abc_mining_stakingrewards_102/test_framework.log
2024-06-03T15:17:59.167000Z TestFramework (ERROR): 
2024-06-03T15:17:59.167000Z TestFramework (ERROR): Hint: Call /work/test/functional/combine_logs.py '/work/abc-ci-builds/build-diff/test/tmp/test_runner_₿₵_  _20240603_151416/abc_mining_stakingrewards_102' to consolidate all logs
2024-06-03T15:17:59.167000Z TestFramework (ERROR): 
2024-06-03T15:17:59.167000Z TestFramework (ERROR): If this failure happened unexpectedly or intermittently, please file a bug and provide a link or upload of the combined log.
2024-06-03T15:17:59.167000Z TestFramework (ERROR): https://github.com/Bitcoin-ABC/bitcoin-abc/issues
2024-06-03T15:17:59.167000Z TestFramework (ERROR):
====== Bitcoin ABC functional tests with the next upgrade activated: abc_p2p_avalanche_policy_minerfund.py ======

------- Stdout: -------
2024-06-03T15:16:38.265000Z TestFramework (INFO): Initializing test directory /work/abc-ci-builds/build-diff/test/tmp/test_runner_₿₵_  _20240603_151416/abc_p2p_avalanche_policy_minerfund_47
2024-06-03T15:16:40.808000Z TestFramework (INFO): Miner fund test case: address: ecregtest:pqv2r67sgz3qumufap3h2uuj0zfmnzuv8v38gtrh5v, fund amount: 1615155760
2024-06-03T15:17:40.882000Z TestFramework.utils (ERROR): wait_until() failed. Predicate: ''''
            self.wait_until(lambda: has_accepted_tip(block.hash))
'''
2024-06-03T15:17:40.883000Z TestFramework (ERROR): Assertion failed
Traceback (most recent call last):
  File "/work/test/functional/test_framework/test_framework.py", line 147, in main
    self._run_test_internal()
  File "/work/test/functional/test_framework/test_framework.py", line 137, in _run_test_internal
    self.run_test()
  File "/work/test/functional/abc_p2p_avalanche_policy_minerfund.py", line 195, in run_test
    self.run_for_ratio(MINER_FUND_RATIO)
  File "/work/test/functional/abc_p2p_avalanche_policy_minerfund.py", line 166, in run_for_ratio
    new_block(node.getbestblockhash(), addr, amount)
  File "/work/test/functional/abc_p2p_avalanche_policy_minerfund.py", line 135, in new_block
    self.wait_until(lambda: has_accepted_tip(block.hash))
  File "/work/test/functional/test_framework/test_framework.py", line 824, in wait_until
    return wait_until_helper(
  File "/work/test/functional/test_framework/util.py", line 297, in wait_until_helper
    raise AssertionError(
AssertionError: Predicate ''''
            self.wait_until(lambda: has_accepted_tip(block.hash))
''' not true after 60.0 seconds
2024-06-03T15:17:40.933000Z TestFramework (INFO): Stopping nodes
2024-06-03T15:17:41.034000Z TestFramework (WARNING): Not cleaning up dir /work/abc-ci-builds/build-diff/test/tmp/test_runner_₿₵_  _20240603_151416/abc_p2p_avalanche_policy_minerfund_47
2024-06-03T15:17:41.034000Z TestFramework (ERROR): Test failed. Test logging available at /work/abc-ci-builds/build-diff/test/tmp/test_runner_₿₵_  _20240603_151416/abc_p2p_avalanche_policy_minerfund_47/test_framework.log
2024-06-03T15:17:41.034000Z TestFramework (ERROR): 
2024-06-03T15:17:41.035000Z TestFramework (ERROR): Hint: Call /work/test/functional/combine_logs.py '/work/abc-ci-builds/build-diff/test/tmp/test_runner_₿₵_  _20240603_151416/abc_p2p_avalanche_policy_minerfund_47' to consolidate all logs
2024-06-03T15:17:41.035000Z TestFramework (ERROR): 
2024-06-03T15:17:41.035000Z TestFramework (ERROR): If this failure happened unexpectedly or intermittently, please file a bug and provide a link or upload of the combined log.
2024-06-03T15:17:41.035000Z TestFramework (ERROR): https://github.com/Bitcoin-ABC/bitcoin-abc/issues
2024-06-03T15:17:41.035000Z TestFramework (ERROR):
====== Bitcoin ABC functional tests with the next upgrade activated: abc_p2p_avalanche_policy_stakingrewards.py ======

------- Stdout: -------
2024-06-03T15:16:25.840000Z TestFramework (INFO): Initializing test directory /work/abc-ci-builds/build-diff/test/tmp/test_runner_₿₵_  _20240603_151416/abc_p2p_avalanche_policy_stakingrewards_42
2024-06-03T15:16:30.342000Z TestFramework (ERROR): Assertion failed
Traceback (most recent call last):
  File "/work/test/functional/test_framework/test_framework.py", line 147, in main
    self._run_test_internal()
  File "/work/test/functional/test_framework/test_framework.py", line 137, in _run_test_internal
    self.run_test()
  File "/work/test/functional/abc_p2p_avalanche_policy_stakingrewards.py", line 170, in run_test
    new_block(
  File "/work/test/functional/abc_p2p_avalanche_policy_stakingrewards.py", line 149, in new_block
    assert_equal(node.getbestblockhash(), expected_tip)
  File "/work/test/functional/test_framework/util.py", line 61, in assert_equal
    raise AssertionError(
AssertionError: not(1949fa3877de56bb618841857bd614b1c90107545bc68e5060004eb736e9bb4a == 72174a8a8fd685d80447554cce4806643a83189973e6f6a3c0ff258a694b7e1d)
2024-06-03T15:16:30.393000Z TestFramework (INFO): Stopping nodes
2024-06-03T15:16:30.495000Z TestFramework (WARNING): Not cleaning up dir /work/abc-ci-builds/build-diff/test/tmp/test_runner_₿₵_  _20240603_151416/abc_p2p_avalanche_policy_stakingrewards_42
2024-06-03T15:16:30.495000Z TestFramework (ERROR): Test failed. Test logging available at /work/abc-ci-builds/build-diff/test/tmp/test_runner_₿₵_  _20240603_151416/abc_p2p_avalanche_policy_stakingrewards_42/test_framework.log
2024-06-03T15:16:30.495000Z TestFramework (ERROR): 
2024-06-03T15:16:30.496000Z TestFramework (ERROR): Hint: Call /work/test/functional/combine_logs.py '/work/abc-ci-builds/build-diff/test/tmp/test_runner_₿₵_  _20240603_151416/abc_p2p_avalanche_policy_stakingrewards_42' to consolidate all logs
2024-06-03T15:16:30.496000Z TestFramework (ERROR): 
2024-06-03T15:16:30.496000Z TestFramework (ERROR): If this failure happened unexpectedly or intermittently, please file a bug and provide a link or upload of the combined log.
2024-06-03T15:16:30.497000Z TestFramework (ERROR): https://github.com/Bitcoin-ABC/bitcoin-abc/issues
2024-06-03T15:16:30.497000Z TestFramework (ERROR):
====== Bitcoin ABC functional tests with the next upgrade activated: abc_p2p_avalanche_transaction_voting.py ======

------- Stdout: -------
2024-06-03T15:15:40.982000Z TestFramework (INFO): Initializing test directory /work/abc-ci-builds/build-diff/test/tmp/test_runner_₿₵_  _20240603_151416/abc_p2p_avalanche_transaction_voting_28
2024-06-03T15:15:41.525000Z TestFramework (INFO): Check the votes are unknown while the quorum is not established
2024-06-03T15:15:41.579000Z TestFramework (INFO): Check the votes on valid mempool transactions
2024-06-03T15:15:43.570000Z TestFramework (INFO): Check the votes on recently mined transactions
2024-06-03T15:15:44.257000Z TestFramework (INFO): Check the votes on unknown transactions
2024-06-03T15:15:44.313000Z TestFramework (INFO): Check the votes on invalid transactions
2024-06-03T15:15:44.418000Z TestFramework (INFO): Check the votes on orphan transactions
2024-06-03T15:15:44.523000Z TestFramework (INFO): Check the node polls for transactions added to the mempool
2024-06-03T15:16:48.455000Z TestFramework.utils (ERROR): wait_until() failed. Predicate: ''''
        self.wait_until(lambda: has_finalized_block(tip))
'''
2024-06-03T15:16:48.455000Z TestFramework (ERROR): Assertion failed
Traceback (most recent call last):
  File "/work/test/functional/test_framework/test_framework.py", line 147, in main
    self._run_test_internal()
  File "/work/test/functional/test_framework/test_framework.py", line 137, in _run_test_internal
    self.run_test()
  File "/work/test/functional/abc_p2p_avalanche_transaction_voting.py", line 176, in run_test
    self.wait_until(lambda: has_finalized_block(tip))
  File "/work/test/functional/test_framework/test_framework.py", line 824, in wait_until
    return wait_until_helper(
  File "/work/test/functional/test_framework/util.py", line 297, in wait_until_helper
    raise AssertionError(
AssertionError: Predicate ''''
        self.wait_until(lambda: has_finalized_block(tip))
''' not true after 60.0 seconds
2024-06-03T15:16:48.506000Z TestFramework (INFO): Stopping nodes
2024-06-03T15:16:48.657000Z TestFramework (WARNING): Not cleaning up dir /work/abc-ci-builds/build-diff/test/tmp/test_runner_₿₵_  _20240603_151416/abc_p2p_avalanche_transaction_voting_28
2024-06-03T15:16:48.657000Z TestFramework (ERROR): Test failed. Test logging available at /work/abc-ci-builds/build-diff/test/tmp/test_runner_₿₵_  _20240603_151416/abc_p2p_avalanche_transaction_voting_28/test_framework.log
2024-06-03T15:16:48.657000Z TestFramework (ERROR): 
2024-06-03T15:16:48.658000Z TestFramework (ERROR): Hint: Call /work/test/functional/combine_logs.py '/work/abc-ci-builds/build-diff/test/tmp/test_runner_₿₵_  _20240603_151416/abc_p2p_avalanche_transaction_voting_28' to consolidate all logs
2024-06-03T15:16:48.658000Z TestFramework (ERROR): 
2024-06-03T15:16:48.658000Z TestFramework (ERROR): If this failure happened unexpectedly or intermittently, please file a bug and provide a link or upload of the combined log.
2024-06-03T15:16:48.658000Z TestFramework (ERROR): https://github.com/Bitcoin-ABC/bitcoin-abc/issues
2024-06-03T15:16:48.658000Z TestFramework (ERROR):
====== Bitcoin ABC functional tests with the next upgrade activated: abc_rpc_isfinal.py ======

------- Stdout: -------
2024-06-03T15:15:17.668000Z TestFramework (INFO): Initializing test directory /work/abc-ci-builds/build-diff/test/tmp/test_runner_₿₵_  _20240603_151416/abc_rpc_isfinal_22
2024-06-03T15:16:20.989000Z TestFramework.utils (ERROR): wait_until() failed. Predicate: ''''
            self.wait_until(lambda: is_finalblock(blockhash))
'''
2024-06-03T15:16:20.989000Z TestFramework (ERROR): Assertion failed
Traceback (most recent call last):
  File "/work/test/functional/test_framework/test_framework.py", line 147, in main
    self._run_test_internal()
  File "/work/test/functional/test_framework/test_framework.py", line 137, in _run_test_internal
    self.run_test()
  File "/work/test/functional/abc_rpc_isfinal.py", line 77, in run_test
    self.wait_until(lambda: is_finalblock(blockhash))
  File "/work/test/functional/test_framework/test_framework.py", line 824, in wait_until
    return wait_until_helper(
  File "/work/test/functional/test_framework/util.py", line 297, in wait_until_helper
    raise AssertionError(
AssertionError: Predicate ''''
            self.wait_until(lambda: is_finalblock(blockhash))
''' not true after 60.0 seconds
2024-06-03T15:16:21.040000Z TestFramework (INFO): Stopping nodes
2024-06-03T15:16:21.141000Z TestFramework (WARNING): Not cleaning up dir /work/abc-ci-builds/build-diff/test/tmp/test_runner_₿₵_  _20240603_151416/abc_rpc_isfinal_22
2024-06-03T15:16:21.141000Z TestFramework (ERROR): Test failed. Test logging available at /work/abc-ci-builds/build-diff/test/tmp/test_runner_₿₵_  _20240603_151416/abc_rpc_isfinal_22/test_framework.log
2024-06-03T15:16:21.141000Z TestFramework (ERROR): 
2024-06-03T15:16:21.141000Z TestFramework (ERROR): Hint: Call /work/test/functional/combine_logs.py '/work/abc-ci-builds/build-diff/test/tmp/test_runner_₿₵_  _20240603_151416/abc_rpc_isfinal_22' to consolidate all logs
2024-06-03T15:16:21.141000Z TestFramework (ERROR): 
2024-06-03T15:16:21.142000Z TestFramework (ERROR): If this failure happened unexpectedly or intermittently, please file a bug and provide a link or upload of the combined log.
2024-06-03T15:16:21.142000Z TestFramework (ERROR): https://github.com/Bitcoin-ABC/bitcoin-abc/issues
2024-06-03T15:16:21.142000Z TestFramework (ERROR):

Each failure log is accessible here:
Bitcoin ABC functional tests: abc_mining_stakingrewards.py
Bitcoin ABC functional tests: abc_p2p_avalanche_policy_minerfund.py
Bitcoin ABC functional tests: abc_p2p_avalanche_policy_stakingrewards.py
Bitcoin ABC functional tests: abc_p2p_avalanche_transaction_voting.py
Bitcoin ABC functional tests: abc_rpc_isfinal.py
Bitcoin ABC functional tests with the next upgrade activated: abc_mining_stakingrewards.py
Bitcoin ABC functional tests with the next upgrade activated: abc_p2p_avalanche_policy_minerfund.py
Bitcoin ABC functional tests with the next upgrade activated: abc_p2p_avalanche_policy_stakingrewards.py
Bitcoin ABC functional tests with the next upgrade activated: abc_p2p_avalanche_transaction_voting.py
Bitcoin ABC functional tests with the next upgrade activated: abc_rpc_isfinal.py

Failed tests logs:

====== Bitcoin ABC functional tests: abc_mining_stakingrewards.py ======

------- Stdout: -------
2024-06-03T15:24:27.833000Z TestFramework (INFO): Initializing test directory /work/abc-ci-builds/build-tsan/test/tmp/test_runner_₿₵_  _20240603_151539/abc_mining_stakingrewards_102
2024-06-03T15:24:31.617000Z TestFramework (INFO): Staking rewards not ready yet, check getblocktemplate lacks the staking rewards data
2024-06-03T15:24:31.620000Z TestFramework (INFO): Staking rewards not ready yet, check the miner doesn't produce the staking rewards output
2024-06-03T15:24:31.715000Z TestFramework (INFO): Staking rewards are computed, check the block template returns the staking rewards data
2024-06-03T15:24:33.909000Z TestFramework (ERROR): Assertion failed
Traceback (most recent call last):
  File "/work/test/functional/test_framework/test_framework.py", line 147, in main
    self._run_test_internal()
  File "/work/test/functional/test_framework/test_framework.py", line 137, in _run_test_internal
    self.run_test()
  File "/work/test/functional/abc_mining_stakingrewards.py", line 144, in run_test
    assert "stakingrewards" in gbt["coinbasetxn"]
AssertionError
2024-06-03T15:24:33.960000Z TestFramework (INFO): Stopping nodes
2024-06-03T15:24:34.312000Z TestFramework (WARNING): Not cleaning up dir /work/abc-ci-builds/build-tsan/test/tmp/test_runner_₿₵_  _20240603_151539/abc_mining_stakingrewards_102
2024-06-03T15:24:34.312000Z TestFramework (ERROR): Test failed. Test logging available at /work/abc-ci-builds/build-tsan/test/tmp/test_runner_₿₵_  _20240603_151539/abc_mining_stakingrewards_102/test_framework.log
2024-06-03T15:24:34.312000Z TestFramework (ERROR): 
2024-06-03T15:24:34.312000Z TestFramework (ERROR): Hint: Call /work/test/functional/combine_logs.py '/work/abc-ci-builds/build-tsan/test/tmp/test_runner_₿₵_  _20240603_151539/abc_mining_stakingrewards_102' to consolidate all logs
2024-06-03T15:24:34.312000Z TestFramework (ERROR): 
2024-06-03T15:24:34.312000Z TestFramework (ERROR): If this failure happened unexpectedly or intermittently, please file a bug and provide a link or upload of the combined log.
2024-06-03T15:24:34.313000Z TestFramework (ERROR): https://github.com/Bitcoin-ABC/bitcoin-abc/issues
2024-06-03T15:24:34.313000Z TestFramework (ERROR):
====== Bitcoin ABC functional tests: abc_p2p_avalanche_policy_minerfund.py ======

------- Stdout: -------
2024-06-03T15:21:41.129000Z TestFramework (INFO): Initializing test directory /work/abc-ci-builds/build-tsan/test/tmp/test_runner_₿₵_  _20240603_151539/abc_p2p_avalanche_policy_minerfund_47
2024-06-03T15:21:44.894000Z TestFramework (INFO): Miner fund test case: address: None, fund amount: 0
2024-06-03T15:23:44.998000Z TestFramework.utils (ERROR): wait_until() failed. Predicate: ''''
            self.wait_until(lambda: has_accepted_tip(block.hash))
'''
2024-06-03T15:23:44.998000Z TestFramework (ERROR): Assertion failed
Traceback (most recent call last):
  File "/work/test/functional/test_framework/test_framework.py", line 147, in main
    self._run_test_internal()
  File "/work/test/functional/test_framework/test_framework.py", line 137, in _run_test_internal
    self.run_test()
  File "/work/test/functional/abc_p2p_avalanche_policy_minerfund.py", line 195, in run_test
    self.run_for_ratio(MINER_FUND_RATIO)
  File "/work/test/functional/abc_p2p_avalanche_policy_minerfund.py", line 166, in run_for_ratio
    new_block(node.getbestblockhash(), addr, amount)
  File "/work/test/functional/abc_p2p_avalanche_policy_minerfund.py", line 135, in new_block
    self.wait_until(lambda: has_accepted_tip(block.hash))
  File "/work/test/functional/test_framework/test_framework.py", line 824, in wait_until
    return wait_until_helper(
  File "/work/test/functional/test_framework/util.py", line 297, in wait_until_helper
    raise AssertionError(
AssertionError: Predicate ''''
            self.wait_until(lambda: has_accepted_tip(block.hash))
''' not true after 120.0 seconds
2024-06-03T15:23:45.049000Z TestFramework (INFO): Stopping nodes
2024-06-03T15:23:45.251000Z TestFramework (WARNING): Not cleaning up dir /work/abc-ci-builds/build-tsan/test/tmp/test_runner_₿₵_  _20240603_151539/abc_p2p_avalanche_policy_minerfund_47
2024-06-03T15:23:45.251000Z TestFramework (ERROR): Test failed. Test logging available at /work/abc-ci-builds/build-tsan/test/tmp/test_runner_₿₵_  _20240603_151539/abc_p2p_avalanche_policy_minerfund_47/test_framework.log
2024-06-03T15:23:45.251000Z TestFramework (ERROR): 
2024-06-03T15:23:45.251000Z TestFramework (ERROR): Hint: Call /work/test/functional/combine_logs.py '/work/abc-ci-builds/build-tsan/test/tmp/test_runner_₿₵_  _20240603_151539/abc_p2p_avalanche_policy_minerfund_47' to consolidate all logs
2024-06-03T15:23:45.251000Z TestFramework (ERROR): 
2024-06-03T15:23:45.251000Z TestFramework (ERROR): If this failure happened unexpectedly or intermittently, please file a bug and provide a link or upload of the combined log.
2024-06-03T15:23:45.251000Z TestFramework (ERROR): https://github.com/Bitcoin-ABC/bitcoin-abc/issues
2024-06-03T15:23:45.251000Z TestFramework (ERROR):
====== Bitcoin ABC functional tests: abc_p2p_avalanche_policy_stakingrewards.py ======

------- Stdout: -------
2024-06-03T15:21:10.262000Z TestFramework (INFO): Initializing test directory /work/abc-ci-builds/build-tsan/test/tmp/test_runner_₿₵_  _20240603_151539/abc_p2p_avalanche_policy_stakingrewards_42
2024-06-03T15:21:16.058000Z TestFramework (ERROR): Assertion failed
Traceback (most recent call last):
  File "/work/test/functional/test_framework/test_framework.py", line 147, in main
    self._run_test_internal()
  File "/work/test/functional/test_framework/test_framework.py", line 137, in _run_test_internal
    self.run_test()
  File "/work/test/functional/abc_p2p_avalanche_policy_stakingrewards.py", line 170, in run_test
    new_block(
  File "/work/test/functional/abc_p2p_avalanche_policy_stakingrewards.py", line 149, in new_block
    assert_equal(node.getbestblockhash(), expected_tip)
  File "/work/test/functional/test_framework/util.py", line 61, in assert_equal
    raise AssertionError(
AssertionError: not(6619248ff45574a756aadb8709a39d5edbfc10f5eafc4a723efdfee0aa1cd6b5 == 29294472d6d26fbbecb0b3867c78cb18e3f72104b385c141e4f8e7bd4966254b)
2024-06-03T15:21:16.109000Z TestFramework (INFO): Stopping nodes
2024-06-03T15:21:16.361000Z TestFramework (WARNING): Not cleaning up dir /work/abc-ci-builds/build-tsan/test/tmp/test_runner_₿₵_  _20240603_151539/abc_p2p_avalanche_policy_stakingrewards_42
2024-06-03T15:21:16.361000Z TestFramework (ERROR): Test failed. Test logging available at /work/abc-ci-builds/build-tsan/test/tmp/test_runner_₿₵_  _20240603_151539/abc_p2p_avalanche_policy_stakingrewards_42/test_framework.log
2024-06-03T15:21:16.361000Z TestFramework (ERROR): 
2024-06-03T15:21:16.361000Z TestFramework (ERROR): Hint: Call /work/test/functional/combine_logs.py '/work/abc-ci-builds/build-tsan/test/tmp/test_runner_₿₵_  _20240603_151539/abc_p2p_avalanche_policy_stakingrewards_42' to consolidate all logs
2024-06-03T15:21:16.361000Z TestFramework (ERROR): 
2024-06-03T15:21:16.361000Z TestFramework (ERROR): If this failure happened unexpectedly or intermittently, please file a bug and provide a link or upload of the combined log.
2024-06-03T15:21:16.361000Z TestFramework (ERROR): https://github.com/Bitcoin-ABC/bitcoin-abc/issues
2024-06-03T15:21:16.361000Z TestFramework (ERROR):
====== Bitcoin ABC functional tests: abc_p2p_avalanche_transaction_voting.py ======

------- Stdout: -------
2024-06-03T15:19:33.705000Z TestFramework (INFO): Initializing test directory /work/abc-ci-builds/build-tsan/test/tmp/test_runner_₿₵_  _20240603_151539/abc_p2p_avalanche_transaction_voting_28
2024-06-03T15:19:35.442000Z TestFramework (INFO): Check the votes are unknown while the quorum is not established
2024-06-03T15:19:35.496000Z TestFramework (INFO): Check the votes on valid mempool transactions
2024-06-03T15:19:37.836000Z TestFramework (INFO): Check the votes on recently mined transactions
2024-06-03T15:19:38.548000Z TestFramework (INFO): Check the votes on unknown transactions
2024-06-03T15:19:38.601000Z TestFramework (INFO): Check the votes on invalid transactions
2024-06-03T15:19:38.706000Z TestFramework (INFO): Check the votes on orphan transactions
2024-06-03T15:19:38.810000Z TestFramework (INFO): Check the node polls for transactions added to the mempool
2024-06-03T15:21:43.018000Z TestFramework.utils (ERROR): wait_until() failed. Predicate: ''''
        self.wait_until(lambda: has_finalized_block(tip))
'''
2024-06-03T15:21:43.018000Z TestFramework (ERROR): Assertion failed
Traceback (most recent call last):
  File "/work/test/functional/test_framework/test_framework.py", line 147, in main
    self._run_test_internal()
  File "/work/test/functional/test_framework/test_framework.py", line 137, in _run_test_internal
    self.run_test()
  File "/work/test/functional/abc_p2p_avalanche_transaction_voting.py", line 176, in run_test
    self.wait_until(lambda: has_finalized_block(tip))
  File "/work/test/functional/test_framework/test_framework.py", line 824, in wait_until
    return wait_until_helper(
  File "/work/test/functional/test_framework/util.py", line 297, in wait_until_helper
    raise AssertionError(
AssertionError: Predicate ''''
        self.wait_until(lambda: has_finalized_block(tip))
''' not true after 120.0 seconds
2024-06-03T15:21:43.069000Z TestFramework (INFO): Stopping nodes
2024-06-03T15:21:43.423000Z TestFramework (WARNING): Not cleaning up dir /work/abc-ci-builds/build-tsan/test/tmp/test_runner_₿₵_  _20240603_151539/abc_p2p_avalanche_transaction_voting_28
2024-06-03T15:21:43.423000Z TestFramework (ERROR): Test failed. Test logging available at /work/abc-ci-builds/build-tsan/test/tmp/test_runner_₿₵_  _20240603_151539/abc_p2p_avalanche_transaction_voting_28/test_framework.log
2024-06-03T15:21:43.423000Z TestFramework (ERROR): 
2024-06-03T15:21:43.423000Z TestFramework (ERROR): Hint: Call /work/test/functional/combine_logs.py '/work/abc-ci-builds/build-tsan/test/tmp/test_runner_₿₵_  _20240603_151539/abc_p2p_avalanche_transaction_voting_28' to consolidate all logs
2024-06-03T15:21:43.423000Z TestFramework (ERROR): 
2024-06-03T15:21:43.423000Z TestFramework (ERROR): If this failure happened unexpectedly or intermittently, please file a bug and provide a link or upload of the combined log.
2024-06-03T15:21:43.423000Z TestFramework (ERROR): https://github.com/Bitcoin-ABC/bitcoin-abc/issues
2024-06-03T15:21:43.423000Z TestFramework (ERROR):
====== Bitcoin ABC functional tests: abc_rpc_isfinal.py ======

------- Stdout: -------
2024-06-03T15:19:05.825000Z TestFramework (INFO): Initializing test directory /work/abc-ci-builds/build-tsan/test/tmp/test_runner_₿₵_  _20240603_151539/abc_rpc_isfinal_22
2024-06-03T15:21:09.810000Z TestFramework.utils (ERROR): wait_until() failed. Predicate: ''''
            self.wait_until(lambda: is_finalblock(blockhash))
'''
2024-06-03T15:21:09.810000Z TestFramework (ERROR): Assertion failed
Traceback (most recent call last):
  File "/work/test/functional/test_framework/test_framework.py", line 147, in main
    self._run_test_internal()
  File "/work/test/functional/test_framework/test_framework.py", line 137, in _run_test_internal
    self.run_test()
  File "/work/test/functional/abc_rpc_isfinal.py", line 77, in run_test
    self.wait_until(lambda: is_finalblock(blockhash))
  File "/work/test/functional/test_framework/test_framework.py", line 824, in wait_until
    return wait_until_helper(
  File "/work/test/functional/test_framework/util.py", line 297, in wait_until_helper
    raise AssertionError(
AssertionError: Predicate ''''
            self.wait_until(lambda: is_finalblock(blockhash))
''' not true after 120.0 seconds
2024-06-03T15:21:09.861000Z TestFramework (INFO): Stopping nodes
2024-06-03T15:21:10.163000Z TestFramework (WARNING): Not cleaning up dir /work/abc-ci-builds/build-tsan/test/tmp/test_runner_₿₵_  _20240603_151539/abc_rpc_isfinal_22
2024-06-03T15:21:10.163000Z TestFramework (ERROR): Test failed. Test logging available at /work/abc-ci-builds/build-tsan/test/tmp/test_runner_₿₵_  _20240603_151539/abc_rpc_isfinal_22/test_framework.log
2024-06-03T15:21:10.163000Z TestFramework (ERROR): 
2024-06-03T15:21:10.163000Z TestFramework (ERROR): Hint: Call /work/test/functional/combine_logs.py '/work/abc-ci-builds/build-tsan/test/tmp/test_runner_₿₵_  _20240603_151539/abc_rpc_isfinal_22' to consolidate all logs
2024-06-03T15:21:10.163000Z TestFramework (ERROR): 
2024-06-03T15:21:10.163000Z TestFramework (ERROR): If this failure happened unexpectedly or intermittently, please file a bug and provide a link or upload of the combined log.
2024-06-03T15:21:10.163000Z TestFramework (ERROR): https://github.com/Bitcoin-ABC/bitcoin-abc/issues
2024-06-03T15:21:10.163000Z TestFramework (ERROR):

Each failure log is accessible here:
Bitcoin ABC functional tests: abc_mining_stakingrewards.py
Bitcoin ABC functional tests: abc_p2p_avalanche_policy_minerfund.py
Bitcoin ABC functional tests: abc_p2p_avalanche_policy_stakingrewards.py
Bitcoin ABC functional tests: abc_p2p_avalanche_transaction_voting.py
Bitcoin ABC functional tests: abc_rpc_isfinal.py

src/validation.cpp
2764 ↗(On Diff #48074)

just use the pointer here as well and check for null locally, this is more consistent. Or maybe do it unconditionnaly and let the callsite decide what to do with the vector

3188 ↗(On Diff #48074)

technically correct but confusing, !!avalanche is more readable (you know it's a bool). See other comment though, it might not be needed at all

call ActiveBestChain in net_processing, improve FindMostWorkChain
still a WIP

PiRK planned changes to this revision.Mon, Jun 3, 16:29

Tail of the build log:

[448/505] Running utility command for check-bitcoin-sigencoding_tests
[449/505] Running utility command for check-bitcoin-script_tests
[450/505] bitcoin: testing ismine_tests
[451/505] bitcoin: testing db_tests
[452/505] Running utility command for check-bitcoin-ismine_tests
[453/505] bitcoin: testing scriptpubkeyman_tests
[454/505] Running utility command for check-bitcoin-db_tests
[455/505] Running utility command for check-bitcoin-scriptpubkeyman_tests
[456/505] bitcoin: testing txvalidationcache_tests
[457/505] Running utility command for check-bitcoin-txvalidationcache_tests
[458/505] bitcoin: testing transaction_tests
[459/505] Running utility command for check-bitcoin-transaction_tests
[460/505] bitcoin: testing walletdb_tests
[461/505] Running utility command for check-bitcoin-walletdb_tests
[462/505] bitcoin: testing rcu_tests
[463/505] bitcoin: testing result_tests
[464/505] bitcoin: testing merkle_tests
[465/505] bitcoin: testing crypto_tests
[466/505] bitcoin: testing psbt_wallet_tests
[467/505] Running utility command for check-bitcoin-rcu_tests
[468/505] Running utility command for check-bitcoin-result_tests
[469/505] Running utility command for check-bitcoin-merkle_tests
[470/505] Running utility command for check-bitcoin-psbt_wallet_tests
[471/505] Running utility command for check-bitcoin-crypto_tests
[472/505] bitcoin: testing compress_tests
[473/505] Running utility command for check-avalanche-voterecord_tests
[474/505] bitcoin: testing denialofservice_tests
[475/505] Running utility command for check-avalanche-peermanager_tests
[476/505] Running utility command for check-bitcoin-compress_tests
[477/505] Running utility command for check-bitcoin-denialofservice_tests
[478/505] bitcoin: testing init_tests
[479/505] Running utility command for check-bitcoin-init_tests
[480/505] bitcoin: testing uint256_tests
[481/505] bitcoin: testing sighash_tests
[482/505] Running utility command for check-bitcoin-uint256_tests
[483/505] bitcoin: testing cuckoocache_tests
[484/505] Running utility command for check-bitcoin-sighash_tests
[485/505] Running utility command for check-bitcoin-cuckoocache_tests
[486/505] bitcoin: testing coinstatsindex_tests
[487/505] Running utility command for check-bitcoin-coinstatsindex_tests
[488/505] bitcoin: testing blockmanager_tests
[489/505] bitcoin: testing validation_chainstate_tests
[490/505] Running utility command for check-bitcoin-blockmanager_tests
[491/505] Running utility command for check-bitcoin-validation_chainstate_tests
[492/505] Linking CXX executable src/qt/test/test_bitcoin-qt
[493/505] bitcoin: testing wallet_crypto_tests
[494/505] Running utility command for check-bitcoin-wallet_crypto_tests
[495/505] bitcoin-qt: testing test_bitcoin-qt
[496/505] Running bitcoin-qt test suite
PASSED: bitcoin-qt test suite
[497/505] bitcoin: testing wallet_tests
[498/505] Running utility command for check-bitcoin-wallet_tests
[499/505] bitcoin: testing coinselector_tests
[500/505] Running utility command for check-bitcoin-coinselector_tests
[501/505] bitcoin: testing coins_tests
[502/505] Running utility command for check-bitcoin-coins_tests
[503/505] Running bitcoin test suite
PASSED: bitcoin test suite
ninja: build stopped: cannot make progress due to previous errors.
Build build-clang failed with exit code 1

Tail of the build log:

[443/498] Running utility command for check-bitcoin-cuckoocache_tests
[444/498] bitcoin: testing walletdb_tests
[445/498] bitcoin: testing rcu_tests
[446/498] Building CXX object src/qt/test/CMakeFiles/test_bitcoin-qt.dir/paymentservertests.cpp.o
[447/498] Running utility command for check-bitcoin-walletdb_tests
[448/498] bitcoin: testing psbt_wallet_tests
[449/498] bitcoin: testing result_tests
[450/498] Running utility command for check-bitcoin-rcu_tests
[451/498] Running utility command for check-bitcoin-psbt_wallet_tests
[452/498] Running utility command for check-bitcoin-result_tests
[453/498] bitcoin: testing compress_tests
[454/498] bitcoin: testing denialofservice_tests
[455/498] bitcoin: testing init_tests
[456/498] bitcoin: testing uint256_tests
[457/498] Running utility command for check-bitcoin-denialofservice_tests
[458/498] Running utility command for check-bitcoin-compress_tests
[459/498] bitcoin: testing validation_chainstate_tests
[460/498] Running utility command for check-pow-aserti32d_tests
[461/498] Running utility command for check-bitcoin-uint256_tests
[462/498] Running utility command for check-bitcoin-init_tests
[463/498] Running pow test suite
PASSED: pow test suite
[464/498] bitcoin: testing sighash_tests
[465/498] bitcoin: testing blockmanager_tests
[466/498] Running utility command for check-bitcoin-validation_chainstate_tests
[467/498] Running utility command for check-bitcoin-sighash_tests
[468/498] Running utility command for check-bitcoin-blockmanager_tests
[469/498] Linking CXX executable src/seeder/test/test-seeder
[470/498] seeder: testing options_tests
[471/498] seeder: testing message_writer_tests
[472/498] seeder: testing p2p_messaging_tests
[473/498] seeder: testing parse_name_tests
[474/498] Running utility command for check-seeder-options_tests
[475/498] seeder: testing write_name_tests
[476/498] Running utility command for check-seeder-p2p_messaging_tests
[477/498] Running utility command for check-seeder-write_name_tests
[478/498] Running utility command for check-seeder-message_writer_tests
[479/498] Running utility command for check-seeder-parse_name_tests
[480/498] Running seeder test suite
PASSED: seeder test suite
[481/498] bitcoin: testing wallet_crypto_tests
[482/498] Running utility command for check-bitcoin-wallet_crypto_tests
[483/498] bitcoin: testing radix_tests
[484/498] Running utility command for check-bitcoin-radix_tests
[485/498] bitcoin: testing wallet_tests
[486/498] Running utility command for check-bitcoin-wallet_tests
[487/498] bitcoin: testing coinselector_tests
[488/498] Running utility command for check-bitcoin-coinselector_tests
[489/498] Building CXX object src/qt/test/CMakeFiles/test_bitcoin-qt.dir/addressbooktests.cpp.o
[490/498] Building CXX object src/qt/test/CMakeFiles/test_bitcoin-qt.dir/wallettests.cpp.o
[491/498] Linking CXX executable src/qt/test/test_bitcoin-qt
[492/498] bitcoin: testing coins_tests
[493/498] Running utility command for check-bitcoin-coins_tests
[494/498] Running bitcoin test suite
PASSED: bitcoin test suite
[495/498] bitcoin-qt: testing test_bitcoin-qt
[496/498] Running bitcoin-qt test suite
PASSED: bitcoin-qt test suite
ninja: build stopped: cannot make progress due to previous errors.
Build build-clang-tidy failed with exit code 1

Failed tests logs:

====== Bitcoin ABC functional tests: abc_mining_stakingrewards.py ======

------- Stdout: -------
2024-06-03T16:37:38.400000Z TestFramework (INFO): Initializing test directory /work/abc-ci-builds/build-without-wallet/test/tmp/test_runner_₿₵_  _20240603_163503/abc_mining_stakingrewards_102
2024-06-03T16:37:40.603000Z TestFramework (INFO): Staking rewards not ready yet, check getblocktemplate lacks the staking rewards data
2024-06-03T16:37:40.607000Z TestFramework (INFO): Staking rewards not ready yet, check the miner doesn't produce the staking rewards output
2024-06-03T16:37:40.682000Z TestFramework (INFO): Staking rewards are computed, check the block template returns the staking rewards data
2024-06-03T16:37:42.856000Z TestFramework (ERROR): Assertion failed
Traceback (most recent call last):
  File "/work/test/functional/test_framework/test_framework.py", line 147, in main
    self._run_test_internal()
  File "/work/test/functional/test_framework/test_framework.py", line 137, in _run_test_internal
    self.run_test()
  File "/work/test/functional/abc_mining_stakingrewards.py", line 144, in run_test
    assert "stakingrewards" in gbt["coinbasetxn"]
AssertionError
2024-06-03T16:37:42.907000Z TestFramework (INFO): Stopping nodes
2024-06-03T16:37:43.058000Z TestFramework (WARNING): Not cleaning up dir /work/abc-ci-builds/build-without-wallet/test/tmp/test_runner_₿₵_  _20240603_163503/abc_mining_stakingrewards_102
2024-06-03T16:37:43.058000Z TestFramework (ERROR): Test failed. Test logging available at /work/abc-ci-builds/build-without-wallet/test/tmp/test_runner_₿₵_  _20240603_163503/abc_mining_stakingrewards_102/test_framework.log
2024-06-03T16:37:43.058000Z TestFramework (ERROR): 
2024-06-03T16:37:43.058000Z TestFramework (ERROR): Hint: Call /work/test/functional/combine_logs.py '/work/abc-ci-builds/build-without-wallet/test/tmp/test_runner_₿₵_  _20240603_163503/abc_mining_stakingrewards_102' to consolidate all logs
2024-06-03T16:37:43.058000Z TestFramework (ERROR): 
2024-06-03T16:37:43.058000Z TestFramework (ERROR): If this failure happened unexpectedly or intermittently, please file a bug and provide a link or upload of the combined log.
2024-06-03T16:37:43.058000Z TestFramework (ERROR): https://github.com/Bitcoin-ABC/bitcoin-abc/issues
2024-06-03T16:37:43.058000Z TestFramework (ERROR):
====== Bitcoin ABC functional tests: abc_p2p_avalanche_policy_minerfund.py ======

------- Stdout: -------
2024-06-03T16:36:53.575000Z TestFramework (INFO): Initializing test directory /work/abc-ci-builds/build-without-wallet/test/tmp/test_runner_₿₵_  _20240603_163503/abc_p2p_avalanche_policy_minerfund_47
2024-06-03T16:36:55.970000Z TestFramework (INFO): Miner fund test case: address: ecregtest:prfhcnyqnl5cgrnmlfmms675w93ld7mvvq9jcw0zsn, fund amount: 1869834877
2024-06-03T16:36:56.205000Z TestFramework (INFO): Miner fund test case: address: ecregtest:prfhcnyqnl5cgrnmlfmms675w93ld7mvvq9jcw0zsn, fund amount: 258040728
2024-06-03T16:37:56.312000Z TestFramework.utils (ERROR): wait_until() failed. Predicate: ''''
            self.wait_until(lambda: has_accepted_tip(block.hash))
'''
2024-06-03T16:37:56.312000Z TestFramework (ERROR): Assertion failed
Traceback (most recent call last):
  File "/work/test/functional/test_framework/test_framework.py", line 147, in main
    self._run_test_internal()
  File "/work/test/functional/test_framework/test_framework.py", line 137, in _run_test_internal
    self.run_test()
  File "/work/test/functional/abc_p2p_avalanche_policy_minerfund.py", line 195, in run_test
    self.run_for_ratio(MINER_FUND_RATIO)
  File "/work/test/functional/abc_p2p_avalanche_policy_minerfund.py", line 166, in run_for_ratio
    new_block(node.getbestblockhash(), addr, amount)
  File "/work/test/functional/abc_p2p_avalanche_policy_minerfund.py", line 135, in new_block
    self.wait_until(lambda: has_accepted_tip(block.hash))
  File "/work/test/functional/test_framework/test_framework.py", line 824, in wait_until
    return wait_until_helper(
  File "/work/test/functional/test_framework/util.py", line 297, in wait_until_helper
    raise AssertionError(
AssertionError: Predicate ''''
            self.wait_until(lambda: has_accepted_tip(block.hash))
''' not true after 60.0 seconds
2024-06-03T16:37:56.363000Z TestFramework (INFO): Stopping nodes
2024-06-03T16:37:56.514000Z TestFramework (WARNING): Not cleaning up dir /work/abc-ci-builds/build-without-wallet/test/tmp/test_runner_₿₵_  _20240603_163503/abc_p2p_avalanche_policy_minerfund_47
2024-06-03T16:37:56.514000Z TestFramework (ERROR): Test failed. Test logging available at /work/abc-ci-builds/build-without-wallet/test/tmp/test_runner_₿₵_  _20240603_163503/abc_p2p_avalanche_policy_minerfund_47/test_framework.log
2024-06-03T16:37:56.514000Z TestFramework (ERROR): 
2024-06-03T16:37:56.514000Z TestFramework (ERROR): Hint: Call /work/test/functional/combine_logs.py '/work/abc-ci-builds/build-without-wallet/test/tmp/test_runner_₿₵_  _20240603_163503/abc_p2p_avalanche_policy_minerfund_47' to consolidate all logs
2024-06-03T16:37:56.514000Z TestFramework (ERROR): 
2024-06-03T16:37:56.514000Z TestFramework (ERROR): If this failure happened unexpectedly or intermittently, please file a bug and provide a link or upload of the combined log.
2024-06-03T16:37:56.514000Z TestFramework (ERROR): https://github.com/Bitcoin-ABC/bitcoin-abc/issues
2024-06-03T16:37:56.514000Z TestFramework (ERROR):
====== Bitcoin ABC functional tests: abc_p2p_avalanche_policy_stakingrewards.py ======

------- Stdout: -------
2024-06-03T16:36:40.441000Z TestFramework (INFO): Initializing test directory /work/abc-ci-builds/build-without-wallet/test/tmp/test_runner_₿₵_  _20240603_163503/abc_p2p_avalanche_policy_stakingrewards_42
2024-06-03T16:36:45.215000Z TestFramework (ERROR): Assertion failed
Traceback (most recent call last):
  File "/work/test/functional/test_framework/test_framework.py", line 147, in main
    self._run_test_internal()
  File "/work/test/functional/test_framework/test_framework.py", line 137, in _run_test_internal
    self.run_test()
  File "/work/test/functional/abc_p2p_avalanche_policy_stakingrewards.py", line 170, in run_test
    new_block(
  File "/work/test/functional/abc_p2p_avalanche_policy_stakingrewards.py", line 149, in new_block
    assert_equal(node.getbestblockhash(), expected_tip)
  File "/work/test/functional/test_framework/util.py", line 61, in assert_equal
    raise AssertionError(
AssertionError: not(735130602c6cafba22f32e01e691f484027f3996f470e136d547925ce5f1a262 == 3e0f10551cb276986382813114d73922e25ad5b4a068a6bab1079af886a7aa16)
2024-06-03T16:36:45.267000Z TestFramework (INFO): Stopping nodes
2024-06-03T16:36:45.419000Z TestFramework (WARNING): Not cleaning up dir /work/abc-ci-builds/build-without-wallet/test/tmp/test_runner_₿₵_  _20240603_163503/abc_p2p_avalanche_policy_stakingrewards_42
2024-06-03T16:36:45.419000Z TestFramework (ERROR): Test failed. Test logging available at /work/abc-ci-builds/build-without-wallet/test/tmp/test_runner_₿₵_  _20240603_163503/abc_p2p_avalanche_policy_stakingrewards_42/test_framework.log
2024-06-03T16:36:45.419000Z TestFramework (ERROR): 
2024-06-03T16:36:45.419000Z TestFramework (ERROR): Hint: Call /work/test/functional/combine_logs.py '/work/abc-ci-builds/build-without-wallet/test/tmp/test_runner_₿₵_  _20240603_163503/abc_p2p_avalanche_policy_stakingrewards_42' to consolidate all logs
2024-06-03T16:36:45.419000Z TestFramework (ERROR): 
2024-06-03T16:36:45.419000Z TestFramework (ERROR): If this failure happened unexpectedly or intermittently, please file a bug and provide a link or upload of the combined log.
2024-06-03T16:36:45.419000Z TestFramework (ERROR): https://github.com/Bitcoin-ABC/bitcoin-abc/issues
2024-06-03T16:36:45.419000Z TestFramework (ERROR):
====== Bitcoin ABC functional tests: abc_p2p_avalanche_transaction_voting.py ======

------- Stdout: -------
2024-06-03T16:36:06.219000Z TestFramework (INFO): Initializing test directory /work/abc-ci-builds/build-without-wallet/test/tmp/test_runner_₿₵_  _20240603_163503/abc_p2p_avalanche_transaction_voting_28
2024-06-03T16:36:07.010000Z TestFramework (INFO): Check the votes are unknown while the quorum is not established
2024-06-03T16:36:07.064000Z TestFramework (INFO): Check the votes on valid mempool transactions
2024-06-03T16:36:09.166000Z TestFramework (INFO): Check the votes on recently mined transactions
2024-06-03T16:36:09.798000Z TestFramework (INFO): Check the votes on unknown transactions
2024-06-03T16:36:09.852000Z TestFramework (INFO): Check the votes on invalid transactions
2024-06-03T16:36:09.956000Z TestFramework (INFO): Check the votes on orphan transactions
2024-06-03T16:36:10.060000Z TestFramework (INFO): Check the node polls for transactions added to the mempool
2024-06-03T16:37:14.018000Z TestFramework.utils (ERROR): wait_until() failed. Predicate: ''''
        self.wait_until(lambda: has_finalized_block(tip))
'''
2024-06-03T16:37:14.018000Z TestFramework (ERROR): Assertion failed
Traceback (most recent call last):
  File "/work/test/functional/test_framework/test_framework.py", line 147, in main
    self._run_test_internal()
  File "/work/test/functional/test_framework/test_framework.py", line 137, in _run_test_internal
    self.run_test()
  File "/work/test/functional/abc_p2p_avalanche_transaction_voting.py", line 176, in run_test
    self.wait_until(lambda: has_finalized_block(tip))
  File "/work/test/functional/test_framework/test_framework.py", line 824, in wait_until
    return wait_until_helper(
  File "/work/test/functional/test_framework/util.py", line 297, in wait_until_helper
    raise AssertionError(
AssertionError: Predicate ''''
        self.wait_until(lambda: has_finalized_block(tip))
''' not true after 60.0 seconds
2024-06-03T16:37:14.068000Z TestFramework (INFO): Stopping nodes
2024-06-03T16:37:14.220000Z TestFramework (WARNING): Not cleaning up dir /work/abc-ci-builds/build-without-wallet/test/tmp/test_runner_₿₵_  _20240603_163503/abc_p2p_avalanche_transaction_voting_28
2024-06-03T16:37:14.220000Z TestFramework (ERROR): Test failed. Test logging available at /work/abc-ci-builds/build-without-wallet/test/tmp/test_runner_₿₵_  _20240603_163503/abc_p2p_avalanche_transaction_voting_28/test_framework.log
2024-06-03T16:37:14.220000Z TestFramework (ERROR): 
2024-06-03T16:37:14.220000Z TestFramework (ERROR): Hint: Call /work/test/functional/combine_logs.py '/work/abc-ci-builds/build-without-wallet/test/tmp/test_runner_₿₵_  _20240603_163503/abc_p2p_avalanche_transaction_voting_28' to consolidate all logs
2024-06-03T16:37:14.220000Z TestFramework (ERROR): 
2024-06-03T16:37:14.220000Z TestFramework (ERROR): If this failure happened unexpectedly or intermittently, please file a bug and provide a link or upload of the combined log.
2024-06-03T16:37:14.220000Z TestFramework (ERROR): https://github.com/Bitcoin-ABC/bitcoin-abc/issues
2024-06-03T16:37:14.220000Z TestFramework (ERROR):
====== Bitcoin ABC functional tests: abc_rpc_isfinal.py ======

------- Stdout: -------
2024-06-03T16:36:01.010000Z TestFramework (INFO): Initializing test directory /work/abc-ci-builds/build-without-wallet/test/tmp/test_runner_₿₵_  _20240603_163503/abc_rpc_isfinal_22
2024-06-03T16:37:04.085000Z TestFramework.utils (ERROR): wait_until() failed. Predicate: ''''
            self.wait_until(lambda: is_finalblock(blockhash))
'''
2024-06-03T16:37:04.085000Z TestFramework (ERROR): Assertion failed
Traceback (most recent call last):
  File "/work/test/functional/test_framework/test_framework.py", line 147, in main
    self._run_test_internal()
  File "/work/test/functional/test_framework/test_framework.py", line 137, in _run_test_internal
    self.run_test()
  File "/work/test/functional/abc_rpc_isfinal.py", line 77, in run_test
    self.wait_until(lambda: is_finalblock(blockhash))
  File "/work/test/functional/test_framework/test_framework.py", line 824, in wait_until
    return wait_until_helper(
  File "/work/test/functional/test_framework/util.py", line 297, in wait_until_helper
    raise AssertionError(
AssertionError: Predicate ''''
            self.wait_until(lambda: is_finalblock(blockhash))
''' not true after 60.0 seconds
2024-06-03T16:37:04.136000Z TestFramework (INFO): Stopping nodes
2024-06-03T16:37:04.287000Z TestFramework (WARNING): Not cleaning up dir /work/abc-ci-builds/build-without-wallet/test/tmp/test_runner_₿₵_  _20240603_163503/abc_rpc_isfinal_22
2024-06-03T16:37:04.287000Z TestFramework (ERROR): Test failed. Test logging available at /work/abc-ci-builds/build-without-wallet/test/tmp/test_runner_₿₵_  _20240603_163503/abc_rpc_isfinal_22/test_framework.log
2024-06-03T16:37:04.287000Z TestFramework (ERROR): 
2024-06-03T16:37:04.288000Z TestFramework (ERROR): Hint: Call /work/test/functional/combine_logs.py '/work/abc-ci-builds/build-without-wallet/test/tmp/test_runner_₿₵_  _20240603_163503/abc_rpc_isfinal_22' to consolidate all logs
2024-06-03T16:37:04.288000Z TestFramework (ERROR): 
2024-06-03T16:37:04.288000Z TestFramework (ERROR): If this failure happened unexpectedly or intermittently, please file a bug and provide a link or upload of the combined log.
2024-06-03T16:37:04.288000Z TestFramework (ERROR): https://github.com/Bitcoin-ABC/bitcoin-abc/issues
2024-06-03T16:37:04.288000Z TestFramework (ERROR):

Each failure log is accessible here:
Bitcoin ABC functional tests: abc_mining_stakingrewards.py
Bitcoin ABC functional tests: abc_p2p_avalanche_policy_minerfund.py
Bitcoin ABC functional tests: abc_p2p_avalanche_policy_stakingrewards.py
Bitcoin ABC functional tests: abc_p2p_avalanche_transaction_voting.py
Bitcoin ABC functional tests: abc_rpc_isfinal.py

Failed tests logs:

====== Bitcoin ABC functional tests: abc_mining_stakingrewards.py ======

------- Stdout: -------
2024-06-03T16:40:30.552000Z TestFramework (INFO): Initializing test directory /work/abc-ci-builds/build-debug/test/tmp/test_runner_₿₵_  _20240603_163429/abc_mining_stakingrewards_102
2024-06-03T16:40:33.194000Z TestFramework (INFO): Staking rewards not ready yet, check getblocktemplate lacks the staking rewards data
2024-06-03T16:40:33.196000Z TestFramework (INFO): Staking rewards not ready yet, check the miner doesn't produce the staking rewards output
2024-06-03T16:40:33.224000Z TestFramework (INFO): Staking rewards are computed, check the block template returns the staking rewards data
2024-06-03T16:40:35.413000Z TestFramework (ERROR): Assertion failed
Traceback (most recent call last):
  File "/work/test/functional/test_framework/test_framework.py", line 147, in main
    self._run_test_internal()
  File "/work/test/functional/test_framework/test_framework.py", line 137, in _run_test_internal
    self.run_test()
  File "/work/test/functional/abc_mining_stakingrewards.py", line 144, in run_test
    assert "stakingrewards" in gbt["coinbasetxn"]
AssertionError
2024-06-03T16:40:35.464000Z TestFramework (INFO): Stopping nodes
2024-06-03T16:40:35.565000Z TestFramework (WARNING): Not cleaning up dir /work/abc-ci-builds/build-debug/test/tmp/test_runner_₿₵_  _20240603_163429/abc_mining_stakingrewards_102
2024-06-03T16:40:35.565000Z TestFramework (ERROR): Test failed. Test logging available at /work/abc-ci-builds/build-debug/test/tmp/test_runner_₿₵_  _20240603_163429/abc_mining_stakingrewards_102/test_framework.log
2024-06-03T16:40:35.566000Z TestFramework (ERROR): 
2024-06-03T16:40:35.566000Z TestFramework (ERROR): Hint: Call /work/test/functional/combine_logs.py '/work/abc-ci-builds/build-debug/test/tmp/test_runner_₿₵_  _20240603_163429/abc_mining_stakingrewards_102' to consolidate all logs
2024-06-03T16:40:35.566000Z TestFramework (ERROR): 
2024-06-03T16:40:35.566000Z TestFramework (ERROR): If this failure happened unexpectedly or intermittently, please file a bug and provide a link or upload of the combined log.
2024-06-03T16:40:35.566000Z TestFramework (ERROR): https://github.com/Bitcoin-ABC/bitcoin-abc/issues
2024-06-03T16:40:35.566000Z TestFramework (ERROR):
====== Bitcoin ABC functional tests: abc_p2p_avalanche_policy_minerfund.py ======

------- Stdout: -------
2024-06-03T16:38:25.151000Z TestFramework (INFO): Initializing test directory /work/abc-ci-builds/build-debug/test/tmp/test_runner_₿₵_  _20240603_163429/abc_p2p_avalanche_policy_minerfund_47
2024-06-03T16:38:27.712000Z TestFramework (INFO): Miner fund test case: address: ecregtest:pqv2r67sgz3qumufap3h2uuj0zfmnzuv8v38gtrh5v, fund amount: 2861595181
2024-06-03T16:39:27.814000Z TestFramework.utils (ERROR): wait_until() failed. Predicate: ''''
            self.wait_until(lambda: has_accepted_tip(block.hash))
'''
2024-06-03T16:39:27.814000Z TestFramework (ERROR): Assertion failed
Traceback (most recent call last):
  File "/work/test/functional/test_framework/test_framework.py", line 147, in main
    self._run_test_internal()
  File "/work/test/functional/test_framework/test_framework.py", line 137, in _run_test_internal
    self.run_test()
  File "/work/test/functional/abc_p2p_avalanche_policy_minerfund.py", line 195, in run_test
    self.run_for_ratio(MINER_FUND_RATIO)
  File "/work/test/functional/abc_p2p_avalanche_policy_minerfund.py", line 166, in run_for_ratio
    new_block(node.getbestblockhash(), addr, amount)
  File "/work/test/functional/abc_p2p_avalanche_policy_minerfund.py", line 135, in new_block
    self.wait_until(lambda: has_accepted_tip(block.hash))
  File "/work/test/functional/test_framework/test_framework.py", line 824, in wait_until
    return wait_until_helper(
  File "/work/test/functional/test_framework/util.py", line 297, in wait_until_helper
    raise AssertionError(
AssertionError: Predicate ''''
            self.wait_until(lambda: has_accepted_tip(block.hash))
''' not true after 60.0 seconds
2024-06-03T16:39:27.865000Z TestFramework (INFO): Stopping nodes
2024-06-03T16:39:27.966000Z TestFramework (WARNING): Not cleaning up dir /work/abc-ci-builds/build-debug/test/tmp/test_runner_₿₵_  _20240603_163429/abc_p2p_avalanche_policy_minerfund_47
2024-06-03T16:39:27.966000Z TestFramework (ERROR): Test failed. Test logging available at /work/abc-ci-builds/build-debug/test/tmp/test_runner_₿₵_  _20240603_163429/abc_p2p_avalanche_policy_minerfund_47/test_framework.log
2024-06-03T16:39:27.966000Z TestFramework (ERROR): 
2024-06-03T16:39:27.966000Z TestFramework (ERROR): Hint: Call /work/test/functional/combine_logs.py '/work/abc-ci-builds/build-debug/test/tmp/test_runner_₿₵_  _20240603_163429/abc_p2p_avalanche_policy_minerfund_47' to consolidate all logs
2024-06-03T16:39:27.966000Z TestFramework (ERROR): 
2024-06-03T16:39:27.966000Z TestFramework (ERROR): If this failure happened unexpectedly or intermittently, please file a bug and provide a link or upload of the combined log.
2024-06-03T16:39:27.967000Z TestFramework (ERROR): https://github.com/Bitcoin-ABC/bitcoin-abc/issues
2024-06-03T16:39:27.967000Z TestFramework (ERROR):
====== Bitcoin ABC functional tests: abc_p2p_avalanche_policy_stakingrewards.py ======

------- Stdout: -------
2024-06-03T16:38:12.875000Z TestFramework (INFO): Initializing test directory /work/abc-ci-builds/build-debug/test/tmp/test_runner_₿₵_  _20240603_163429/abc_p2p_avalanche_policy_stakingrewards_42
2024-06-03T16:38:17.740000Z TestFramework (ERROR): Assertion failed
Traceback (most recent call last):
  File "/work/test/functional/test_framework/test_framework.py", line 147, in main
    self._run_test_internal()
  File "/work/test/functional/test_framework/test_framework.py", line 137, in _run_test_internal
    self.run_test()
  File "/work/test/functional/abc_p2p_avalanche_policy_stakingrewards.py", line 170, in run_test
    new_block(
  File "/work/test/functional/abc_p2p_avalanche_policy_stakingrewards.py", line 149, in new_block
    assert_equal(node.getbestblockhash(), expected_tip)
  File "/work/test/functional/test_framework/util.py", line 61, in assert_equal
    raise AssertionError(
AssertionError: not(0c3c85556cf58d5230637eddb42975849e13a362e3d2ee52a97f94ad49ee9111 == 547313db91fdb581df6ba1e93adfbd988a537d642ba4bbcdc5b0846bb8a319bb)
2024-06-03T16:38:17.791000Z TestFramework (INFO): Stopping nodes
2024-06-03T16:38:17.892000Z TestFramework (WARNING): Not cleaning up dir /work/abc-ci-builds/build-debug/test/tmp/test_runner_₿₵_  _20240603_163429/abc_p2p_avalanche_policy_stakingrewards_42
2024-06-03T16:38:17.893000Z TestFramework (ERROR): Test failed. Test logging available at /work/abc-ci-builds/build-debug/test/tmp/test_runner_₿₵_  _20240603_163429/abc_p2p_avalanche_policy_stakingrewards_42/test_framework.log
2024-06-03T16:38:17.893000Z TestFramework (ERROR): 
2024-06-03T16:38:17.893000Z TestFramework (ERROR): Hint: Call /work/test/functional/combine_logs.py '/work/abc-ci-builds/build-debug/test/tmp/test_runner_₿₵_  _20240603_163429/abc_p2p_avalanche_policy_stakingrewards_42' to consolidate all logs
2024-06-03T16:38:17.893000Z TestFramework (ERROR): 
2024-06-03T16:38:17.893000Z TestFramework (ERROR): If this failure happened unexpectedly or intermittently, please file a bug and provide a link or upload of the combined log.
2024-06-03T16:38:17.893000Z TestFramework (ERROR): https://github.com/Bitcoin-ABC/bitcoin-abc/issues
2024-06-03T16:38:17.893000Z TestFramework (ERROR):
====== Bitcoin ABC functional tests: abc_p2p_avalanche_transaction_voting.py ======

------- Stdout: -------
2024-06-03T16:37:15.254000Z TestFramework (INFO): Initializing test directory /work/abc-ci-builds/build-debug/test/tmp/test_runner_₿₵_  _20240603_163429/abc_p2p_avalanche_transaction_voting_28
2024-06-03T16:37:16.373000Z TestFramework (INFO): Check the votes are unknown while the quorum is not established
2024-06-03T16:37:16.426000Z TestFramework (INFO): Check the votes on valid mempool transactions
2024-06-03T16:37:18.620000Z TestFramework (INFO): Check the votes on recently mined transactions
2024-06-03T16:37:19.309000Z TestFramework (INFO): Check the votes on unknown transactions
2024-06-03T16:37:19.363000Z TestFramework (INFO): Check the votes on invalid transactions
2024-06-03T16:37:19.469000Z TestFramework (INFO): Check the votes on orphan transactions
2024-06-03T16:37:19.574000Z TestFramework (INFO): Check the node polls for transactions added to the mempool
2024-06-03T16:38:23.625000Z TestFramework.utils (ERROR): wait_until() failed. Predicate: ''''
        self.wait_until(lambda: has_finalized_block(tip))
'''
2024-06-03T16:38:23.625000Z TestFramework (ERROR): Assertion failed
Traceback (most recent call last):
  File "/work/test/functional/test_framework/test_framework.py", line 147, in main
    self._run_test_internal()
  File "/work/test/functional/test_framework/test_framework.py", line 137, in _run_test_internal
    self.run_test()
  File "/work/test/functional/abc_p2p_avalanche_transaction_voting.py", line 176, in run_test
    self.wait_until(lambda: has_finalized_block(tip))
  File "/work/test/functional/test_framework/test_framework.py", line 824, in wait_until
    return wait_until_helper(
  File "/work/test/functional/test_framework/util.py", line 297, in wait_until_helper
    raise AssertionError(
AssertionError: Predicate ''''
        self.wait_until(lambda: has_finalized_block(tip))
''' not true after 60.0 seconds
2024-06-03T16:38:23.675000Z TestFramework (INFO): Stopping nodes
2024-06-03T16:38:23.727000Z TestFramework (WARNING): Not cleaning up dir /work/abc-ci-builds/build-debug/test/tmp/test_runner_₿₵_  _20240603_163429/abc_p2p_avalanche_transaction_voting_28
2024-06-03T16:38:23.727000Z TestFramework (ERROR): Test failed. Test logging available at /work/abc-ci-builds/build-debug/test/tmp/test_runner_₿₵_  _20240603_163429/abc_p2p_avalanche_transaction_voting_28/test_framework.log
2024-06-03T16:38:23.727000Z TestFramework (ERROR): 
2024-06-03T16:38:23.727000Z TestFramework (ERROR): Hint: Call /work/test/functional/combine_logs.py '/work/abc-ci-builds/build-debug/test/tmp/test_runner_₿₵_  _20240603_163429/abc_p2p_avalanche_transaction_voting_28' to consolidate all logs
2024-06-03T16:38:23.727000Z TestFramework (ERROR): 
2024-06-03T16:38:23.727000Z TestFramework (ERROR): If this failure happened unexpectedly or intermittently, please file a bug and provide a link or upload of the combined log.
2024-06-03T16:38:23.727000Z TestFramework (ERROR): https://github.com/Bitcoin-ABC/bitcoin-abc/issues
2024-06-03T16:38:23.727000Z TestFramework (ERROR):
====== Bitcoin ABC functional tests: abc_rpc_isfinal.py ======

------- Stdout: -------
2024-06-03T16:36:32.174000Z TestFramework (INFO): Initializing test directory /work/abc-ci-builds/build-debug/test/tmp/test_runner_₿₵_  _20240603_163429/abc_rpc_isfinal_22
2024-06-03T16:37:35.627000Z TestFramework.utils (ERROR): wait_until() failed. Predicate: ''''
            self.wait_until(lambda: is_finalblock(blockhash))
'''
2024-06-03T16:37:35.627000Z TestFramework (ERROR): Assertion failed
Traceback (most recent call last):
  File "/work/test/functional/test_framework/test_framework.py", line 147, in main
    self._run_test_internal()
  File "/work/test/functional/test_framework/test_framework.py", line 137, in _run_test_internal
    self.run_test()
  File "/work/test/functional/abc_rpc_isfinal.py", line 77, in run_test
    self.wait_until(lambda: is_finalblock(blockhash))
  File "/work/test/functional/test_framework/test_framework.py", line 824, in wait_until
    return wait_until_helper(
  File "/work/test/functional/test_framework/util.py", line 297, in wait_until_helper
    raise AssertionError(
AssertionError: Predicate ''''
            self.wait_until(lambda: is_finalblock(blockhash))
''' not true after 60.0 seconds
2024-06-03T16:37:35.679000Z TestFramework (INFO): Stopping nodes
2024-06-03T16:37:35.780000Z TestFramework (WARNING): Not cleaning up dir /work/abc-ci-builds/build-debug/test/tmp/test_runner_₿₵_  _20240603_163429/abc_rpc_isfinal_22
2024-06-03T16:37:35.780000Z TestFramework (ERROR): Test failed. Test logging available at /work/abc-ci-builds/build-debug/test/tmp/test_runner_₿₵_  _20240603_163429/abc_rpc_isfinal_22/test_framework.log
2024-06-03T16:37:35.780000Z TestFramework (ERROR): 
2024-06-03T16:37:35.780000Z TestFramework (ERROR): Hint: Call /work/test/functional/combine_logs.py '/work/abc-ci-builds/build-debug/test/tmp/test_runner_₿₵_  _20240603_163429/abc_rpc_isfinal_22' to consolidate all logs
2024-06-03T16:37:35.780000Z TestFramework (ERROR): 
2024-06-03T16:37:35.780000Z TestFramework (ERROR): If this failure happened unexpectedly or intermittently, please file a bug and provide a link or upload of the combined log.
2024-06-03T16:37:35.780000Z TestFramework (ERROR): https://github.com/Bitcoin-ABC/bitcoin-abc/issues
2024-06-03T16:37:35.780000Z TestFramework (ERROR):

Each failure log is accessible here:
Bitcoin ABC functional tests: abc_mining_stakingrewards.py
Bitcoin ABC functional tests: abc_p2p_avalanche_policy_minerfund.py
Bitcoin ABC functional tests: abc_p2p_avalanche_policy_stakingrewards.py
Bitcoin ABC functional tests: abc_p2p_avalanche_transaction_voting.py
Bitcoin ABC functional tests: abc_rpc_isfinal.py

Failed tests logs:

====== Bitcoin ABC functional tests: abc_mining_stakingrewards.py ======

------- Stdout: -------
2024-06-03T16:39:36.122000Z TestFramework (INFO): Initializing test directory /work/abc-ci-builds/build-diff/test/tmp/test_runner_₿₵_  _20240603_163403/abc_mining_stakingrewards_102
2024-06-03T16:39:39.238000Z TestFramework (INFO): Staking rewards not ready yet, check getblocktemplate lacks the staking rewards data
2024-06-03T16:39:39.244000Z TestFramework (INFO): Staking rewards not ready yet, check the miner doesn't produce the staking rewards output
2024-06-03T16:39:39.376000Z TestFramework (INFO): Staking rewards are computed, check the block template returns the staking rewards data
2024-06-03T16:39:41.757000Z TestFramework (ERROR): Assertion failed
Traceback (most recent call last):
  File "/work/test/functional/test_framework/test_framework.py", line 147, in main
    self._run_test_internal()
  File "/work/test/functional/test_framework/test_framework.py", line 137, in _run_test_internal
    self.run_test()
  File "/work/test/functional/abc_mining_stakingrewards.py", line 144, in run_test
    assert "stakingrewards" in gbt["coinbasetxn"]
AssertionError
2024-06-03T16:39:41.808000Z TestFramework (INFO): Stopping nodes
2024-06-03T16:39:42.113000Z TestFramework (WARNING): Not cleaning up dir /work/abc-ci-builds/build-diff/test/tmp/test_runner_₿₵_  _20240603_163403/abc_mining_stakingrewards_102
2024-06-03T16:39:42.113000Z TestFramework (ERROR): Test failed. Test logging available at /work/abc-ci-builds/build-diff/test/tmp/test_runner_₿₵_  _20240603_163403/abc_mining_stakingrewards_102/test_framework.log
2024-06-03T16:39:42.114000Z TestFramework (ERROR): 
2024-06-03T16:39:42.114000Z TestFramework (ERROR): Hint: Call /work/test/functional/combine_logs.py '/work/abc-ci-builds/build-diff/test/tmp/test_runner_₿₵_  _20240603_163403/abc_mining_stakingrewards_102' to consolidate all logs
2024-06-03T16:39:42.115000Z TestFramework (ERROR): 
2024-06-03T16:39:42.115000Z TestFramework (ERROR): If this failure happened unexpectedly or intermittently, please file a bug and provide a link or upload of the combined log.
2024-06-03T16:39:42.115000Z TestFramework (ERROR): https://github.com/Bitcoin-ABC/bitcoin-abc/issues
2024-06-03T16:39:42.115000Z TestFramework (ERROR):
====== Bitcoin ABC functional tests: abc_p2p_avalanche_policy_minerfund.py ======

------- Stdout: -------
2024-06-03T16:37:51.187000Z TestFramework (INFO): Initializing test directory /work/abc-ci-builds/build-diff/test/tmp/test_runner_₿₵_  _20240603_163403/abc_p2p_avalanche_policy_minerfund_47
2024-06-03T16:37:54.226000Z TestFramework (INFO): Miner fund test case: address: ecregtest:prfhcnyqnl5cgrnmlfmms675w93ld7mvvq9jcw0zsn, fund amount: 1600000000
2024-06-03T16:37:54.469000Z TestFramework (INFO): Miner fund test case: address: ecregtest:pqv2r67sgz3qumufap3h2uuj0zfmnzuv8v38gtrh5v, fund amount: 805220319
2024-06-03T16:38:54.562000Z TestFramework.utils (ERROR): wait_until() failed. Predicate: ''''
            self.wait_until(lambda: has_accepted_tip(block.hash))
'''
2024-06-03T16:38:54.562000Z TestFramework (ERROR): Assertion failed
Traceback (most recent call last):
  File "/work/test/functional/test_framework/test_framework.py", line 147, in main
    self._run_test_internal()
  File "/work/test/functional/test_framework/test_framework.py", line 137, in _run_test_internal
    self.run_test()
  File "/work/test/functional/abc_p2p_avalanche_policy_minerfund.py", line 195, in run_test
    self.run_for_ratio(MINER_FUND_RATIO)
  File "/work/test/functional/abc_p2p_avalanche_policy_minerfund.py", line 166, in run_for_ratio
    new_block(node.getbestblockhash(), addr, amount)
  File "/work/test/functional/abc_p2p_avalanche_policy_minerfund.py", line 135, in new_block
    self.wait_until(lambda: has_accepted_tip(block.hash))
  File "/work/test/functional/test_framework/test_framework.py", line 824, in wait_until
    return wait_until_helper(
  File "/work/test/functional/test_framework/util.py", line 297, in wait_until_helper
    raise AssertionError(
AssertionError: Predicate ''''
            self.wait_until(lambda: has_accepted_tip(block.hash))
''' not true after 60.0 seconds
2024-06-03T16:38:54.612000Z TestFramework (INFO): Stopping nodes
2024-06-03T16:38:54.864000Z TestFramework (WARNING): Not cleaning up dir /work/abc-ci-builds/build-diff/test/tmp/test_runner_₿₵_  _20240603_163403/abc_p2p_avalanche_policy_minerfund_47
2024-06-03T16:38:54.864000Z TestFramework (ERROR): Test failed. Test logging available at /work/abc-ci-builds/build-diff/test/tmp/test_runner_₿₵_  _20240603_163403/abc_p2p_avalanche_policy_minerfund_47/test_framework.log
2024-06-03T16:38:54.864000Z TestFramework (ERROR): 
2024-06-03T16:38:54.864000Z TestFramework (ERROR): Hint: Call /work/test/functional/combine_logs.py '/work/abc-ci-builds/build-diff/test/tmp/test_runner_₿₵_  _20240603_163403/abc_p2p_avalanche_policy_minerfund_47' to consolidate all logs
2024-06-03T16:38:54.864000Z TestFramework (ERROR): 
2024-06-03T16:38:54.864000Z TestFramework (ERROR): If this failure happened unexpectedly or intermittently, please file a bug and provide a link or upload of the combined log.
2024-06-03T16:38:54.864000Z TestFramework (ERROR): https://github.com/Bitcoin-ABC/bitcoin-abc/issues
2024-06-03T16:38:54.864000Z TestFramework (ERROR):
====== Bitcoin ABC functional tests: abc_p2p_avalanche_policy_stakingrewards.py ======

------- Stdout: -------
2024-06-03T16:37:34.470000Z TestFramework (INFO): Initializing test directory /work/abc-ci-builds/build-diff/test/tmp/test_runner_₿₵_  _20240603_163403/abc_p2p_avalanche_policy_stakingrewards_42
2024-06-03T16:37:39.796000Z TestFramework (ERROR): Assertion failed
Traceback (most recent call last):
  File "/work/test/functional/test_framework/test_framework.py", line 147, in main
    self._run_test_internal()
  File "/work/test/functional/test_framework/test_framework.py", line 137, in _run_test_internal
    self.run_test()
  File "/work/test/functional/abc_p2p_avalanche_policy_stakingrewards.py", line 170, in run_test
    new_block(
  File "/work/test/functional/abc_p2p_avalanche_policy_stakingrewards.py", line 149, in new_block
    assert_equal(node.getbestblockhash(), expected_tip)
  File "/work/test/functional/test_framework/util.py", line 61, in assert_equal
    raise AssertionError(
AssertionError: not(4b694203aa336c877f6fc9f403ae7feaf555165641f6880933cb33c233150a57 == 19b33fa1eb8c67009d89b1225d4a2f98e526131f2dfb0f3deef48f1b410fe271)
2024-06-03T16:37:39.847000Z TestFramework (INFO): Stopping nodes
2024-06-03T16:37:40.101000Z TestFramework (WARNING): Not cleaning up dir /work/abc-ci-builds/build-diff/test/tmp/test_runner_₿₵_  _20240603_163403/abc_p2p_avalanche_policy_stakingrewards_42
2024-06-03T16:37:40.102000Z TestFramework (ERROR): Test failed. Test logging available at /work/abc-ci-builds/build-diff/test/tmp/test_runner_₿₵_  _20240603_163403/abc_p2p_avalanche_policy_stakingrewards_42/test_framework.log
2024-06-03T16:37:40.102000Z TestFramework (ERROR): 
2024-06-03T16:37:40.102000Z TestFramework (ERROR): Hint: Call /work/test/functional/combine_logs.py '/work/abc-ci-builds/build-diff/test/tmp/test_runner_₿₵_  _20240603_163403/abc_p2p_avalanche_policy_stakingrewards_42' to consolidate all logs
2024-06-03T16:37:40.102000Z TestFramework (ERROR): 
2024-06-03T16:37:40.102000Z TestFramework (ERROR): If this failure happened unexpectedly or intermittently, please file a bug and provide a link or upload of the combined log.
2024-06-03T16:37:40.102000Z TestFramework (ERROR): https://github.com/Bitcoin-ABC/bitcoin-abc/issues
2024-06-03T16:37:40.102000Z TestFramework (ERROR):
====== Bitcoin ABC functional tests: abc_p2p_avalanche_transaction_voting.py ======

------- Stdout: -------
2024-06-03T16:36:45.171000Z TestFramework (INFO): Initializing test directory /work/abc-ci-builds/build-diff/test/tmp/test_runner_₿₵_  _20240603_163403/abc_p2p_avalanche_transaction_voting_28
2024-06-03T16:36:46.145000Z TestFramework (INFO): Check the votes are unknown while the quorum is not established
2024-06-03T16:36:46.198000Z TestFramework (INFO): Check the votes on valid mempool transactions
2024-06-03T16:36:48.188000Z TestFramework (INFO): Check the votes on recently mined transactions
2024-06-03T16:36:48.826000Z TestFramework (INFO): Check the votes on unknown transactions
2024-06-03T16:36:48.880000Z TestFramework (INFO): Check the votes on invalid transactions
2024-06-03T16:36:48.984000Z TestFramework (INFO): Check the votes on orphan transactions
2024-06-03T16:36:49.088000Z TestFramework (INFO): Check the node polls for transactions added to the mempool
2024-06-03T16:37:53.724000Z TestFramework.utils (ERROR): wait_until() failed. Predicate: ''''
        self.wait_until(lambda: has_finalized_block(tip))
'''
2024-06-03T16:37:53.724000Z TestFramework (ERROR): Assertion failed
Traceback (most recent call last):
  File "/work/test/functional/test_framework/test_framework.py", line 147, in main
    self._run_test_internal()
  File "/work/test/functional/test_framework/test_framework.py", line 137, in _run_test_internal
    self.run_test()
  File "/work/test/functional/abc_p2p_avalanche_transaction_voting.py", line 176, in run_test
    self.wait_until(lambda: has_finalized_block(tip))
  File "/work/test/functional/test_framework/test_framework.py", line 824, in wait_until
    return wait_until_helper(
  File "/work/test/functional/test_framework/util.py", line 297, in wait_until_helper
    raise AssertionError(
AssertionError: Predicate ''''
        self.wait_until(lambda: has_finalized_block(tip))
''' not true after 60.0 seconds
2024-06-03T16:37:53.775000Z TestFramework (INFO): Stopping nodes
2024-06-03T16:37:54.128000Z TestFramework (WARNING): Not cleaning up dir /work/abc-ci-builds/build-diff/test/tmp/test_runner_₿₵_  _20240603_163403/abc_p2p_avalanche_transaction_voting_28
2024-06-03T16:37:54.128000Z TestFramework (ERROR): Test failed. Test logging available at /work/abc-ci-builds/build-diff/test/tmp/test_runner_₿₵_  _20240603_163403/abc_p2p_avalanche_transaction_voting_28/test_framework.log
2024-06-03T16:37:54.128000Z TestFramework (ERROR): 
2024-06-03T16:37:54.128000Z TestFramework (ERROR): Hint: Call /work/test/functional/combine_logs.py '/work/abc-ci-builds/build-diff/test/tmp/test_runner_₿₵_  _20240603_163403/abc_p2p_avalanche_transaction_voting_28' to consolidate all logs
2024-06-03T16:37:54.128000Z TestFramework (ERROR): 
2024-06-03T16:37:54.128000Z TestFramework (ERROR): If this failure happened unexpectedly or intermittently, please file a bug and provide a link or upload of the combined log.
2024-06-03T16:37:54.128000Z TestFramework (ERROR): https://github.com/Bitcoin-ABC/bitcoin-abc/issues
2024-06-03T16:37:54.128000Z TestFramework (ERROR):
====== Bitcoin ABC functional tests: abc_rpc_isfinal.py ======

------- Stdout: -------
2024-06-03T16:36:14.258000Z TestFramework (INFO): Initializing test directory /work/abc-ci-builds/build-diff/test/tmp/test_runner_₿₵_  _20240603_163403/abc_rpc_isfinal_22
2024-06-03T16:37:17.983000Z TestFramework.utils (ERROR): wait_until() failed. Predicate: ''''
            self.wait_until(lambda: is_finalblock(blockhash))
'''
2024-06-03T16:37:17.983000Z TestFramework (ERROR): Assertion failed
Traceback (most recent call last):
  File "/work/test/functional/test_framework/test_framework.py", line 147, in main
    self._run_test_internal()
  File "/work/test/functional/test_framework/test_framework.py", line 137, in _run_test_internal
    self.run_test()
  File "/work/test/functional/abc_rpc_isfinal.py", line 77, in run_test
    self.wait_until(lambda: is_finalblock(blockhash))
  File "/work/test/functional/test_framework/test_framework.py", line 824, in wait_until
    return wait_until_helper(
  File "/work/test/functional/test_framework/util.py", line 297, in wait_until_helper
    raise AssertionError(
AssertionError: Predicate ''''
            self.wait_until(lambda: is_finalblock(blockhash))
''' not true after 60.0 seconds
2024-06-03T16:37:18.034000Z TestFramework (INFO): Stopping nodes
2024-06-03T16:37:18.285000Z TestFramework (WARNING): Not cleaning up dir /work/abc-ci-builds/build-diff/test/tmp/test_runner_₿₵_  _20240603_163403/abc_rpc_isfinal_22
2024-06-03T16:37:18.285000Z TestFramework (ERROR): Test failed. Test logging available at /work/abc-ci-builds/build-diff/test/tmp/test_runner_₿₵_  _20240603_163403/abc_rpc_isfinal_22/test_framework.log
2024-06-03T16:37:18.285000Z TestFramework (ERROR): 
2024-06-03T16:37:18.285000Z TestFramework (ERROR): Hint: Call /work/test/functional/combine_logs.py '/work/abc-ci-builds/build-diff/test/tmp/test_runner_₿₵_  _20240603_163403/abc_rpc_isfinal_22' to consolidate all logs
2024-06-03T16:37:18.285000Z TestFramework (ERROR): 
2024-06-03T16:37:18.285000Z TestFramework (ERROR): If this failure happened unexpectedly or intermittently, please file a bug and provide a link or upload of the combined log.
2024-06-03T16:37:18.285000Z TestFramework (ERROR): https://github.com/Bitcoin-ABC/bitcoin-abc/issues
2024-06-03T16:37:18.285000Z TestFramework (ERROR):
====== Bitcoin ABC functional tests with the next upgrade activated: abc_mining_stakingrewards.py ======

------- Stdout: -------
2024-06-03T16:46:14.124000Z TestFramework (INFO): Initializing test directory /work/abc-ci-builds/build-diff/test/tmp/test_runner_₿₵_  _20240603_164102/abc_mining_stakingrewards_102
2024-06-03T16:46:17.182000Z TestFramework (INFO): Staking rewards not ready yet, check getblocktemplate lacks the staking rewards data
2024-06-03T16:46:17.188000Z TestFramework (INFO): Staking rewards not ready yet, check the miner doesn't produce the staking rewards output
2024-06-03T16:46:17.326000Z TestFramework (INFO): Staking rewards are computed, check the block template returns the staking rewards data
2024-06-03T16:46:19.647000Z TestFramework (ERROR): Assertion failed
Traceback (most recent call last):
  File "/work/test/functional/test_framework/test_framework.py", line 147, in main
    self._run_test_internal()
  File "/work/test/functional/test_framework/test_framework.py", line 137, in _run_test_internal
    self.run_test()
  File "/work/test/functional/abc_mining_stakingrewards.py", line 144, in run_test
    assert "stakingrewards" in gbt["coinbasetxn"]
AssertionError
2024-06-03T16:46:19.698000Z TestFramework (INFO): Stopping nodes
2024-06-03T16:46:20.000000Z TestFramework (WARNING): Not cleaning up dir /work/abc-ci-builds/build-diff/test/tmp/test_runner_₿₵_  _20240603_164102/abc_mining_stakingrewards_102
2024-06-03T16:46:20.000000Z TestFramework (ERROR): Test failed. Test logging available at /work/abc-ci-builds/build-diff/test/tmp/test_runner_₿₵_  _20240603_164102/abc_mining_stakingrewards_102/test_framework.log
2024-06-03T16:46:20.000000Z TestFramework (ERROR): 
2024-06-03T16:46:20.001000Z TestFramework (ERROR): Hint: Call /work/test/functional/combine_logs.py '/work/abc-ci-builds/build-diff/test/tmp/test_runner_₿₵_  _20240603_164102/abc_mining_stakingrewards_102' to consolidate all logs
2024-06-03T16:46:20.001000Z TestFramework (ERROR): 
2024-06-03T16:46:20.001000Z TestFramework (ERROR): If this failure happened unexpectedly or intermittently, please file a bug and provide a link or upload of the combined log.
2024-06-03T16:46:20.001000Z TestFramework (ERROR): https://github.com/Bitcoin-ABC/bitcoin-abc/issues
2024-06-03T16:46:20.001000Z TestFramework (ERROR):
====== Bitcoin ABC functional tests with the next upgrade activated: abc_p2p_avalanche_policy_minerfund.py ======

------- Stdout: -------
2024-06-03T16:44:24.217000Z TestFramework (INFO): Initializing test directory /work/abc-ci-builds/build-diff/test/tmp/test_runner_₿₵_  _20240603_164102/abc_p2p_avalanche_policy_minerfund_47
2024-06-03T16:44:27.404000Z TestFramework (INFO): Miner fund test case: address: ecregtest:prfhcnyqnl5cgrnmlfmms675w93ld7mvvq9jcw0zsn, fund amount: 2679592423
2024-06-03T16:44:27.641000Z TestFramework (INFO): Miner fund test case: address: ecregtest:pqv2r67sgz3qumufap3h2uuj0zfmnzuv8v38gtrh5v, fund amount: 1159883928
2024-06-03T16:45:27.725000Z TestFramework.utils (ERROR): wait_until() failed. Predicate: ''''
            self.wait_until(lambda: has_accepted_tip(block.hash))
'''
2024-06-03T16:45:27.725000Z TestFramework (ERROR): Assertion failed
Traceback (most recent call last):
  File "/work/test/functional/test_framework/test_framework.py", line 147, in main
    self._run_test_internal()
  File "/work/test/functional/test_framework/test_framework.py", line 137, in _run_test_internal
    self.run_test()
  File "/work/test/functional/abc_p2p_avalanche_policy_minerfund.py", line 195, in run_test
    self.run_for_ratio(MINER_FUND_RATIO)
  File "/work/test/functional/abc_p2p_avalanche_policy_minerfund.py", line 166, in run_for_ratio
    new_block(node.getbestblockhash(), addr, amount)
  File "/work/test/functional/abc_p2p_avalanche_policy_minerfund.py", line 135, in new_block
    self.wait_until(lambda: has_accepted_tip(block.hash))
  File "/work/test/functional/test_framework/test_framework.py", line 824, in wait_until
    return wait_until_helper(
  File "/work/test/functional/test_framework/util.py", line 297, in wait_until_helper
    raise AssertionError(
AssertionError: Predicate ''''
            self.wait_until(lambda: has_accepted_tip(block.hash))
''' not true after 60.0 seconds
2024-06-03T16:45:27.776000Z TestFramework (INFO): Stopping nodes
2024-06-03T16:45:27.977000Z TestFramework (WARNING): Not cleaning up dir /work/abc-ci-builds/build-diff/test/tmp/test_runner_₿₵_  _20240603_164102/abc_p2p_avalanche_policy_minerfund_47
2024-06-03T16:45:27.977000Z TestFramework (ERROR): Test failed. Test logging available at /work/abc-ci-builds/build-diff/test/tmp/test_runner_₿₵_  _20240603_164102/abc_p2p_avalanche_policy_minerfund_47/test_framework.log
2024-06-03T16:45:27.977000Z TestFramework (ERROR): 
2024-06-03T16:45:27.977000Z TestFramework (ERROR): Hint: Call /work/test/functional/combine_logs.py '/work/abc-ci-builds/build-diff/test/tmp/test_runner_₿₵_  _20240603_164102/abc_p2p_avalanche_policy_minerfund_47' to consolidate all logs
2024-06-03T16:45:27.977000Z TestFramework (ERROR): 
2024-06-03T16:45:27.977000Z TestFramework (ERROR): If this failure happened unexpectedly or intermittently, please file a bug and provide a link or upload of the combined log.
2024-06-03T16:45:27.977000Z TestFramework (ERROR): https://github.com/Bitcoin-ABC/bitcoin-abc/issues
2024-06-03T16:45:27.977000Z TestFramework (ERROR):
====== Bitcoin ABC functional tests with the next upgrade activated: abc_p2p_avalanche_policy_stakingrewards.py ======

------- Stdout: -------
2024-06-03T16:44:09.830000Z TestFramework (INFO): Initializing test directory /work/abc-ci-builds/build-diff/test/tmp/test_runner_₿₵_  _20240603_164102/abc_p2p_avalanche_policy_stakingrewards_42
2024-06-03T16:44:15.003000Z TestFramework (ERROR): Assertion failed
Traceback (most recent call last):
  File "/work/test/functional/test_framework/test_framework.py", line 147, in main
    self._run_test_internal()
  File "/work/test/functional/test_framework/test_framework.py", line 137, in _run_test_internal
    self.run_test()
  File "/work/test/functional/abc_p2p_avalanche_policy_stakingrewards.py", line 170, in run_test
    new_block(
  File "/work/test/functional/abc_p2p_avalanche_policy_stakingrewards.py", line 149, in new_block
    assert_equal(node.getbestblockhash(), expected_tip)
  File "/work/test/functional/test_framework/util.py", line 61, in assert_equal
    raise AssertionError(
AssertionError: not(68c66a42dd45f06ab33c5518035c4aeab00afb470989eb7b0cbcc0a6e39a7078 == 73c4074998a554d9a29a7f575f3865d5d01ddbe84f6162985c63b4637a66acc5)
2024-06-03T16:44:15.054000Z TestFramework (INFO): Stopping nodes
2024-06-03T16:44:15.306000Z TestFramework (WARNING): Not cleaning up dir /work/abc-ci-builds/build-diff/test/tmp/test_runner_₿₵_  _20240603_164102/abc_p2p_avalanche_policy_stakingrewards_42
2024-06-03T16:44:15.307000Z TestFramework (ERROR): Test failed. Test logging available at /work/abc-ci-builds/build-diff/test/tmp/test_runner_₿₵_  _20240603_164102/abc_p2p_avalanche_policy_stakingrewards_42/test_framework.log
2024-06-03T16:44:15.307000Z TestFramework (ERROR): 
2024-06-03T16:44:15.307000Z TestFramework (ERROR): Hint: Call /work/test/functional/combine_logs.py '/work/abc-ci-builds/build-diff/test/tmp/test_runner_₿₵_  _20240603_164102/abc_p2p_avalanche_policy_stakingrewards_42' to consolidate all logs
2024-06-03T16:44:15.307000Z TestFramework (ERROR): 
2024-06-03T16:44:15.307000Z TestFramework (ERROR): If this failure happened unexpectedly or intermittently, please file a bug and provide a link or upload of the combined log.
2024-06-03T16:44:15.307000Z TestFramework (ERROR): https://github.com/Bitcoin-ABC/bitcoin-abc/issues
2024-06-03T16:44:15.307000Z TestFramework (ERROR):
====== Bitcoin ABC functional tests with the next upgrade activated: abc_p2p_avalanche_transaction_voting.py ======

------- Stdout: -------
2024-06-03T16:43:15.683000Z TestFramework (INFO): Initializing test directory /work/abc-ci-builds/build-diff/test/tmp/test_runner_₿₵_  _20240603_164102/abc_p2p_avalanche_transaction_voting_28
2024-06-03T16:43:16.809000Z TestFramework (INFO): Check the votes are unknown while the quorum is not established
2024-06-03T16:43:16.878000Z TestFramework (INFO): Check the votes on valid mempool transactions
2024-06-03T16:43:18.914000Z TestFramework (INFO): Check the votes on recently mined transactions
2024-06-03T16:43:19.538000Z TestFramework (INFO): Check the votes on unknown transactions
2024-06-03T16:43:19.592000Z TestFramework (INFO): Check the votes on invalid transactions
2024-06-03T16:43:19.696000Z TestFramework (INFO): Check the votes on orphan transactions
2024-06-03T16:43:19.801000Z TestFramework (INFO): Check the node polls for transactions added to the mempool
2024-06-03T16:44:23.744000Z TestFramework.utils (ERROR): wait_until() failed. Predicate: ''''
        self.wait_until(lambda: has_finalized_block(tip))
'''
2024-06-03T16:44:23.745000Z TestFramework (ERROR): Assertion failed
Traceback (most recent call last):
  File "/work/test/functional/test_framework/test_framework.py", line 147, in main
    self._run_test_internal()
  File "/work/test/functional/test_framework/test_framework.py", line 137, in _run_test_internal
    self.run_test()
  File "/work/test/functional/abc_p2p_avalanche_transaction_voting.py", line 176, in run_test
    self.wait_until(lambda: has_finalized_block(tip))
  File "/work/test/functional/test_framework/test_framework.py", line 824, in wait_until
    return wait_until_helper(
  File "/work/test/functional/test_framework/util.py", line 297, in wait_until_helper
    raise AssertionError(
AssertionError: Predicate ''''
        self.wait_until(lambda: has_finalized_block(tip))
''' not true after 60.0 seconds
2024-06-03T16:44:23.796000Z TestFramework (INFO): Stopping nodes
2024-06-03T16:44:24.098000Z TestFramework (WARNING): Not cleaning up dir /work/abc-ci-builds/build-diff/test/tmp/test_runner_₿₵_  _20240603_164102/abc_p2p_avalanche_transaction_voting_28
2024-06-03T16:44:24.098000Z TestFramework (ERROR): Test failed. Test logging available at /work/abc-ci-builds/build-diff/test/tmp/test_runner_₿₵_  _20240603_164102/abc_p2p_avalanche_transaction_voting_28/test_framework.log
2024-06-03T16:44:24.098000Z TestFramework (ERROR): 
2024-06-03T16:44:24.099000Z TestFramework (ERROR): Hint: Call /work/test/functional/combine_logs.py '/work/abc-ci-builds/build-diff/test/tmp/test_runner_₿₵_  _20240603_164102/abc_p2p_avalanche_transaction_voting_28' to consolidate all logs
2024-06-03T16:44:24.099000Z TestFramework (ERROR): 
2024-06-03T16:44:24.099000Z TestFramework (ERROR): If this failure happened unexpectedly or intermittently, please file a bug and provide a link or upload of the combined log.
2024-06-03T16:44:24.100000Z TestFramework (ERROR): https://github.com/Bitcoin-ABC/bitcoin-abc/issues
2024-06-03T16:44:24.100000Z TestFramework (ERROR):
====== Bitcoin ABC functional tests with the next upgrade activated: abc_rpc_isfinal.py ======

------- Stdout: -------
2024-06-03T16:42:50.636000Z TestFramework (INFO): Initializing test directory /work/abc-ci-builds/build-diff/test/tmp/test_runner_₿₵_  _20240603_164102/abc_rpc_isfinal_22
2024-06-03T16:43:54.221000Z TestFramework.utils (ERROR): wait_until() failed. Predicate: ''''
            self.wait_until(lambda: is_finalblock(blockhash))
'''
2024-06-03T16:43:54.221000Z TestFramework (ERROR): Assertion failed
Traceback (most recent call last):
  File "/work/test/functional/test_framework/test_framework.py", line 147, in main
    self._run_test_internal()
  File "/work/test/functional/test_framework/test_framework.py", line 137, in _run_test_internal
    self.run_test()
  File "/work/test/functional/abc_rpc_isfinal.py", line 77, in run_test
    self.wait_until(lambda: is_finalblock(blockhash))
  File "/work/test/functional/test_framework/test_framework.py", line 824, in wait_until
    return wait_until_helper(
  File "/work/test/functional/test_framework/util.py", line 297, in wait_until_helper
    raise AssertionError(
AssertionError: Predicate ''''
            self.wait_until(lambda: is_finalblock(blockhash))
''' not true after 60.0 seconds
2024-06-03T16:43:54.271000Z TestFramework (INFO): Stopping nodes
2024-06-03T16:43:54.523000Z TestFramework (WARNING): Not cleaning up dir /work/abc-ci-builds/build-diff/test/tmp/test_runner_₿₵_  _20240603_164102/abc_rpc_isfinal_22
2024-06-03T16:43:54.523000Z TestFramework (ERROR): Test failed. Test logging available at /work/abc-ci-builds/build-diff/test/tmp/test_runner_₿₵_  _20240603_164102/abc_rpc_isfinal_22/test_framework.log
2024-06-03T16:43:54.523000Z TestFramework (ERROR): 
2024-06-03T16:43:54.523000Z TestFramework (ERROR): Hint: Call /work/test/functional/combine_logs.py '/work/abc-ci-builds/build-diff/test/tmp/test_runner_₿₵_  _20240603_164102/abc_rpc_isfinal_22' to consolidate all logs
2024-06-03T16:43:54.523000Z TestFramework (ERROR): 
2024-06-03T16:43:54.523000Z TestFramework (ERROR): If this failure happened unexpectedly or intermittently, please file a bug and provide a link or upload of the combined log.
2024-06-03T16:43:54.523000Z TestFramework (ERROR): https://github.com/Bitcoin-ABC/bitcoin-abc/issues
2024-06-03T16:43:54.523000Z TestFramework (ERROR):

Each failure log is accessible here:
Bitcoin ABC functional tests: abc_mining_stakingrewards.py
Bitcoin ABC functional tests: abc_p2p_avalanche_policy_minerfund.py
Bitcoin ABC functional tests: abc_p2p_avalanche_policy_stakingrewards.py
Bitcoin ABC functional tests: abc_p2p_avalanche_transaction_voting.py
Bitcoin ABC functional tests: abc_rpc_isfinal.py
Bitcoin ABC functional tests with the next upgrade activated: abc_mining_stakingrewards.py
Bitcoin ABC functional tests with the next upgrade activated: abc_p2p_avalanche_policy_minerfund.py
Bitcoin ABC functional tests with the next upgrade activated: abc_p2p_avalanche_policy_stakingrewards.py
Bitcoin ABC functional tests with the next upgrade activated: abc_p2p_avalanche_transaction_voting.py
Bitcoin ABC functional tests with the next upgrade activated: abc_rpc_isfinal.py

pass avalanche down to all the ActivateBestChain callsites in non-test code

PiRK planned changes to this revision.Tue, Jun 4, 08:20

This can be split into smaller diffs

this was split into multiple diffs: D16265-D16270