Page MenuHomePhabricator

code formatting for transaction.cpp
ClosedPublic

Authored by andychen on Aug 6 2018, 02:24.

Details

Reviewers
schancel
jasonbcox
Group Reviewers
Restricted Project
Restricted Owners Package(Owns No Changed Paths)
Commits
rSTAGINGc21f4f32d8c6: code formatting for transaction.cpp
rABCc21f4f32d8c6: code formatting for transaction.cpp
Summary

as title

Test Plan

make check

Diff Detail

Repository
rABC Bitcoin ABC
Branch
code_formatting/transaction
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 3034
Build 4161: Bitcoin ABC Buildbot (legacy)
Build 4160: arc lint + arc unit

Event Timeline

Owners added a reviewer: Restricted Owners Package.Aug 6 2018, 02:24
This revision is now accepted and ready to land.Aug 6 2018, 15:12

Looks great. Thanks @andychen

src/primitives/transaction.cpp
106 ↗(On Diff #4511)

We can probably do C++11 loop here too?

127 ↗(On Diff #4511)

C++11 style loops would be great.

jasonbcox requested changes to this revision.Aug 6 2018, 23:03
jasonbcox added inline comments.
src/primitives/transaction.cpp
130 ↗(On Diff #4511)

C++11 style loop would work here as well

This revision now requires changes to proceed.Aug 6 2018, 23:03
This revision is now accepted and ready to land.Aug 7 2018, 14:42
This revision was automatically updated to reflect the committed changes.