Differential D16273

get_int64
ClosedPublic
Actions

Authored by Fabien on Jun 4 2024, 15:56.

Details

Reviewers

PiRK

Group Reviewers

Restricted Project

Commits

rABC80d4cbd1c5f5: scripted-diff: Use getInt<T> over get_int/get_int64

Summary

Replace-only diff with no change in behavior.

Backport of core#25153.

Depends on D16272.

Test Plan

ninja all check-all

Diff Detail

Repository

rABC Bitcoin ABC

Branch

PR25153

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 29212
Build 57960: Build Diff	lint-circular-dependencies · build-without-wallet · build-diff · build-debug · build-clang-tidy · build-clang
Build 57959: arc lint + arc unit

Event Timeline

Fabien created this revision.Jun 4 2024, 15:56

Herald added a reviewer: Restricted Project. · View Herald TranscriptJun 4 2024, 15:56

Fabien requested review of this revision.Jun 4 2024, 15:56

teamcity edited the summary of this revision. (Show Details)Jun 4 2024, 15:56

Fabien added a child revision: D16274: Bump univalue subtree.Jun 4 2024, 16:03

Harbormaster completed remote builds in B29212: Diff 48094.Jun 4 2024, 16:25

PiRK accepted this revision.Jun 4 2024, 18:33

This revision is now accepted and ready to land.Jun 4 2024, 18:33

Closed by commit rABC80d4cbd1c5f5: scripted-diff: Use getInt<T> over get_int/get_int64 (authored by Fabien). · Explain WhyJun 4 2024, 19:26

This revision was automatically updated to reflect the committed changes.

Fabien added a commit: rABC80d4cbd1c5f5: scripted-diff: Use getInt<T> over get_int/get_int64.

Revision Contents
Changeset List

Path

Size

src/

bitcoin-cli.cpp

41 lines

bitcoin-tx.cpp

2 lines

common/

args.cpp

2 lines

httprpc.cpp

2 lines

node/

interfaces.cpp

2 lines

qt/

rpcconsole.cpp

2 lines

rpc/

12 lines

26 lines

16 lines

6 lines

11 lines

2 lines

rawtransaction_util.cpp

8 lines

request.cpp

2 lines

server.cpp

4 lines

util.cpp

6 lines

test/

blockfilter_tests.cpp

2 lines

rpc_server_tests.cpp

2 lines

rpc_tests.cpp

26 lines

sighash_tests.cpp

4 lines

transaction_tests.cpp

6 lines

util/

settings.h

4 lines

wallet/

rpc/

backup.cpp

4 lines

encrypt.cpp

2 lines

rpcwallet.cpp

36 lines

Diff 48094

View Options

src/bitcoin-cli.cpp

View Options

src/bitcoin-tx.cpp

View Options

src/common/args.cpp

View Options

src/httprpc.cpp

View Options

src/node/interfaces.cpp

View Options

src/qt/rpcconsole.cpp

View Options

src/rpc/avalanche.cpp

View Options

src/rpc/blockchain.cpp

View Options

src/rpc/mining.cpp

View Options

src/rpc/misc.cpp

View Options

src/rpc/net.cpp

View Options

src/rpc/rawtransaction.cpp

View Options

src/rpc/rawtransaction_util.cpp

View Options

src/rpc/request.cpp

View Options

src/rpc/server.cpp

View Options

src/rpc/util.cpp

View Options

src/test/blockfilter_tests.cpp

View Options

src/test/rpc_server_tests.cpp

View Options

src/test/rpc_tests.cpp

View Options

src/test/sighash_tests.cpp

View Options

src/test/transaction_tests.cpp

View Options

src/util/settings.h

View Options

src/wallet/rpc/backup.cpp

View Options

src/wallet/rpc/encrypt.cpp

View Options

scripted-diff: Use getInt<T> over get_int/get_int64ClosedPublicActions

Details

Diff Detail

Event Timeline

Revision ContentsChangeset List

Diff 48094

src/bitcoin-cli.cpp

src/bitcoin-tx.cpp

src/common/args.cpp

src/httprpc.cpp

src/node/interfaces.cpp

src/qt/rpcconsole.cpp

src/rpc/avalanche.cpp

src/rpc/blockchain.cpp

src/rpc/mining.cpp

src/rpc/misc.cpp

src/rpc/net.cpp

src/rpc/rawtransaction.cpp

src/rpc/rawtransaction_util.cpp

src/rpc/request.cpp

src/rpc/server.cpp

src/rpc/util.cpp

src/test/blockfilter_tests.cpp

src/test/rpc_server_tests.cpp

src/test/rpc_tests.cpp

src/test/sighash_tests.cpp

src/test/transaction_tests.cpp

src/util/settings.h

src/wallet/rpc/backup.cpp

src/wallet/rpc/encrypt.cpp

src/wallet/rpcwallet.cpp

scripted-diff: Use getInt<T> over get_int/get_int64
ClosedPublic
Actions

Revision Contents
Changeset List