Differential D16292

refactor: use convenience fn to auto parse non-string parameters
ClosedPublic
Actions

Authored by Fabien on Jun 5 2024, 20:19.

Details

Reviewers

PiRK

Group Reviewers

Restricted Project

Commits

rABCd57a68a1ce19: refactor: use convenience fn to auto parse non-string parameters

Summary

Minimizes code duplication and improves function naming by having
a single (overloaded) convenience function that both checks if
the parameter is a non-string parameter and automatically parses the
value if so.

Backport of core#26506.

Test Plan

ninja all check-all

Diff Detail

Repository

rABC Bitcoin ABC

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

Fabien created this revision.Jun 5 2024, 20:19

Herald added a reviewer: Restricted Project. · View Herald TranscriptJun 5 2024, 20:19

Fabien requested review of this revision.Jun 5 2024, 20:19

teamcity edited the summary of this revision. (Show Details)Jun 5 2024, 20:20

Harbormaster completed remote builds in B29235: Diff 48133.Jun 5 2024, 20:40

PiRK accepted this revision.Jun 6 2024, 06:50

This revision is now accepted and ready to land.Jun 6 2024, 06:50

Closed by commit rABCd57a68a1ce19: refactor: use convenience fn to auto parse non-string parameters (authored by stickies-v <stickies-v@protonmail.com>, committed by Fabien). · Explain WhyJun 6 2024, 09:26

This revision was automatically updated to reflect the committed changes.

Fabien added a commit: rABCd57a68a1ce19: refactor: use convenience fn to auto parse non-string parameters.

Revision Contents
Changeset List

Path

Size

src/

rpc/

client.cpp

47 lines

Diff 48150

View Options

refactor: use convenience fn to auto parse non-string parametersClosedPublicActions