HomePhabricator

univalue: Remove unused and confusing set*() return value

Description

univalue: Remove unused and confusing set*() return value

Summary:

The value is:
 - currently unused, and useless without [[nodiscard]]
 - confusing, because it is always true, unless a num-string is set

Instead of adding [[nodiscard]], throw when setting is not possible.

Backport of core#25736.

Depends on D16283.

Test Plan:

ninja all check-all

Reviewers: #bitcoin_abc, PiRK

Reviewed By: #bitcoin_abc, PiRK

Differential Revision: https://reviews.bitcoinabc.org/D16284

Details

Provenance
MacroFake <falke.marco@gmail.com>Authored on Jul 29 2022, 13:23
FabienCommitted on Jun 5 2024, 17:49
FabienPushed on Jun 5 2024, 17:49
Reviewer
Restricted Project
Differential Revision
D16284: univalue: Remove unused and confusing set*() return value
Parents
rABCc123861d16ac: univalue: Return more detailed type check error messages
Branches
Unknown
Tags
Unknown