Page MenuHomePhabricator

univalue: Remove unused and confusing set*() return value
ClosedPublic

Authored by Fabien on Jun 5 2024, 11:58.

Details

Reviewers
PiRK
Group Reviewers
Restricted Project
Commits
rABCf011b1a31ba6: univalue: Remove unused and confusing set*() return value
Summary
The value is:
 - currently unused, and useless without [[nodiscard]]
 - confusing, because it is always true, unless a num-string is set

Instead of adding [[nodiscard]], throw when setting is not possible.

Backport of core#25736.

Depends on D16283.

Test Plan
ninja all check-all

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Lint Not Applicable
Unit
Tests Not Applicable