Differential D16304

[explorer] Show the token balance
ClosedPublic
Actions

Authored by Fabien on Thu, Jun 6, 12:18.

Details

Reviewers

Mengerian

Group Reviewers

Restricted Project

Maniphest Tasks

Restricted Maniphest Task

Commits

rABCd8f836e9e276: [explorer] Show the token balance

Summary

This was not working because of a change in the token id format from the NNG chronik (previously was bytes, now it's hex encoded). This caused a double hex encoding issue that failed the token lookup.

Ref T3543.

Test Plan

cargo run

Check an address page with tokens, the balance is correctly displayed.

Diff Detail

Repository

rABC Bitcoin ABC

Branch

explorer_show_token_balance

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 29250
Build 58036: Build Diff
Build 58035: arc lint + arc unit

Event Timeline

Fabien created this revision.Thu, Jun 6, 12:18

Herald added a reviewer: Restricted Project. · View Herald TranscriptThu, Jun 6, 12:18

Fabien requested review of this revision.Thu, Jun 6, 12:18

Harbormaster completed remote builds in B29250: Diff 48159.Thu, Jun 6, 12:18

@bot preview-explorer

teamcity awarded a token.Thu, Jun 6, 13:41

Build Bitcoin ABC Diffs / Diff Testing (preview-explorer) passed.
Preview is available at http://54.39.19.73:41372 for the next 60 minutes.

Mengerian accepted this revision.Thu, Jun 6, 13:46

This revision is now accepted and ready to land.Thu, Jun 6, 13:46

Closed by commit rABCd8f836e9e276: [explorer] Show the token balance (authored by Fabien). · Explain WhyThu, Jun 6, 14:00

This revision was automatically updated to reflect the committed changes.

Fabien added a commit: rABCd8f836e9e276: [explorer] Show the token balance.

Revision Contents
Changeset List

Path

Size

web/

explorer/

explorer-server/

src/

api.rs

8 lines

server.rs

12 lines

Diff 48159

View Options

web/explorer/explorer-server/src/api.rs