Page MenuHomePhabricator
Differential D16309

[explorer] Remove "Address is empty" message.
ClosedPublic
Actions

Authored by Mengerian on Jun 6 2024, 16:01.

Details

Reviewers
Fabien
Group Reviewers
Restricted Project
Commits
rABCa9c592d8efd7: [explorer] Remove "Address is empty" message.
Summary

It's redundant, since it already displays a balance of 0 above

Also, the previous message is slightly confusing, as it could have tokens so not really empty

Also remove the divider in the case where there are no coins listed here.

Test Plan

Run it locally, check various addresses with and without coins and tokens

Diff Detail

Repository
rABC Bitcoin ABC
Branch
explorer-emtpy-address
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 29255
Build 58046: Build Diff
Build 58045: arc lint + arc unit

Event Timeline

Mengerian created this revision.Jun 6 2024, 16:01
Herald added a reviewer: Restricted Project. · View Herald TranscriptJun 6 2024, 16:01
Mengerian requested review of this revision.Jun 6 2024, 16:01
Harbormaster completed remote builds in B29255: Diff 48172.Jun 6 2024, 16:01
Mengerian planned changes to this revision.Jun 6 2024, 16:08
Mengerian updated this revision to Diff 48174.Jun 6 2024, 17:39
Mengerian retitled this revision from [explorer] Change message for no eCash at an address to [explorer] Remove "Address is empty" message..
Mengerian edited the summary of this revision. (Show Details)
Mengerian edited the test plan for this revision. (Show Details)

Just remove the message instead of changing it

Harbormaster completed remote builds in B29256: Diff 48174.Jun 6 2024, 17:39
Fabien accepted this revision.Jun 6 2024, 18:12
This revision is now accepted and ready to land.Jun 6 2024, 18:12
Closed by commit rABCa9c592d8efd7: [explorer] Remove "Address is empty" message. (authored by Mengerian). · Explain WhyJun 7 2024, 13:43
This revision was automatically updated to reflect the committed changes.
Mengerian added a commit: rABCa9c592d8efd7: [explorer] Remove "Address is empty" message..

Revision Contents
Changeset List

PathSize
web/
explorer/
explorer-server/
templates/
pages/
2 lines

Diff 48172

View Options

web/explorer/explorer-server/templates/pages/address.html

Loading...