Differential D16310

[unvalue] Run clang-tidy against the univalue codebase
ClosedPublic
Actions

Authored by Fabien on Jun 6 2024, 18:11.

Details

Reviewers

PiRK

Group Reviewers

Restricted Project

Commits

rABC9849940ac488: [unvalue] Run clang-tidy against the univalue codebase

Summary

And fix comments and style nits as we go.

Test Plan

With Clang Tidy:

ninja check check-univalue

Diff Detail

Repository

rABC Bitcoin ABC

Branch

univalue_clang_tidy

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 29257
Build 58050: Build Diff	lint-circular-dependencies · build-without-wallet · build-diff · build-debug · build-clang · build-clang-tidy
Build 58049: arc lint + arc unit

Event Timeline

Fabien created this revision.Jun 6 2024, 18:11

Herald added a reviewer: Restricted Project. · View Herald TranscriptJun 6 2024, 18:11

Fabien requested review of this revision.Jun 6 2024, 18:11

Harbormaster completed remote builds in B29257: Diff 48175.Jun 6 2024, 18:25

PiRK accepted this revision.Jun 7 2024, 06:17

This revision is now accepted and ready to land.Jun 7 2024, 06:17

Closed by commit rABC9849940ac488: [unvalue] Run clang-tidy against the univalue codebase (authored by Fabien). · Explain WhyJun 7 2024, 08:06

This revision was automatically updated to reflect the committed changes.

Fabien added a commit: rABC9849940ac488: [unvalue] Run clang-tidy against the univalue codebase.

Revision Contents
Changeset List

Path

Size

src/

univalue/

lib/

35 lines

32 lines

169 lines

Diff 48175

View Options

src/univalue/.clang-tidy

View Options

src/univalue/lib/univalue.cpp

View Options

src/univalue/lib/univalue_get.cpp

View Options

src/univalue/lib/univalue_read.cpp

[unvalue] Run clang-tidy against the univalue codebaseClosedPublicActions

Details

Diff Detail

Event Timeline

Revision ContentsChangeset List

Diff 48175

src/univalue/.clang-tidy

src/univalue/lib/univalue.cpp

src/univalue/lib/univalue_get.cpp

src/univalue/lib/univalue_read.cpp

[unvalue] Run clang-tidy against the univalue codebase
ClosedPublic
Actions

Revision Contents
Changeset List