Differential D16314

rpc: Throw more user friendly arg type check error
ClosedPublic
Actions

Authored by Fabien on Jun 7 2024, 20:53.

Details

Reviewers

PiRK

Group Reviewers

Restricted Project

Commits

rABCfe8c891d9d2e: rpc: Throw more user friendly arg type check error

Summary

The arg type check error doesn't list which arg (position or name) failed. Fix that.

Backport of core#26929.

Due to out-of-order backports some tests have to be updated to account for the new error message.

Test Plan

ninja all check-all

Diff Detail

Repository

rABC Bitcoin ABC

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

Fabien created this revision.Jun 7 2024, 20:53

Herald added a reviewer: Restricted Project. · View Herald TranscriptJun 7 2024, 20:53

Fabien requested review of this revision.Jun 7 2024, 20:53

teamcity edited the summary of this revision. (Show Details)Jun 7 2024, 20:53

Fabien added a child revision: D16315: doc: Properly report optional RPC args.Jun 7 2024, 20:54

Harbormaster completed remote builds in B29268: Diff 48195.Jun 7 2024, 21:10

PiRK accepted this revision.Jun 10 2024, 06:29

This revision is now accepted and ready to land.Jun 10 2024, 06:29

Closed by commit rABCfe8c891d9d2e: rpc: Throw more user friendly arg type check error (authored by Fabien). · Explain WhyJun 10 2024, 07:22

This revision was automatically updated to reflect the committed changes.

Fabien added a commit: rABCfe8c891d9d2e: rpc: Throw more user friendly arg type check error.

Revision Contents
Changeset List

Path

Size

src/

rpc/

util.h

13 lines

util.cpp

74 lines

test/

functional/

mempool_accept.py

2 lines

mining_prioritisetransaction.py

4 lines

rpc_blockchain.py

18 lines

rpc_getdescriptorinfo.py

2 lines

rpc_help.py

2 lines

rpc_rawtransaction.py

10 lines

wallet_basic.py

2 lines

wallet_hd.py

4 lines

Diff 48199

View Options

src/rpc/util.h

View Options

src/rpc/util.cpp

View Options

test/functional/mempool_accept.py

View Options

test/functional/mining_prioritisetransaction.py

View Options

test/functional/rpc_blockchain.py

View Options

test/functional/rpc_getdescriptorinfo.py

View Options

test/functional/rpc_help.py

View Options

test/functional/rpc_rawtransaction.py

View Options

test/functional/wallet_basic.py

View Options

test/functional/wallet_hd.py

rpc: Throw more user friendly arg type check errorClosedPublicActions

Details

Diff Detail

Event Timeline

Revision ContentsChangeset List

Diff 48199

src/rpc/util.h

src/rpc/util.cpp

test/functional/mempool_accept.py

test/functional/mining_prioritisetransaction.py

test/functional/rpc_blockchain.py

test/functional/rpc_getdescriptorinfo.py

test/functional/rpc_help.py

test/functional/rpc_rawtransaction.py

test/functional/wallet_basic.py

test/functional/wallet_hd.py

rpc: Throw more user friendly arg type check error
ClosedPublic
Actions

Revision Contents
Changeset List