[lint] fix a false positive locale dependence detection
ClosedPublic
Actions

Authored by PiRK on Jun 13 2024, 09:16.

Details

Reviewers

Fabien

Group Reviewers

Restricted Project

Commits

rABC5aa6eda04813: [lint] fix a false positive locale dependence detection

Summary

Introduced by D16209 because I didn't include arc lint --everything in the test plan.

Test Plan

arc lint --everything

Check that there are no more errors related to cpp files.
I'm still getting some warnings and autofixes for .rs, .ts, .md and .js files, but that could be because I'm not using the right versions of prettier and rustfmt

Diff Detail

Repository

rABC Bitcoin ABC

Branch

false_positive_locale_violation

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 29292
Build 58120: Build Diff
Build 58119: arc lint + arc unit

Event Timeline

PiRK created this revision.Jun 13 2024, 09:16

Herald added a reviewer: Restricted Project. · View Herald TranscriptJun 13 2024, 09:16

PiRK requested review of this revision.Jun 13 2024, 09:16

Harbormaster completed remote builds in B29292: Diff 48233.Jun 13 2024, 09:16

PiRK retitled this revision from [lint] fix a false positive locale violation detection to [lint] fix a false positive locale dependence detection.Jun 13 2024, 09:23

Fabien accepted this revision.Jun 13 2024, 14:32

This revision is now accepted and ready to land.Jun 13 2024, 14:32

Closed by commit rABC5aa6eda04813: [lint] fix a false positive locale dependence detection (authored by PiRK). · Explain WhyJun 13 2024, 16:21

This revision was automatically updated to reflect the committed changes.

PiRK added a commit: rABC5aa6eda04813: [lint] fix a false positive locale dependence detection.