Page MenuHomePhabricator

Fix a -Wstringop-overflow warning in wallet_tests
ClosedPublic

Authored by Fabien on Jun 14 2024, 19:18.

Details

Reviewers
PiRK
Group Reviewers
Restricted Project
Commits
rABC3d461dc1f6fc: Fix a -Wstringop-overflow warning in wallet_tests
Summary

The PollutePubKey() static function assumes the pubkey internal vector is not empty. Since this is not enforced it triggers a warning with GCC 14.1.1, which is fixed by a simple assert.

Test Plan

With GCC:

ninja check-bitcoin-wallet_tests

Check there is no warning and the test passes.

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Lint Not Applicable
Unit
Tests Not Applicable