Differential D16335

Fix a -Wstringop-overflow warning in wallet_tests
ClosedPublic
Actions

Authored by Fabien on Fri, Jun 14, 19:18.

Details

Reviewers

PiRK

Group Reviewers

Restricted Project

Commits

rABC3d461dc1f6fc: Fix a -Wstringop-overflow warning in wallet_tests

Summary

The PollutePubKey() static function assumes the pubkey internal vector is not empty. Since this is not enforced it triggers a warning with GCC 14.1.1, which is fixed by a simple assert.

Test Plan

With GCC:

ninja check-bitcoin-wallet_tests

Check there is no warning and the test passes.

Diff Detail

Repository

rABC Bitcoin ABC

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

Fabien created this revision.Fri, Jun 14, 19:18

Herald added a reviewer: Restricted Project. · View Herald TranscriptFri, Jun 14, 19:18

Fabien requested review of this revision.Fri, Jun 14, 19:18

PiRK accepted this revision.Fri, Jun 14, 19:27

This revision is now accepted and ready to land.Fri, Jun 14, 19:27

Harbormaster completed remote builds in B29300: Diff 48244.Fri, Jun 14, 19:39

Closed by commit rABC3d461dc1f6fc: Fix a -Wstringop-overflow warning in wallet_tests (authored by Fabien). · Explain WhyMon, Jun 17, 07:10

This revision was automatically updated to reflect the committed changes.

Fabien added a commit: rABC3d461dc1f6fc: Fix a -Wstringop-overflow warning in wallet_tests.

Revision Contents
Changeset List

Path

Size

src/

wallet/

test/

wallet_tests.cpp

1 line

Diff 48256

View Options

src/wallet/test/wallet_tests.cpp

Fix a -Wstringop-overflow warning in wallet_testsClosedPublicActions