The PollutePubKey() static function assumes the pubkey internal vector is not empty. Since this is not enforced it triggers a warning with GCC 14.1.1, which is fixed by a simple assert.
Details
Details
- Reviewers
PiRK - Group Reviewers
Restricted Project - Commits
- rABC3d461dc1f6fc: Fix a -Wstringop-overflow warning in wallet_tests
With GCC:
ninja check-bitcoin-wallet_tests
Check there is no warning and the test passes.
Diff Detail
Diff Detail
- Repository
- rABC Bitcoin ABC
- Branch
- fix_stringop_overflow
- Lint
Lint Passed - Unit
No Test Coverage - Build Status
Buildable 29300 Build 58136: Build Diff build-diff · build-without-wallet · lint-circular-dependencies · build-debug · build-clang-tidy · build-clang Build 58135: arc lint + arc unit