Page MenuHomePhabricator
Differential D1633

[qa] make create_confirmed_utxos calculate fees
ClosedPublic
Actions

Authored by schancel on Aug 9 2018, 17:39.

Details

Reviewers
jasonbcox
Group Reviewers
Restricted Project
Commits
rSTAGING3ac42e84f48b: [qa] make create_confirmed_utxos calculate fees
rABC3ac42e84f48b: [qa] make create_confirmed_utxos calculate fees
Summary

As per title. Depends on D1632

Test Plan

./test/functional/test_runner.py

Diff Detail

Repository
rABC Bitcoin ABC
Branch
fix-move-create-confirmed-utxos
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 3055
Build 4198: Bitcoin ABC Buildbot (legacy)
Build 4197: arc lint + arc unit

Event Timeline

schancel created this revision.Aug 9 2018, 17:39
Herald added a reviewer: Restricted Project. · View Herald TranscriptAug 9 2018, 17:39
teamcity added a subscriber: teamcity.Aug 9 2018, 17:41

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

Harbormaster completed remote builds in B3048: Diff 4542.Aug 9 2018, 18:25
teamcity added a comment.Aug 9 2018, 18:25

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

schancel updated this revision to Diff 4550.Aug 9 2018, 22:04

Rebase

teamcity added a comment.Aug 9 2018, 22:06

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

jasonbcox requested changes to this revision.Aug 9 2018, 22:31
jasonbcox added a subscriber: jasonbcox.
jasonbcox added inline comments.
test/functional/test_framework/blocktools.py
125

Add a comment here explaining why you +1 the fees.

126

make this fee +1 also to be consistent

This revision now requires changes to proceed.Aug 9 2018, 22:31
Harbormaster failed remote builds in B3055: Diff 4550!Aug 9 2018, 22:49
teamcity added a comment.Aug 9 2018, 22:49

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing failed.

schancel updated this revision to Diff 4571.Aug 13 2018, 17:32

Fix nits

teamcity added a comment.Aug 13 2018, 17:34

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

teamcity added a comment.Aug 13 2018, 18:13

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

Harbormaster completed remote builds in B3070: Diff 4571.Aug 13 2018, 18:13
jasonbcox accepted this revision.Aug 13 2018, 18:57
This revision is now accepted and ready to land.Aug 13 2018, 18:57
Closed by commit rABC3ac42e84f48b: [qa] make create_confirmed_utxos calculate fees (authored by schancel). · Explain WhyAug 13 2018, 19:15
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
test/
functional/
3 lines
3 lines
3 lines
3 lines
test_framework/
20 lines

Diff 4550

View Options

test/functional/abc-high_priority_transaction.py

Loading...
View Options

test/functional/dbcrash.py

Loading...
View Options

test/functional/mempool_limit.py

Loading...
View Options

test/functional/prioritise_transaction.py

Loading...
View Options

test/functional/test_framework/blocktools.py

Loading...