Page MenuHomePhabricator

[avalanche] Remove the deprecatedrpc=getstakingreward option
ClosedPublic

Authored by Fabien on Jun 24 2024, 12:51.

Details

Reviewers
PiRK
Group Reviewers
Restricted Project
Commits
rABC35a58ba042da: [avalanche] Remove the deprecatedrpc=getstakingreward option
Summary

This has been deprecated for months and can now be removed.

Depends on D16365.

Test Plan
ninja all check-all

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

Fabien requested review of this revision.Jun 24 2024, 12:51

Tail of the build log:

-- Installing: /results/artifacts/include/secp256k1_recovery.h
-- Installing: /results/artifacts/include/secp256k1_schnorr.h
[386/569] Building CXX object src/test/CMakeFiles/testutil.dir/util/blockindex.cpp.o
[387/569] Linking CXX static library src/libcommon.a
[388/569] Linking CXX static library src/libscript.a
[389/569] Building C object src/secp256k1/CMakeFiles/internal-bench.dir/src/bench_internal.c.o
[390/569] Linking CXX static library src/libbitcoinconsensus.a
[391/569] Linking C executable src/secp256k1/internal-bench
[392/569] Building CXX object src/test/CMakeFiles/testutil.dir/util/coins.cpp.o
[393/569] Linking CXX shared library src/libbitcoinconsensus.so.0.29.7
[394/569] Creating library symlink src/libbitcoinconsensus.so.0 src/libbitcoinconsensus.so
[395/569] Building CXX object src/CMakeFiles/server.dir/txorphanage.cpp.o
[396/569] Linking CXX executable src/bitcoin-cli
[397/569] Building CXX object src/test/CMakeFiles/testutil.dir/util/str.cpp.o
[398/569] Building CXX object src/test/CMakeFiles/testutil.dir/util/random.cpp.o
[399/569] Building CXX object src/CMakeFiles/server.dir/txmempool.cpp.o
[400/569] Building CXX object src/test/CMakeFiles/testutil.dir/util/blockfilter.cpp.o
[401/569] Building CXX object src/CMakeFiles/bitcoin-tx.dir/bitcoin-tx.cpp.o
[402/569] Building CXX object src/CMakeFiles/server.dir/torcontrol.cpp.o
[403/569] Linking CXX executable src/bitcoin-tx
[404/569] Building CXX object src/wallet/CMakeFiles/wallet.dir/context.cpp.o
[405/569] Building CXX object src/test/CMakeFiles/testutil.dir/util/transaction_utils.cpp.o
[406/569] Building CXX object src/wallet/CMakeFiles/wallet.dir/bdb.cpp.o
[407/569] Building CXX object src/wallet/CMakeFiles/wallet.dir/coinselection.cpp.o
[408/569] Building CXX object src/wallet/CMakeFiles/wallet.dir/coincontrol.cpp.o
[409/569] Building CXX object src/wallet/CMakeFiles/wallet.dir/db.cpp.o
[410/569] Building CXX object src/test/CMakeFiles/testutil.dir/util/validation.cpp.o
[411/569] Building CXX object src/test/CMakeFiles/testutil.dir/util/mining.cpp.o
[412/569] Building CXX object src/test/CMakeFiles/testutil.dir/util/net.cpp.o
[413/569] Building CXX object src/wallet/CMakeFiles/wallet.dir/crypter.cpp.o
[414/569] Building CXX object src/CMakeFiles/server.dir/wallet/init.cpp.o
[415/569] Building CXX object src/CMakeFiles/server.dir/validation.cpp.o
[416/569] Building CXX object src/test/CMakeFiles/testutil.dir/util/wallet.cpp.o
[417/569] Building CXX object src/test/CMakeFiles/testutil.dir/util/setup_common.cpp.o
[418/569] Building CXX object src/wallet/CMakeFiles/wallet-tool.dir/wallettool.cpp.o
[419/569] Building CXX object src/wallet/CMakeFiles/wallet.dir/fees.cpp.o
[420/569] Building CXX object src/wallet/CMakeFiles/wallet.dir/load.cpp.o
[421/569] Building CXX object src/wallet/CMakeFiles/wallet.dir/receive.cpp.o
[422/569] Building CXX object src/wallet/CMakeFiles/wallet.dir/sqlite.cpp.o
[423/569] Building CXX object src/wallet/CMakeFiles/wallet.dir/transaction.cpp.o
[424/569] Building CXX object src/wallet/CMakeFiles/wallet.dir/rpc/signmessage.cpp.o
[425/569] Building CXX object src/wallet/CMakeFiles/wallet.dir/rpc/encrypt.cpp.o
[426/569] Building CXX object src/wallet/CMakeFiles/wallet.dir/rpc/util.cpp.o
[427/569] Building CXX object src/seeder/CMakeFiles/seeder-base.dir/dns.cpp.o
[428/569] Building CXX object src/seeder/CMakeFiles/seeder-base.dir/db.cpp.o
[429/569] Building CXX object src/seeder/CMakeFiles/seeder-base.dir/options.cpp.o
[430/569] Building CXX object src/wallet/CMakeFiles/wallet.dir/salvage.cpp.o
[431/569] Building CXX object src/wallet/CMakeFiles/wallet.dir/walletutil.cpp.o
[432/569] Building CXX object src/wallet/CMakeFiles/wallet.dir/interfaces.cpp.o
[433/569] Building CXX object src/wallet/CMakeFiles/wallet.dir/spend.cpp.o
[434/569] Building CXX object src/seeder/CMakeFiles/bitcoin-seeder.dir/main.cpp.o
[435/569] Building CXX object src/wallet/CMakeFiles/wallet.dir/rpc/backup.cpp.o
[436/569] Building CXX object src/seeder/CMakeFiles/seeder-base.dir/bitcoin.cpp.o
[437/569] Building CXX object src/wallet/CMakeFiles/wallet.dir/scriptpubkeyman.cpp.o
[438/569] Building CXX object src/wallet/CMakeFiles/wallet.dir/rpcwallet.cpp.o
[439/569] Building CXX object src/wallet/CMakeFiles/wallet.dir/walletdb.cpp.o
[440/569] Building CXX object src/wallet/CMakeFiles/wallet.dir/wallet.cpp.o
[441/569] Linking CXX static library src/wallet/libwallet.a
ninja: build stopped: cannot make progress due to previous errors.
Build build-debug failed with exit code 1
Fabien planned changes to this revision.Jun 24 2024, 12:55

Tail of the build log:

[384/569] Linking CXX static library src/libbitcoinconsensus.a
[385/569] Linking CXX shared library src/libbitcoinconsensus.so.0.29.7
[386/569] Creating library symlink src/libbitcoinconsensus.so.0 src/libbitcoinconsensus.so
[387/569] Building CXX object src/CMakeFiles/server.dir/txmempool.cpp.o
[388/569] Building CXX object src/test/CMakeFiles/testutil.dir/util/blockindex.cpp.o
[389/569] Building CXX object src/CMakeFiles/server.dir/torcontrol.cpp.o
[390/569] Building C object src/secp256k1/CMakeFiles/internal-bench.dir/src/bench_internal.c.o
[391/569] Linking C executable src/secp256k1/internal-bench
[392/569] Building CXX object src/test/CMakeFiles/testutil.dir/util/coins.cpp.o
[393/569] Building CXX object src/test/CMakeFiles/testutil.dir/util/logging.cpp.o
[394/569] Building CXX object src/test/CMakeFiles/testutil.dir/util/str.cpp.o
[395/569] Building CXX object src/test/CMakeFiles/testutil.dir/util/random.cpp.o
[396/569] Building CXX object src/test/CMakeFiles/testutil.dir/util/blockfilter.cpp.o
[397/569] Building CXX object src/CMakeFiles/bitcoin-cli.dir/bitcoin-cli.cpp.o
[398/569] Linking CXX executable src/bitcoin-cli
[399/569] Building CXX object src/test/CMakeFiles/testutil.dir/util/transaction_utils.cpp.o
[400/569] Building CXX object src/CMakeFiles/server.dir/wallet/init.cpp.o
[401/569] Building CXX object src/CMakeFiles/bitcoin-tx.dir/bitcoin-tx.cpp.o
[402/569] Linking CXX executable src/bitcoin-tx
[403/569] Building CXX object src/wallet/CMakeFiles/wallet.dir/context.cpp.o
[404/569] Building CXX object src/test/CMakeFiles/testutil.dir/util/validation.cpp.o
[405/569] Building CXX object src/CMakeFiles/server.dir/rpc/rawtransaction.cpp.o
[406/569] Building CXX object src/test/CMakeFiles/testutil.dir/util/net.cpp.o
[407/569] Building CXX object src/test/CMakeFiles/testutil.dir/util/mining.cpp.o
[408/569] Building CXX object src/wallet/CMakeFiles/wallet.dir/coincontrol.cpp.o
[409/569] Building CXX object src/wallet/CMakeFiles/wallet.dir/db.cpp.o
[410/569] Building CXX object src/CMakeFiles/server.dir/net_processing.cpp.o
[411/569] Building CXX object src/wallet/CMakeFiles/wallet.dir/crypter.cpp.o
[412/569] Building CXX object src/wallet/CMakeFiles/wallet.dir/coinselection.cpp.o
[413/569] Building CXX object src/test/CMakeFiles/testutil.dir/util/wallet.cpp.o
[414/569] Building CXX object src/CMakeFiles/server.dir/rpc/blockchain.cpp.o
[415/569] Building CXX object src/wallet/CMakeFiles/wallet.dir/bdb.cpp.o
[416/569] Building CXX object src/test/CMakeFiles/testutil.dir/util/setup_common.cpp.o
[417/569] Building CXX object src/wallet/CMakeFiles/wallet.dir/fees.cpp.o
[418/569] Building CXX object src/wallet/CMakeFiles/wallet-tool.dir/wallettool.cpp.o
[419/569] Building CXX object src/wallet/CMakeFiles/wallet.dir/load.cpp.o
[420/569] Building CXX object src/wallet/CMakeFiles/wallet.dir/receive.cpp.o
[421/569] Building CXX object src/wallet/CMakeFiles/wallet.dir/transaction.cpp.o
[422/569] Building CXX object src/wallet/CMakeFiles/wallet.dir/rpc/util.cpp.o
[423/569] Building CXX object src/wallet/CMakeFiles/wallet.dir/rpc/signmessage.cpp.o
[424/569] Building CXX object src/wallet/CMakeFiles/wallet.dir/sqlite.cpp.o
[425/569] Building CXX object src/seeder/CMakeFiles/seeder-base.dir/dns.cpp.o
[426/569] Building CXX object src/wallet/CMakeFiles/wallet.dir/rpc/encrypt.cpp.o
[427/569] Building CXX object src/seeder/CMakeFiles/seeder-base.dir/db.cpp.o
[428/569] Building CXX object src/wallet/CMakeFiles/wallet.dir/walletutil.cpp.o
[429/569] Building CXX object src/wallet/CMakeFiles/wallet.dir/salvage.cpp.o
[430/569] Building CXX object src/seeder/CMakeFiles/seeder-base.dir/options.cpp.o
[431/569] Building CXX object src/wallet/CMakeFiles/wallet.dir/interfaces.cpp.o
[432/569] Building CXX object src/CMakeFiles/server.dir/validation.cpp.o
[433/569] Building CXX object src/wallet/CMakeFiles/wallet.dir/spend.cpp.o
[434/569] Building CXX object src/seeder/CMakeFiles/seeder-base.dir/bitcoin.cpp.o
[435/569] Building CXX object src/wallet/CMakeFiles/wallet.dir/scriptpubkeyman.cpp.o
[436/569] Building CXX object src/seeder/CMakeFiles/bitcoin-seeder.dir/main.cpp.o
[437/569] Building CXX object src/wallet/CMakeFiles/wallet.dir/walletdb.cpp.o
[438/569] Building CXX object src/wallet/CMakeFiles/wallet.dir/rpc/backup.cpp.o
[439/569] Building CXX object src/wallet/CMakeFiles/wallet.dir/wallet.cpp.o
[440/569] Building CXX object src/wallet/CMakeFiles/wallet.dir/rpcwallet.cpp.o
[441/569] Linking CXX static library src/wallet/libwallet.a
ninja: build stopped: cannot make progress due to previous errors.
Build build-diff failed with exit code 1

Tail of the build log:

[485/637] Building CXX object src/CMakeFiles/bitcoinkernel.dir/policy/block/preconsensus.cpp.o
[486/637] Building CXX object src/CMakeFiles/bitcoinconsensus.dir/arith_uint256.cpp.o
[487/637] Building CXX object src/CMakeFiles/bitcoinkernel.dir/util/asmap.cpp.o
[488/637] Building CXX object src/CMakeFiles/bitcoinkernel.dir/timedata.cpp.o
[489/637] Building CXX object src/CMakeFiles/bitcoinkernel.dir/util/sock.cpp.o
[490/637] Building CXX object src/CMakeFiles/bitcoinconsensus.dir/uint256.cpp.o
[491/637] Building CXX object src/CMakeFiles/bitcoinconsensus.dir/util/strencodings.cpp.o
[492/637] Building CXX object src/CMakeFiles/bitcoinconsensus.dir/primitives/transaction.cpp.o
[493/637] Building CXX object src/CMakeFiles/bitcoinconsensus.dir/pubkey.cpp.o
[494/637] Building C object src/secp256k1/CMakeFiles/recover-bench.dir/src/bench_recover.c.o
[495/637] Building C object src/secp256k1/CMakeFiles/verify-bench.dir/src/bench_verify.c.o
[496/637] Building CXX object src/CMakeFiles/bitcoinkernel.dir/policy/block/stakingrewards.cpp.o
[497/637] Building C object src/secp256k1/CMakeFiles/sign-bench.dir/src/bench_sign.c.o
[498/637] Building CXX object src/CMakeFiles/bitcoinconsensus.dir/consensus/amount.cpp.o
[499/637] Building CXX object src/CMakeFiles/bitcoinconsensus.dir/consensus/tx_check.cpp.o
[500/637] Building CXX object src/CMakeFiles/bitcoinconsensus-shared.dir/script/bitcoinconsensus.cpp.o
[501/637] Building CXX object src/CMakeFiles/bitcoinkernel.dir/avalanche/peermanager.cpp.o
[502/637] Building C object src/secp256k1/CMakeFiles/secp256k1.dir/src/secp256k1.c.o
[503/637] Linking C static library src/secp256k1/libsecp256k1.a
[504/637] Building CXX object src/test/CMakeFiles/testutil.dir/util/blockindex.cpp.o
[505/637] Linking C executable src/secp256k1/recover-bench
[506/637] Linking CXX static library src/libbitcoinconsensus.a
[507/637] Linking C executable src/secp256k1/verify-bench
[508/637] Linking C executable src/secp256k1/sign-bench
[509/637] Linking CXX static library src/libscript.a
[510/637] Building CXX object src/CMakeFiles/bitcoin-chainstate.dir/bitcoin-chainstate.cpp.o
[511/637] Building CXX object src/test/CMakeFiles/testutil.dir/util/coins.cpp.o
[512/637] Linking CXX static library src/libcommon.a
[513/637] Building C object src/secp256k1/CMakeFiles/ecmult-bench.dir/src/bench_ecmult.c.o
[514/637] Linking CXX shared library src/libbitcoinconsensus.so.0.29.7
[515/637] Creating library symlink src/libbitcoinconsensus.so.0 src/libbitcoinconsensus.so
[516/637] Building C object src/secp256k1/CMakeFiles/internal-bench.dir/src/bench_internal.c.o
[517/637] Linking C executable src/secp256k1/ecmult-bench
[518/637] Linking CXX executable src/bitcoin-cli
[519/637] Building CXX object src/test/CMakeFiles/testutil.dir/util/logging.cpp.o
[520/637] Linking C executable src/secp256k1/internal-bench
[521/637] Building CXX object src/CMakeFiles/bitcoinkernel.dir/avalanche/processor.cpp.o
[522/637] Building CXX object src/CMakeFiles/bitcoind.dir/bitcoind.cpp.o
[523/637] Building CXX object src/test/CMakeFiles/testutil.dir/util/str.cpp.o
[524/637] Building CXX object src/seeder/CMakeFiles/seeder-base.dir/dns.cpp.o
[525/637] Building CXX object src/test/CMakeFiles/testutil.dir/util/random.cpp.o
[526/637] Building CXX object src/CMakeFiles/bitcoin-tx.dir/bitcoin-tx.cpp.o
[527/637] Building CXX object src/test/CMakeFiles/testutil.dir/util/blockfilter.cpp.o
[528/637] Building CXX object src/test/CMakeFiles/testutil.dir/util/wallet.cpp.o
[529/637] Linking CXX executable src/bitcoin-tx
[530/637] Building CXX object src/test/CMakeFiles/testutil.dir/util/transaction_utils.cpp.o
[531/637] Building CXX object src/seeder/CMakeFiles/seeder-base.dir/db.cpp.o
[532/637] Building CXX object src/seeder/CMakeFiles/seeder-base.dir/options.cpp.o
[533/637] Building CXX object src/test/CMakeFiles/testutil.dir/util/validation.cpp.o
[534/637] Building CXX object src/test/CMakeFiles/testutil.dir/util/net.cpp.o
[535/637] Building CXX object src/test/CMakeFiles/testutil.dir/util/mining.cpp.o
[536/637] Building CXX object src/seeder/CMakeFiles/seeder-base.dir/bitcoin.cpp.o
[537/637] Building CXX object src/CMakeFiles/bitcoinkernel.dir/net.cpp.o
[538/637] Building CXX object src/seeder/CMakeFiles/bitcoin-seeder.dir/main.cpp.o
[539/637] Building CXX object src/CMakeFiles/bitcoinkernel.dir/validation.cpp.o
[540/637] Building CXX object src/test/CMakeFiles/testutil.dir/util/setup_common.cpp.o
[541/637] Linking CXX static library src/libbitcoinkernel.a
[542/637] Linking CXX executable src/bitcoin-chainstate
ninja: build stopped: cannot make progress due to previous errors.
Build build-without-wallet failed with exit code 1

Tail of the build log:

[391/569] Installing component secp256k1
-- Install configuration: "RelWithDebInfo"
-- Install component: "secp256k1"
-- Installing: /results/artifacts/lib/libsecp256k1.a
-- Installing: /results/artifacts/include/secp256k1.h
-- Installing: /results/artifacts/include/secp256k1_preallocated.h
-- Installing: /results/artifacts/include/secp256k1_recovery.h
-- Installing: /results/artifacts/include/secp256k1_schnorr.h
[392/569] Linking C executable src/secp256k1/sign-bench
[393/569] Building CXX object src/test/CMakeFiles/testutil.dir/util/logging.cpp.o
[394/569] Building CXX object src/test/CMakeFiles/testutil.dir/util/str.cpp.o
[395/569] Building C object src/secp256k1/CMakeFiles/internal-bench.dir/src/bench_internal.c.o
[396/569] Linking C executable src/secp256k1/internal-bench
[397/569] Building CXX object src/test/CMakeFiles/testutil.dir/util/blockfilter.cpp.o
[398/569] Building CXX object src/test/CMakeFiles/testutil.dir/util/random.cpp.o
[399/569] Building CXX object src/CMakeFiles/server.dir/rpc/blockchain.cpp.o
[400/569] Building CXX object src/CMakeFiles/server.dir/wallet/init.cpp.o
[401/569] Building CXX object src/test/CMakeFiles/testutil.dir/util/transaction_utils.cpp.o
[402/569] Building CXX object src/CMakeFiles/server.dir/rpc/rawtransaction.cpp.o
[403/569] Building CXX object src/wallet/CMakeFiles/wallet.dir/context.cpp.o
[404/569] Building CXX object src/CMakeFiles/bitcoin-tx.dir/bitcoin-tx.cpp.o
[405/569] Linking CXX executable src/bitcoin-tx
[406/569] Building CXX object src/test/CMakeFiles/testutil.dir/util/net.cpp.o
[407/569] Building CXX object src/test/CMakeFiles/testutil.dir/util/validation.cpp.o
[408/569] Building CXX object src/wallet/CMakeFiles/wallet.dir/coincontrol.cpp.o
[409/569] Building CXX object src/test/CMakeFiles/testutil.dir/util/mining.cpp.o
[410/569] Building CXX object src/wallet/CMakeFiles/wallet.dir/db.cpp.o
[411/569] Building CXX object src/CMakeFiles/server.dir/net_processing.cpp.o
[412/569] Building CXX object src/wallet/CMakeFiles/wallet.dir/crypter.cpp.o
[413/569] Building CXX object src/wallet/CMakeFiles/wallet.dir/coinselection.cpp.o
[414/569] Building CXX object src/test/CMakeFiles/testutil.dir/util/wallet.cpp.o
[415/569] Building CXX object src/wallet/CMakeFiles/wallet.dir/bdb.cpp.o
[416/569] Building CXX object src/wallet/CMakeFiles/wallet.dir/fees.cpp.o
[417/569] Building CXX object src/wallet/CMakeFiles/wallet-tool.dir/wallettool.cpp.o
[418/569] Building CXX object src/test/CMakeFiles/testutil.dir/util/setup_common.cpp.o
[419/569] Building CXX object src/wallet/CMakeFiles/wallet.dir/load.cpp.o
[420/569] Building CXX object src/wallet/CMakeFiles/wallet.dir/receive.cpp.o
[421/569] Building CXX object src/wallet/CMakeFiles/wallet.dir/rpc/signmessage.cpp.o
[422/569] Building CXX object src/wallet/CMakeFiles/wallet.dir/rpc/util.cpp.o
[423/569] Building CXX object src/wallet/CMakeFiles/wallet.dir/transaction.cpp.o
[424/569] Building CXX object src/wallet/CMakeFiles/wallet.dir/sqlite.cpp.o
[425/569] Building CXX object src/wallet/CMakeFiles/wallet.dir/rpc/encrypt.cpp.o
[426/569] Building CXX object src/seeder/CMakeFiles/seeder-base.dir/dns.cpp.o
[427/569] Building CXX object src/wallet/CMakeFiles/wallet.dir/salvage.cpp.o
[428/569] Building CXX object src/CMakeFiles/server.dir/validation.cpp.o
[429/569] Building CXX object src/wallet/CMakeFiles/wallet.dir/walletutil.cpp.o
[430/569] Building CXX object src/seeder/CMakeFiles/seeder-base.dir/options.cpp.o
[431/569] Building CXX object src/seeder/CMakeFiles/seeder-base.dir/db.cpp.o
[432/569] Building CXX object src/wallet/CMakeFiles/wallet.dir/interfaces.cpp.o
[433/569] Building CXX object src/seeder/CMakeFiles/seeder-base.dir/bitcoin.cpp.o
[434/569] Building CXX object src/wallet/CMakeFiles/wallet.dir/spend.cpp.o
[435/569] Building CXX object src/seeder/CMakeFiles/bitcoin-seeder.dir/main.cpp.o
[436/569] Building CXX object src/wallet/CMakeFiles/wallet.dir/scriptpubkeyman.cpp.o
[437/569] Building CXX object src/wallet/CMakeFiles/wallet.dir/rpc/backup.cpp.o
[438/569] Building CXX object src/wallet/CMakeFiles/wallet.dir/walletdb.cpp.o
[439/569] Building CXX object src/wallet/CMakeFiles/wallet.dir/wallet.cpp.o
[440/569] Building CXX object src/wallet/CMakeFiles/wallet.dir/rpcwallet.cpp.o
[441/569] Linking CXX static library src/wallet/libwallet.a
ninja: build stopped: cannot make progress due to previous errors.
Build build-clang failed with exit code 1

Remove leftover comment and unused args

This revision is now accepted and ready to land.Jun 24 2024, 13:37