Page MenuHomePhabricator

[ecash-lib] Export slpAmount function
ClosedPublic

Authored by bytesofman on Jun 26 2024, 17:56.

Details

Reviewers
Fabien
Group Reviewers
Restricted Project
Commits
rABCb67ca289b64f: [ecash-lib] Export slpAmount function
Summary

In implementing NFT trading in Cashtab, it is useful for this function to be available so Cashtab can validate the script of an advertised NFT.

I can see how this type of validation could be useful for other app dev use cases. There is not really a cost in exporting the function, as webpack will only include it in apps that use it.

Test Plan

CI to confirm ecash-lib not affected.

I have not uploaded my latest working copy of D16328 yet, but locally, this change allows me to use the function in Cashtab, whereas without this change the function is not available.

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

tighten up changelog copy, correct diff link

bytesofman edited the test plan for this revision. (Show Details)
This revision is now accepted and ready to land.Jun 26 2024, 19:26
This revision was automatically updated to reflect the committed changes.