Page MenuHomePhabricator

[Cashtab] Support NFT trading
DraftPublic

Authored by bytesofman on Wed, Jun 12, 20:39.
This is a draft revision that has not yet been submitted for review.

Details

Reviewers
None
Group Reviewers
Restricted Project
Summary

Support NFT trading with ecash-agora

Test Plan

npm test

Diff Detail

Repository
rABC Bitcoin ABC
Branch
nft-market
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 29336
Build 58208: Build Diffecash-lib-tests · cashtab-tests
Build 58207: arc lint + arc unit

Event Timeline

Tail of the build log:

   Compiling secp256k1-sys-abc v0.4.1 (https://github.com/raipay/secp256k1-abc?rev=b23e742#b23e7421)
   Compiling block-buffer v0.10.4
   Compiling crypto-common v0.1.6
   Compiling digest v0.10.7
   Compiling ripemd v0.1.3
   Compiling sha2 v0.10.8
   Compiling wasm-bindgen-backend v0.2.92
   Compiling secp256k1-abc v0.20.3 (https://github.com/raipay/secp256k1-abc?rev=b23e742#b23e7421)
   Compiling thiserror-impl v1.0.58
   Compiling wasm-bindgen-macro-support v0.2.92
   Compiling wasm-bindgen-macro v0.2.92
   Compiling ecash-lib-wasm v0.1.0 (/work/modules/ecash-lib-wasm)
    Finished release-wasm [optimized] target(s) in 5.78s
/work/modules/ecash-lib /work/modules/ecash-lib-wasm /work/modules/ecash-script /work/modules/chronik-client /work/modules/mock-chronik-client /work/modules/ecashaddrjs /work/abc-ci-builds/cashtab-tests

added 362 packages, and audited 364 packages in 2s

60 packages are looking for funding
  run `npm fund` for details

1 high severity vulnerability

To address all issues, run:
  npm audit fix

Run `npm audit` for details.

> ecash-lib@0.1.1 build
> tsc && tsc -p ./tsconfig.build.json && cp -r ./src/ffi ./dist

/work/cashtab /work/modules/ecash-lib /work/modules/ecash-lib-wasm /work/modules/ecash-script /work/modules/chronik-client /work/modules/mock-chronik-client /work/modules/ecashaddrjs /work/abc-ci-builds/cashtab-tests

added 1641 packages, and audited 2458 packages in 23s

292 packages are looking for funding
  run `npm fund` for details

4 vulnerabilities (3 moderate, 1 high)

To address all issues, run:
  npm audit fix

Run `npm audit` for details.

> cashtab@2.40.3 build
> node scripts/build.js

Creating an optimized production build...
Failed to compile.

[eslint] 
src/components/Etokens/Token/index.js
  Line 1274:65:  'sendAmountError' is not defined               no-undef
  Line 1277:65:  'handleAmountChange' is not defined            no-undef
  Line 1280:65:  'handleSelectedCurrencyChange' is not defined  no-undef

Search for the keywords to learn more about each error.


Build cashtab-tests failed with exit code 1

UI elements for list price input and validation

formatting, stub function for listing NFT

Improve ux, confirmation modal