Differential D16400

[validation] remove PackageMempoolAcceptResult::m_package_feerate
ClosedPublic
Actions

Authored by Fabien on Mon, Jul 1, 21:07.

Tags

None

Subscribers

None

Details

Reviewers

Group Reviewers

Restricted Project

Commits

rABC73a2144334aa: [validation] remove PackageMempoolAcceptResult::m_package_feerate

Summary

This value creates an extremely confusing interface as its existence is
dependent upon implementation details (whether something was submitted
on its own, etc). MempoolAcceptResult::m_effective_feerate is much more
helpful, as it always exists for submitted transactions.

Partial backport of core#26646:
https://github.com/bitcoin/bitcoin/pull/26646/commits/5eab397b9840de5a4729bea723794b529e5fcbb4

Depends on D16399.

Test Plan

ninja all check-all

Diff Detail

Repository

rABC Bitcoin ABC

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

Fabien created this revision.Mon, Jul 1, 21:07

Herald added a reviewer: Restricted Project. · View Herald TranscriptMon, Jul 1, 21:07

Fabien requested review of this revision.Mon, Jul 1, 21:07

teamcity edited the summary of this revision. (Show Details)Mon, Jul 1, 21:07

Rebase

Fabien added a child revision: D16401: [doc] release note effective-feerate and effective-includes RPC results.Mon, Jul 1, 21:12

Harbormaster completed remote builds in B29428: Diff 48434.Mon, Jul 1, 22:58

Harbormaster completed remote builds in B29434: Diff 48440.Mon, Jul 1, 23:53

PiRK accepted this revision.Tue, Jul 2, 11:05

This revision is now accepted and ready to land.Tue, Jul 2, 11:05

Closed by commit rABC73a2144334aa: [validation] remove PackageMempoolAcceptResult::m_package_feerate (authored by glozow <gloriajzhao@gmail.com>, committed by Fabien). · Explain WhyTue, Jul 2, 11:28

This revision was automatically updated to reflect the committed changes.

Fabien added a commit: rABC73a2144334aa: [validation] remove PackageMempoolAcceptResult::m_package_feerate.

Revision Contents
Changeset List

Path

Size

src/

rpc/

10 lines

test/

txpackage_tests.cpp

60 lines

12 lines

15 lines

test/

functional/

rpc_packages.py

16 lines

Diff 48451

src/rpc/mempool.cpp

Loading...

src/test/txpackage_tests.cpp

Loading...

src/validation.h

Loading...

src/validation.cpp

Loading...

test/functional/rpc_packages.py

Loading...