Differential D16406
[electrum] support trezor==0.13.9 Authored by PiRK on Jul 2 2024, 11:55.
Details
The 0.13.9 version of trezor released last week breaks the Trezor plugin. For now it is best to keep supporting 0.13.8 and keep using it for releases because I only did basic tests with 0.13.9. I will keep testing the new version of the library for a while before dropping support for 0.13.8. pip install trezor==0.13.8 python test_runner.py pip install trezor==0.13.9 python test_runner.py Open a wallet with a Trezor device, connect to the device, sign a transaction.
Diff Detail
Event TimelineComment Actions revert an unwanted change. I initially tried to not define RECOVERY_TYPE_MATRIX in trezor.py, because it is not used in this module, but after testing the application interactively it turned out to be imported and used elsewhere. Comment Actions Can't you move the try catch into some compat.py and import in both places where it's used ? That means that it can be updated in a single place, and removing the file when deprecating the whole lib would cause an obvious error in places it could have been missed. |