Page MenuHomePhabricator

[electrum] support trezor==0.13.9
ClosedPublic

Authored by PiRK on Jul 2 2024, 11:55.

Details

Reviewers
Fabien
Group Reviewers
Restricted Project
Commits
rABC9fe5201a05d3: [electrum] support trezor==0.13.9
Summary

The 0.13.9 version of trezor released last week breaks the Trezor plugin.
This does not affect recent releases, which were packaged with 0.13.8 (see contrib/deterministic-build/requirements-hw.txt)

For now it is best to keep supporting 0.13.8 and keep using it for releases because I only did basic tests with 0.13.9. I will keep testing the new version of the library for a while before dropping support for 0.13.8.

Test Plan
pip install trezor==0.13.8
python test_runner.py
pip install trezor==0.13.9
python test_runner.py

Open a wallet with a Trezor device, connect to the device, sign a transaction.

Diff Detail

Repository
rABC Bitcoin ABC
Branch
electrum_fix_ci_trezor0.13.9
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 29450
Build 58436: Build Diffelectrum-tests
Build 58435: arc lint + arc unit

Event Timeline

PiRK requested review of this revision.Jul 2 2024, 11:55

revert an unwanted change. I initially tried to not define RECOVERY_TYPE_MATRIX in trezor.py, because it is not used in this module, but after testing the application interactively it turned out to be imported and used elsewhere.

Fabien requested changes to this revision.Jul 2 2024, 12:06
Fabien added a subscriber: Fabien.

Can't you move the try catch into some compat.py and import in both places where it's used ? That means that it can be updated in a single place, and removing the file when deprecating the whole lib would cause an obvious error in places it could have been missed.

This revision now requires changes to proceed.Jul 2 2024, 12:06

move the imports to compat.py

This revision is now accepted and ready to land.Jul 2 2024, 18:00
This revision was automatically updated to reflect the committed changes.