Differential D16408

test: MiniWallet: introduce enum type for output mode
ClosedPublic
Actions

Authored by Fabien on Jul 2 2024, 12:27.

Tags

None

Subscribers

Details

Reviewers

Group Reviewers

Restricted Project

Commits

rABCb92367fd8163: test: MiniWallet: introduce enum type for output mode

Summary

For the MiniWallet constructor, the two boolean parameters
"raw_script" and "use_p2pk" are replaced by a single parameter of the
newly introduced type MiniWalletMode (derived by enum.Enum), which can
hold the following values:
	- ADDRESS_OP_TRUE
	- RAW_OP_TRUE
	- RAW_P2PK

Backport of core#22048.
Depends on D16407.

Note that RAW_OP_TRUE is of no interest for use and wasn't ported.

Test Plan

ninja check-functional

Diff Detail

Repository

rABC Bitcoin ABC

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

Fabien created this revision.Jul 2 2024, 12:27

Herald added a reviewer: Restricted Project. · View Herald TranscriptJul 2 2024, 12:27

Fabien requested review of this revision.Jul 2 2024, 12:27

teamcity edited the summary of this revision. (Show Details)Jul 2 2024, 12:27

Fabien planned changes to this revision.Jul 2 2024, 12:46

Rebase

Fabien added a child revision: D16409: test: use MiniWallet (P2PK mode) for feature_dersig.py.Jul 2 2024, 13:42

Harbormaster completed remote builds in B29444: Diff 48460.Jul 2 2024, 14:06

Harbormaster completed remote builds in B29448: Diff 48465.Jul 2 2024, 14:38

PiRK requested changes to this revision.Jul 2 2024, 14:40

PiRK added a subscriber: PiRK.

PiRK added inline comments.

test/functional/test_framework/wallet.py
53–54 ↗	(On Diff #48465)

This revision now requires changes to proceed.Jul 2 2024, 14:40

PiRK added inline comments.Jul 2 2024, 15:57

test/functional/test_framework/wallet.py
57 ↗	(On Diff #48465)

Fix comment

Harbormaster completed remote builds in B29452: Diff 48469.Jul 2 2024, 19:21

PiRK accepted this revision.Jul 2 2024, 20:01

This revision is now accepted and ready to land.Jul 2 2024, 20:01

Closed by commit rABCb92367fd8163: test: MiniWallet: introduce enum type for output mode (authored by Sebastian Falbesoner <sebastian.falbesoner@gmail.com>, committed by Fabien). · Explain WhyJul 3 2024, 06:41

This revision was automatically updated to reflect the committed changes.

Fabien added a commit: rABCb92367fd8163: test: MiniWallet: introduce enum type for output mode.

Revision Contents
Changeset List

Path

Size

test/

functional/

test_framework/

31 lines

Diff 48475

test/functional/test_framework/wallet.py

Loading...