Page MenuHomePhabricator
Differential D16430

Fix a data race that could prevent the staking reward to be added to the block template when longpoll is used
ClosedPublic
Actions

Authored by Fabien on Jul 7 2024, 20:07.

Details

Reviewers
PiRK
Group Reviewers
Restricted Project
Commits
rABCf249751062aa: Fix a data race that could prevent the staking reward to be added to the block…
Summary

This diff turns the best block global into a block index instead of a hash and performs a staking reward computation
upon longpoll interruption when building the block template. It avoids a data race where the template could be
constructed and returned before the computation of staking rewards is complete, leading to an empty winner and
potentially a rejected block.

Test Plan
for i in {1..1000}; do echo "Trial $i/1000" && ./test/functional/test_runner.py abc_mining_stakingrewards || break; done

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

Fabien created this revision.Jul 7 2024, 20:07
Herald added a reviewer: Restricted Project. · View Herald TranscriptJul 7 2024, 20:07
Fabien requested review of this revision.Jul 7 2024, 20:07
Fabien added a comment.Jul 7 2024, 20:07

@bot build-tsan

teamcity awarded a token.Jul 7 2024, 20:07
Fabien added a comment.Jul 7 2024, 20:11

@bot guix-linux

teamcity updated a token.Jul 7 2024, 20:11
Fabien updated this revision to Diff 48538.Jul 7 2024, 20:14

Add a release note

Fabien updated this revision to Diff 48539.Jul 7 2024, 20:20

Remove the 2nd node in the functional test (leftover of a previous version of the test)

Harbormaster completed remote builds in B29497: Diff 48537.Jul 7 2024, 20:26
Harbormaster completed remote builds in B29498: Diff 48538.Jul 7 2024, 20:40
Harbormaster completed remote builds in B29499: Diff 48539.Jul 7 2024, 20:57
PiRK accepted this revision.Jul 8 2024, 06:37
This revision is now accepted and ready to land.Jul 8 2024, 06:37
Closed by commit rABCf249751062aa: Fix a data race that could prevent the staking reward to be added to the block… (authored by Fabien). · Explain WhyJul 8 2024, 06:46
This revision was automatically updated to reflect the committed changes.
Fabien added a commit: rABCf249751062aa: Fix a data race that could prevent the staking reward to be added to the block….

Revision Contents
Changeset List

PathSize
doc/
2 lines
src/
rpc/
22 lines
test/
6 lines
2 lines
4 lines
test/
functional/
81 lines

Diff 48540

View Options

doc/release-notes.md

Loading...
View Options

src/rpc/mining.cpp

Loading...
View Options

src/test/validation_chainstate_tests.cpp

Loading...
View Options

src/validation.h

Loading...
View Options

src/validation.cpp

Loading...
View Options

test/functional/abc_mining_stakingrewards.py

Loading...