This diff turns the best block global into a block index instead of a hash and performs a staking reward computation
upon longpoll interruption when building the block template. It avoids a data race where the template could be
constructed and returned before the computation of staking rewards is complete, leading to an empty winner and
potentially a rejected block.
Details
Details
- Reviewers
PiRK - Group Reviewers
Restricted Project - Commits
- rABCf249751062aa: Fix a data race that could prevent the staking reward to be added to the block…
for i in {1..1000}; do echo "Trial $i/1000" && ./test/functional/test_runner.py abc_mining_stakingrewards || break; doneDiff Detail
Diff Detail
- Repository
- rABC Bitcoin ABC
- Branch
- fix_longpoll_stakingreward
- Lint
Lint Passed - Unit
No Test Coverage - Build Status
Buildable 29497 Build 58530: Build Diff lint-circular-dependencies · build-debug · build-without-wallet · build-diff · build-clang-tidy · build-clang Build 58529: arc lint + arc unit
Event Timeline
Comment Actions
Remove the 2nd node in the functional test (leftover of a previous version of the test)