Page MenuHomePhabricator

[Cashtab] Copy amounts on clikc
AbandonedPublic

Authored by bytesofman on Jul 15 2024, 01:52.

Details

Reviewers
emack
assasin-k7
Group Reviewers
Restricted Owners Package(Owns No Changed Paths)
Restricted Project
Summary

Clicking on the XEC amount copies it, removing the need for the
copy icon

Test Plan

I will add new CopyAmountPanel instead of CopyIconButton for this
and implemented copy exact amount when clikc amount number in Button.js.

Diff Detail

Repository
rABC Bitcoin ABC
Branch
bugfix
Lint
Lint Errors
SeverityLocationCodeMessage
Error/home/badluck/bitcoin-abc:FILESFilename, shebang or executable permission error
Error/home/badluck/bitcoin-abc:FILESFilename, shebang or executable permission error
Error/home/badluck/bitcoin-abc:FILESFilename, shebang or executable permission error
Error/home/badluck/bitcoin-abc:FILESFilename, shebang or executable permission error
Error/home/badluck/bitcoin-abc:FILESFilename, shebang or executable permission error
Error/home/badluck/bitcoin-abc:FILESFilename, shebang or executable permission error
Error/home/badluck/bitcoin-abc:FILESFilename, shebang or executable permission error
Error/home/badluck/bitcoin-abc:FILESFilename, shebang or executable permission error
Error/home/badluck/bitcoin-abc:FILESFilename, shebang or executable permission error
Error/home/badluck/bitcoin-abc:FILESFilename, shebang or executable permission error
Error/home/badluck/bitcoin-abc:FILESFilename, shebang or executable permission error
Error/home/badluck/bitcoin-abc:FILESFilename, shebang or executable permission error
Error/home/badluck/bitcoin-abc:FILESFilename, shebang or executable permission error
Error/home/badluck/bitcoin-abc:FILESFilename, shebang or executable permission error
Error/home/badluck/bitcoin-abc:FILESFilename, shebang or executable permission error
Error/home/badluck/bitcoin-abc:FILESFilename, shebang or executable permission error
Error/home/badluck/bitcoin-abc:FILESFilename, shebang or executable permission error
Error/home/badluck/bitcoin-abc:FILESFilename, shebang or executable permission error
Error/home/badluck/bitcoin-abc:FILESFilename, shebang or executable permission error
Error/home/badluck/bitcoin-abc:FILESFilename, shebang or executable permission error
Error/home/badluck/bitcoin-abc:FILESFilename, shebang or executable permission error
Error/home/badluck/bitcoin-abc:FILESFilename, shebang or executable permission error
Error/home/badluck/bitcoin-abc:FILESFilename, shebang or executable permission error
Error/home/badluck/bitcoin-abc:FILESFilename, shebang or executable permission error
Error/home/badluck/bitcoin-abc:FILESFilename, shebang or executable permission error
Unit
No Test Coverage
Build Status
Buildable 29551
Build 58637: Build Diffcashtab-tests · ecash-lib-tests
Build 58636: arc lint + arc unit

Event Timeline

Owners added a reviewer: Restricted Owners Package.Jul 15 2024, 01:52
emack requested changes to this revision.Jul 15 2024, 05:14
emack added a subscriber: emack.

The actual change itself is not as described, you're merely fixing a typo - then title it as such.
You need to fix the linting errors before pushing. Do an arc lint locally.
Test plan needs to be something the reviewer can follow easily easily e.g.

  1. npm test
  2. click here, check blah...
This revision now requires changes to proceed.Jul 15 2024, 05:14

@assasin-k7 So now we have a title, and an idea of what you're trying to achieve.

Neither this nor D16464 is doing any of what the title says, and I've seen no question asked nor help requested to get the workflow properly working.

So either you start gathering information and you make this diff correct, or I disable your user. Same if you open another diff. The only reason I leave this open for now is so you can see this message.

bytesofman added a reviewer: assasin-k7.
bytesofman added a subscriber: bytesofman.

will commandeer to abandon as notice has been up long enough, dev is also in touch via telegram