Page MenuHomePhabricator

[e.cash] Bump nodejs version used for deployments
ClosedPublic

Authored by bytesofman on Jul 16 2024, 22:19.

Details

Reviewers
Fabien
Group Reviewers
Restricted Project
Commits
rABC4f434d26d2dd: [e.cash] Bump nodejs version used for deployments
Summary

Upgrading other dependencies breaks prod deployments due to these dependencies no longer supporting node 16

Update to node 20

Stop linting the lib directory (we do not have a lib directory in this repo...but this causes lint issues during npm run build)

Test Plan

@bot preview-e.cash

Diff Detail

Repository
rABC Bitcoin ABC
Branch
ecash-landing-to-node-20
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 29600
Build 58735: Build Diff
Build 58734: arc lint + arc unit

Event Timeline

Fabien added a subscriber: Fabien.

@bot preview-e.cash

This revision is now accepted and ready to land.Jul 17 2024, 07:18

Tail of the build log:

#6 [2/5] COPY . .
#6 sha256:edb7fe4193149b0246dd56996d178f1fc97502cafd34ad597f8ba4e8a7c6505e
#6 DONE 0.7s

#7 [3/5] COPY next.preview.js next.config.js
#7 sha256:9f5cfa6d865e8703bd09e9f1f5d5f11fd62b35a5f107342a30718353f70306d5
#7 DONE 0.1s

#8 [4/5] RUN npm ci
#8 sha256:99a62dfa28c2af606041fdabbe26fabe6288886a0b035e04a9b70af1fd5dfb56
#8 9.532 
#8 9.532 added 819 packages, and audited 820 packages in 9s
#8 9.532 
#8 9.532 154 packages are looking for funding
#8 9.532   run `npm fund` for details
#8 9.556 
#8 9.556 3 high severity vulnerabilities
#8 9.556 
#8 9.556 To address issues that do not require attention, run:
#8 9.556   npm audit fix
#8 9.556 
#8 9.556 To address all issues, run:
#8 9.556   npm audit fix --force
#8 9.556 
#8 9.556 Run `npm audit` for details.
#8 9.556 npm notice
#8 9.556 npm notice New minor version of npm available! 10.7.0 -> 10.8.2
#8 9.556 npm notice Changelog: https://github.com/npm/cli/releases/tag/v10.8.2
#8 9.556 npm notice To update run: npm install -g npm@10.8.2
#8 9.556 npm notice
#8 DONE 10.0s

#9 [5/5] RUN npm run build
#9 sha256:349bcbbdead7a54556d3eef559e4363fe13f9f149d9a816631173ed1734b422c
#9 0.637 
#9 0.637 > e.cash@0.0.1 build
#9 0.637 > next build
#9 0.637 
#9 1.098 Attention: Next.js now collects completely anonymous telemetry regarding usage.
#9 1.100 This information is used to shape Next.js' roadmap and prioritize features.
#9 1.100 You can learn more, including how to opt-out if you'd not like to participate in this anonymous program, by visiting the following URL:
#9 1.101 https://nextjs.org/telemetry
#9 1.101 
#9 1.197    Linting and checking validity of types ...
#9 2.832 
#9 2.832 Failed to compile.
#9 2.832 
#9 2.832 ./lib/python3/dist-packages/mercurial/templates/static/followlines.js
#9 2.832 9:1  Error: incorrect header  header/header
#9 2.832 
#9 2.832 ./lib/python3/dist-packages/mercurial/templates/static/mercurial.js
#9 2.832 16:1  Error: incorrect header  header/header
#9 2.832 
#9 2.832 info  - Need to disable some ESLint rules? Learn more here: https://nextjs.org/docs/basic-features/eslint#disabling-rules
#9 ERROR: executor failed running [/bin/sh -c npm run build]: exit code: 1
------
 > [5/5] RUN npm run build:
------
executor failed running [/bin/sh -c npm run build]: exit code: 1
Build preview-e.cash failed with exit code 1
Fabien requested changes to this revision.Jul 17 2024, 07:36
This revision now requires changes to proceed.Jul 17 2024, 07:36

back out lib change, different node image (same as docs)

This revision is now accepted and ready to land.Jul 17 2024, 17:40