Page MenuHomePhabricator

[CI] Install nodejs with nvm instead of apt
DraftPublic

Authored by bytesofman on Jul 16 2024, 23:04.
This is a draft revision that has not yet been submitted for review.

Details

Reviewers
None
Group Reviewers
Restricted Project
Summary

Current method of installing is brittle, as the setup script is not version pinned and can change (has twice now).

Here, we still install a setup script, but it is version pinned so (should) remain the same until we change node or nvm versions.

Test Plan

@bot cashtab-tests

Diff Detail

Repository
rABC Bitcoin ABC
Branch
node-install-improve
Lint
Lint Warnings
SeverityLocationCodeMessage
Warningcontrib/utils/install-dependencies-bullseye.sh:166SC1090ShellCheck found an issue:
Unit
No Test Coverage
Build Status
Buildable 29595
Build 58725: Build Diff
Build 58724: arc lint + arc unit

Event Timeline

There are a very large number of changes, so older changes are hidden. Show Older Changes

Tail of the build log:

Test depends on ecashaddrjs. Installing ecashaddrjs dependencies...
/work/modules/ecashaddrjs /work/abc-ci-builds/ecash-herald-tests
/work/abc-ci-builds/ecash-herald-tests/script.sh: line 21: npm: command not found
Build ecash-herald-tests failed with exit code 127

alias node to latest version installed

Tail of the build log:

Test depends on ecashaddrjs. Installing ecashaddrjs dependencies...
/work/modules/ecashaddrjs /work/abc-ci-builds/ecash-herald-tests
/work/abc-ci-builds/ecash-herald-tests/script.sh: line 21: npm: command not found
Build ecash-herald-tests failed with exit code 127
The build failed due to an unexpected infrastructure outage. The administrators have been notified to investigate. Sorry for the inconvenience.

update path syntax with escape characters and quotes, back out combined source command

The build failed due to an unexpected infrastructure outage. The administrators have been notified to investigate. Sorry for the inconvenience.

verbose tar unpacking to check, match path syntax of python install above

The build failed due to an unexpected infrastructure outage. The administrators have been notified to investigate. Sorry for the inconvenience.

remove debug log, remove ':' after $PATH, add absolute path with /root

The build failed due to an unexpected infrastructure outage. The administrators have been notified to investigate. Sorry for the inconvenience.
The build failed due to an unexpected infrastructure outage. The administrators have been notified to investigate. Sorry for the inconvenience.
The build failed due to an unexpected infrastructure outage. The administrators have been notified to investigate. Sorry for the inconvenience.

patch typo for install script

The build failed due to an unexpected infrastructure outage. The administrators have been notified to investigate. Sorry for the inconvenience.

adding debug logging and permissions check logging

The build failed due to an unexpected infrastructure outage. The administrators have been notified to investigate. Sorry for the inconvenience.

Tail of the build log:

Test depends on ecashaddrjs. Installing ecashaddrjs dependencies...
/work/modules/ecashaddrjs /work/abc-ci-builds/ecash-herald-tests
/work/abc-ci-builds/ecash-herald-tests/script.sh: line 21: npm: command not found
Build ecash-herald-tests failed with exit code 127
The build failed due to an unexpected infrastructure outage. The administrators have been notified to investigate. Sorry for the inconvenience.
The build failed due to an unexpected infrastructure outage. The administrators have been notified to investigate. Sorry for the inconvenience.

remove intentional failure and debug logging from the setup script

Tail of the build log:

Test depends on ecashaddrjs. Installing ecashaddrjs dependencies...
/work/modules/ecashaddrjs /work/abc-ci-builds/ecash-herald-tests
/work/abc-ci-builds/ecash-herald-tests/script.sh: line 21: npm: command not found
Build ecash-herald-tests failed with exit code 127

Tail of the build log:

/root/.cargo/bin:/work/node-v20.15.1-linux-x64/bin:/root/.local/bin:/usr/local/sbin:/usr/local/bin:/usr/sbin:/usr/bin:/sbin:/bin
root
Test depends on ecashaddrjs. Installing ecashaddrjs dependencies...
/work/modules/ecashaddrjs /work/abc-ci-builds/ecash-herald-tests
/work/abc-ci-builds/ecash-herald-tests/script.sh: line 25: npm: command not found
Build ecash-herald-tests failed with exit code 127

Tail of the build log:

/root/.cargo/bin:/work/node-v20.15.1-linux-x64/bin:/root/.local/bin:/usr/local/sbin:/usr/local/bin:/usr/sbin:/usr/bin:/sbin:/bin
root
Test depends on ecashaddrjs. Installing ecashaddrjs dependencies...
/work/modules/ecashaddrjs /work/abc-ci-builds/ecash-herald-tests
/work/abc-ci-builds/ecash-herald-tests/script.sh: line 25: npm: command not found
Build ecash-herald-tests failed with exit code 127